OFBiz
  1. OFBiz
  2. OFBIZ-3654

Returning "failure" from a shipment estimator has no impact on subsequent processing

    Details

    • Type: Bug Bug
    • Status: Closed
    • Priority: Major Major
    • Resolution: Won't Fix
    • Affects Version/s: None
    • Fix Version/s: None
    • Component/s: product
    • Labels:
      None
    • Sprint:
      Bug Crush Event - 21/2/2015

      Description

      The UPS processor includes a comment "Important: DO NOT returnError here or you could trigger a transaction rollback and break other services." Returning a failure, however, is basically ignored and only causes the estimate to return a zero amount estimate. It should be possible to return a proper error message for further processing.

        Activity

        Hide
        Taher Alkhateeb added a comment -

        This issue cannot be resolved because of design problems in the entire checkout process and the way sessions are stored. Hence, we will close this issue and open another one later on to figure out how to simplify the overly complex order workflow.

        Show
        Taher Alkhateeb added a comment - This issue cannot be resolved because of design problems in the entire checkout process and the way sessions are stored. Hence, we will close this issue and open another one later on to figure out how to simplify the overly complex order workflow.
        Hide
        Jacques Le Roux added a comment -

        I agree Taher, thanks for your investigation.

        Show
        Jacques Le Roux added a comment - I agree Taher, thanks for your investigation.
        Hide
        Taher Alkhateeb added a comment -

        I investigated this issue a little bit and found the below commit logs from Si Chen

        r549561 | sichen | 2007-06-21 20:35:00 +0300 (Thu, 21 Jun 2007) | 1 line

        Fix a potential rollback crash if upsRateEstimateByPostalCode is called for an address with a missing zip code. By returning failure instead of using service engine to validate zip code, we avoid a rollback which could crash checkout screens
        ------------------------------------------------------------------------
        r547355 | sichen | 2007-06-14 21:50:30 +0300 (Thu, 14 Jun 2007) | 1 line

        Changed returnError to returnFailure in UPS rate inquire services, so failing to get a UPS rate doesn't crash your whole checkout process

        The whole order session design is problematic, so this JIRA should be closed and instead a redesign of the entire checkout session management problem is in order.

        Show
        Taher Alkhateeb added a comment - I investigated this issue a little bit and found the below commit logs from Si Chen r549561 | sichen | 2007-06-21 20:35:00 +0300 (Thu, 21 Jun 2007) | 1 line Fix a potential rollback crash if upsRateEstimateByPostalCode is called for an address with a missing zip code. By returning failure instead of using service engine to validate zip code, we avoid a rollback which could crash checkout screens ------------------------------------------------------------------------ r547355 | sichen | 2007-06-14 21:50:30 +0300 (Thu, 14 Jun 2007) | 1 line Changed returnError to returnFailure in UPS rate inquire services, so failing to get a UPS rate doesn't crash your whole checkout process The whole order session design is problematic, so this JIRA should be closed and instead a redesign of the entire checkout session management problem is in order.

          People

          • Assignee:
            Unassigned
            Reporter:
            Ean Schuessler
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development

                Agile