OFBiz
  1. OFBiz
  2. OFBIZ-3554

Delegator removeByXXX do not trigger remove ECA

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: Release Branch 09.04, Trunk
    • Fix Version/s: None
    • Component/s: framework
    • Labels:
      None
    • Sprint:
      Bug Crush Event - 21/2/2015

      Description

      The removeByAnd / removeByCondition and by extension i think the removeAll methods do not trigger the remove ECA on the entities.

      So for example:

      No trigger
       removeByAnd("FooBar", map);
      

      Compared to:

      With trigger
       List entities = delegator.findByAnd("FooBar", map);
       for (GenericValue v : entities) {
         delegator.removeValue(v);
        }
      

        Activity

        Hide
        Divesh Dutta added a comment -

        Should we consider this as a bug? This question comes because, EECA rules does not work on storeByCondition and storeAll methods as well. And if this is a bug then, EECA rules should also work on storeByCondition and storeAll methods.

        Currently EECA rules only triggers on store and removeValue methods.

        Show
        Divesh Dutta added a comment - Should we consider this as a bug? This question comes because, EECA rules does not work on storeByCondition and storeAll methods as well. And if this is a bug then, EECA rules should also work on storeByCondition and storeAll methods. Currently EECA rules only triggers on store and removeValue methods.
        Hide
        Divesh Dutta added a comment -

        If this is concluded as a bug, then I am providing a patch to fix this issue, because I have already worked on this ticket. Also tested the patch by writing custom service and its working fine.

        This patch will trigger ECA rules for removeByAnd, removeByCondition and removeAll , removeRelated methods.

        For storeAll and storeByCondition, we can create separate jira issue and fix that as well.

        Show
        Divesh Dutta added a comment - If this is concluded as a bug, then I am providing a patch to fix this issue, because I have already worked on this ticket. Also tested the patch by writing custom service and its working fine. This patch will trigger ECA rules for removeByAnd, removeByCondition and removeAll , removeRelated methods. For storeAll and storeByCondition, we can create separate jira issue and fix that as well.

          People

          • Assignee:
            Adam Heath
            Reporter:
            Wickersheimer Jeremy
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development

                Agile