Details

      Description

      While working on the layered lookup I found some quirks in the Party Component. I think most of them certainly exist also in other components since they look more like neglicted CSS and fixing them here will fix a lot of other places. Still these buttons looks inconsistency, I think we should definitively tackle that and get it out of OFBiz.

      1. screenshot-1.jpg
        104 kB
        Jacques Le Roux
      2. screenshot-10.jpg
        51 kB
        Jacques Le Roux
      3. screenshot-2.jpg
        90 kB
        Jacques Le Roux
      4. screenshot-3.jpg
        73 kB
        Jacques Le Roux
      5. screenshot-4.jpg
        41 kB
        Jacques Le Roux
      6. screenshot-5.jpg
        51 kB
        Jacques Le Roux
      7. screenshot-6.jpg
        52 kB
        Jacques Le Roux
      8. screenshot-7.jpg
        92 kB
        Jacques Le Roux
      9. screenshot-8.jpg
        38 kB
        Jacques Le Roux
      10. screenshot-9.jpg
        14 kB
        Jacques Le Roux

        Issue Links

          Activity

          Hide
          Jacques Le Roux added a comment -

          Was fixed in trunk at r1056803, R10.04 at r1056805.

          Show
          Jacques Le Roux added a comment - Was fixed in trunk at r1056803, R10.04 at r1056805.
          Hide
          Bruno Busco added a comment -

          Fixed screenshot-4 and screenshot-6 in trunk at rev 919239

          Show
          Bruno Busco added a comment - Fixed screenshot-4 and screenshot-6 in trunk at rev 919239
          Hide
          Jacques Le Roux added a comment -

          screenshot-10: Workeffort menu
          https://localhost:58443/workeffort/control/UserJobs
          It's hard to distinguish the iCalendar menu option from the background. A bit pernickety but maybe we could have a slighlty more different color for the menu background (or the main background) to better distinguish the menu options in such cases

          Show
          Jacques Le Roux added a comment - screenshot-10: Workeffort menu https://localhost:58443/workeffort/control/UserJobs It's hard to distinguish the iCalendar menu option from the background. A bit pernickety but maybe we could have a slighlty more different color for the menu background (or the main background) to better distinguish the menu options in such cases
          Hide
          Jacques Le Roux added a comment -

          A comment from Bruno about the lookups icons on dev ML:

          This is not related to the theme itself but must be fixed in the FTL files.
          What happens is that the FTL files renders the lookup fields with a
          different HTML from what is rendered by the form widget.
          In order to make OFBiz more consistent we need to have the FTL
          generate the same HTML structure as the form widget and not to have
          the theme do all the work to handle all variants of things.

          The lookups in the FTL in https://ofbiz-vm.apache.org/catalog/control/main
          have this HTML:

          <div>
            <label for="keywordSearchCategoryId">Category ID:</label>
            <input type="text" name="SEARCH_CATEGORY_ID" id="keywordSearchCategoryId" size="15" maxlength="20" value=""/>
            <a href="javascript:call_fieldlookup2($('keywordSearchCategoryId'),'LookupProductCategory');">
              <img src='/images/fieldlookup.gif' width='15' height='14' alt="Click here For Field Lookup" />
            </a>
          </div>
          

          but if you go in
          https://ofbiz-vm.apache.org/assetmaint/control/EditFixedAsset?fixedAssetId=DEMO_PROJECTOR
          you will see that the lookups have this HTML:

          <div class="field-lookup">
            <ul>
              <li><input type="text" name="parentFixedAssetId" size="25" id="EditFixedAsset_parentFixedAssetId"/></li>
              <li>
                <a href="javascript:call_fieldlookup2(document.EditFixedAsset.parentFixedAssetId,'LookupFixedAsset');">
                  <span id="EditFixedAsset_parentFixedAssetId_indicator" style="display:none" class="indicator">
                      <img/>
                  </span>
                </a>
              </li>
            </ul>
          </div>
          

          Using this HTML all the themes already handle it very well. Every theme can specify a different icon and tomahawk uses a very nice card icon with a transparent background.

          Show
          Jacques Le Roux added a comment - A comment from Bruno about the lookups icons on dev ML: This is not related to the theme itself but must be fixed in the FTL files. What happens is that the FTL files renders the lookup fields with a different HTML from what is rendered by the form widget. In order to make OFBiz more consistent we need to have the FTL generate the same HTML structure as the form widget and not to have the theme do all the work to handle all variants of things. The lookups in the FTL in https://ofbiz-vm.apache.org/catalog/control/main have this HTML: <div> <label for = "keywordSearchCategoryId" >Category ID:</label> <input type= "text" name= "SEARCH_CATEGORY_ID" id= "keywordSearchCategoryId" size= "15" maxlength= "20" value=""/> <a href= "javascript:call_fieldlookup2($('keywordSearchCategoryId'),'LookupProductCategory');" > <img src='/images/fieldlookup.gif' width='15' height='14' alt= "Click here For Field Lookup" /> </a> </div> but if you go in https://ofbiz-vm.apache.org/assetmaint/control/EditFixedAsset?fixedAssetId=DEMO_PROJECTOR you will see that the lookups have this HTML: <div class= "field-lookup" > <ul> <li><input type= "text" name= "parentFixedAssetId" size= "25" id= "EditFixedAsset_parentFixedAssetId" /></li> <li> <a href= "javascript:call_fieldlookup2(document.EditFixedAsset.parentFixedAssetId,'LookupFixedAsset');" > <span id= "EditFixedAsset_parentFixedAssetId_indicator" style= "display:none" class= "indicator" > <img/> </span> </a> </li> </ul> </div> Using this HTML all the themes already handle it very well. Every theme can specify a different icon and tomahawk uses a very nice card icon with a transparent background.
          Hide
          Jacques Le Roux added a comment -

          screenshot-9: Person/Customer/Prospect, color of save (prospect) Cancel/Done buttons
          https://localhost:8443/partymgr/control/NewProspect
          https://localhost:8443/partymgr/control/editperson?create_new=Y

          Show
          Jacques Le Roux added a comment - screenshot-9: Person/Customer/Prospect, color of save (prospect) Cancel/Done buttons https://localhost:8443/partymgr/control/NewProspect https://localhost:8443/partymgr/control/editperson?create_new=Y
          Hide
          Jacques Le Roux added a comment -
          Show
          Jacques Le Roux added a comment - screenshot-8: Party creation https://localhost:8443/partymgr/control/createnew
          Hide
          Jacques Le Roux added a comment -

          screenshot-7: VIsits, next links
          https://localhost:8443/partymgr/control/showvisits

          Show
          Jacques Le Roux added a comment - screenshot-7: VIsits, next links https://localhost:8443/partymgr/control/showvisits
          Hide
          Jacques Le Roux added a comment -
          Show
          Jacques Le Roux added a comment - screenshot-6: Cert Issuer https://localhost:8443/partymgr/control/EditCertIssuerProvisions
          Hide
          Jacques Le Roux added a comment -
          Show
          Jacques Le Roux added a comment - screenshot-5: Address Match Map https://localhost:8443/partymgr/control/addressMatchMap
          Hide
          Jacques Le Roux added a comment -
          Show
          Jacques Le Roux added a comment - screenshot-4: Security https://localhost:8443/partymgr/control/EditSecurityGroup
          Hide
          Jacques Le Roux added a comment -
          Show
          Jacques Le Roux added a comment - screenshot-3: Shopping lists https://localhost:8443/partymgr/control/editShoppingList?partyId=admin
          Show
          Jacques Le Roux added a comment - - edited screenshot-2: https://localhost:8443/partymgr/control/linkparty?partyId=admin
          Hide
          Jacques Le Roux added a comment - - edited

          screenshot-1: Party Profile: see AVS Override screenlet: blue links
          https://localhost:8443/partymgr/control/viewprofile?partyId=admin

          Show
          Jacques Le Roux added a comment - - edited screenshot-1: Party Profile: see AVS Override screenlet: blue links https://localhost:8443/partymgr/control/viewprofile?partyId=admin

            People

            • Assignee:
              Jacques Le Roux
              Reporter:
              Jacques Le Roux
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development