Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: framework
    • Labels:
      None

      Description

      Hi Jacques, hi all

      i created a new patch for the layer lookup field.

      This Patch contains the patches OFBIZ-3491, OFBIZ-3492 (i will close the issues).

      Furthermore i added a flag to fade the background when a layer opened. In my opinion it's nesseary when i want to give a focus to my lookup.
      After apllying the patch the picture faded_background.png have to be copied to the image folder of each theme.

      Have a nice day

      Sascha

      1. OFBIZ-3524_Fade_Background.patch
        36 kB
        Sascha Rodekamp
      2. OFBIZ-3524_Fade_Background.patch
        25 kB
        Sascha Rodekamp
      3. faded_background.png
        0.3 kB
        Sascha Rodekamp
      4. no_faded_background.jpg
        193 kB
        Sascha Rodekamp
      5. fadedBackground.jpg
        173 kB
        Sascha Rodekamp
      6. OFBIZ-3524_FadeBackgroundFix.patch
        4 kB
        Sascha Rodekamp

        Activity

        Hide
        Sascha Rodekamp added a comment -

        Thanks Jacques

        Show
        Sascha Rodekamp added a comment - Thanks Jacques
        Hide
        Jacques Le Roux added a comment -

        Thanks Sascha,

        Committed in trunk at r920061

        Show
        Jacques Le Roux added a comment - Thanks Sascha, Committed in trunk at r920061
        Hide
        Sascha Rodekamp added a comment -

        Hi Jacques,

        We don't use the lookups for now, it wasn't an issue yet. But i hope/think we will use theme in our new project
        here a little fix for the faded background.
        I made the fading as default.

        Cu
        Sascha

        Show
        Sascha Rodekamp added a comment - Hi Jacques, We don't use the lookups for now, it wasn't an issue yet. But i hope/think we will use theme in our new project here a little fix for the faded background. I made the fading as default. Cu Sascha
        Hide
        Jacques Le Roux added a comment -

        Hi Sascha,

        No worries, I think I will either do it myself if I get a chance else I will wait you before commiting. Because as Tomahawk is now the default theme in some case the links in the list are hardly readable. It would be a pity to get a 1st bad impression with such a nice work. Anyway we are sure now that it will part of the next release and as I'm using them (I mean a team is working with layered lookup without any bugs in a beta custom app) for more than a month now, I'm pretty confident about the robustness. BTW are you using it also in production or beta?

        Show
        Jacques Le Roux added a comment - Hi Sascha, No worries, I think I will either do it myself if I get a chance else I will wait you before commiting. Because as Tomahawk is now the default theme in some case the links in the list are hardly readable. It would be a pity to get a 1st bad impression with such a nice work. Anyway we are sure now that it will part of the next release and as I'm using them (I mean a team is working with layered lookup without any bugs in a beta custom app) for more than a month now, I'm pretty confident about the robustness. BTW are you using it also in production or beta?
        Hide
        Sascha Rodekamp added a comment -

        Jap Jacques, good point, i like the idea.
        I'm a little bit in trouble the next two days, i will have a look on friday and fixes the bugs you posted.

        Show
        Sascha Rodekamp added a comment - Jap Jacques, good point, i like the idea. I'm a little bit in trouble the next two days, i will have a look on friday and fixes the bugs you posted.
        Hide
        Jacques Le Roux added a comment -

        Sascha,

        Woud you like at term to have this attribute by default as we plan for layer and centered?

        Show
        Jacques Le Roux added a comment - Sascha, Woud you like at term to have this attribute by default as we plan for layer and centered?
        Hide
        Jacques Le Roux added a comment -

        Sascha,

        Yes I agree, maybe it was a brower cache issue for the fading stuff.

        If, in a copy of the trunk at r917915 in the Example component using the default theme (now Tomahawk), you reset the description-field-name attribute of the 2d lookup (the one centered) fro "partyIdFrom" to "partyIdTo" and you will see 2 things in order:

        1. when you will have pushed the find button you will see that we have a problem with links color, should not be a big deal since it works in Bizness Time but I did not have a chance to look at it yet, not a priority anyway. I created OFBIZ-3527 but anyway I guess you certainly saw it already.
        2. When you will have selected the party and back to the screen you will see that the wrong field is filled (the 1st instead of the 2d). Maybe it was what you were trying to do, but then IMO it's most confusing

        Actually, I use the fieldlookupLayer3 in a custom application. It has been introduced from this custom application in the trunk. What we do is having a hidden field with the same name than the description-field-name where we get back the Id value. We use the default-value to show the names, etc. if any (when coming back to the screen with a record already filled).

        I hope to commit the OFBIZ-3442 big patch very soon, maybe today, at least this week... In the meantime I will refresh it with the last changes BTW...

        Show
        Jacques Le Roux added a comment - Sascha, Yes I agree, maybe it was a brower cache issue for the fading stuff. If, in a copy of the trunk at r917915 in the Example component using the default theme (now Tomahawk), you reset the description-field-name attribute of the 2d lookup (the one centered) fro "partyIdFrom" to "partyIdTo" and you will see 2 things in order: when you will have pushed the find button you will see that we have a problem with links color, should not be a big deal since it works in Bizness Time but I did not have a chance to look at it yet, not a priority anyway. I created OFBIZ-3527 but anyway I guess you certainly saw it already. When you will have selected the party and back to the screen you will see that the wrong field is filled (the 1st instead of the 2d). Maybe it was what you were trying to do, but then IMO it's most confusing Actually, I use the fieldlookupLayer3 in a custom application. It has been introduced from this custom application in the trunk. What we do is having a hidden field with the same name than the description-field-name where we get back the Id value. We use the default-value to show the names, etc. if any (when coming back to the screen with a record already filled). I hope to commit the OFBIZ-3442 big patch very soon, maybe today, at least this week... In the meantime I will refresh it with the last changes BTW...
        Hide
        Sascha Rodekamp added a comment -

        Hi Jacques,

        Thanks.

        I had a fresh checkout and the patch worked fine for me!

        I set the description-field-name to "partyIdFrom" instead of "partyIdTo". To show how the fieldlookupLayer3 works. The lookup uses setValues and set the full name to the partyIdFrom field and the partyId to the partyIdTo field. Maybe a little bit confusing because of the field naming (just a showcase). I will create a seperate input field that can be filled.

        Thanks for your help.

        Sascha

        Show
        Sascha Rodekamp added a comment - Hi Jacques, Thanks. I had a fresh checkout and the patch worked fine for me! I set the description-field-name to "partyIdFrom" instead of "partyIdTo". To show how the fieldlookupLayer3 works. The lookup uses setValues and set the full name to the partyIdFrom field and the partyId to the partyIdTo field. Maybe a little bit confusing because of the field naming (just a showcase). I will create a seperate input field that can be filled. Thanks for your help. Sascha
        Hide
        Jacques Le Roux added a comment -

        Commited in trunk at r917940

        Show
        Jacques Le Roux added a comment - Commited in trunk at r917940
        Hide
        Jacques Le Roux added a comment -

        Thanks Sascha,

        I did not look at the code yesterday evening, it's quite clear now. I was thinking you spoke about the lookup backgroud. I have still the same problem than yesterday though: applying your patch and copying the image in all themes to a clean copy at r917915 I don't see the effect on the partyIdTo lookup in Example though I see fade-background="true" in. What could I be missing?

        Also I noticed few tabs in framework/images/webapp/images/fieldlookup.js but don't wory about them this time. I will remove them (it's easier for me than applying a new patch).

        OK, I have just found the reason: in your OFBIZ-3491 patch you put the wrong Id for description-field-name="partyIdFrom" should be description-field-name="partyIdTo".

        OK I will commit, now...

        Show
        Jacques Le Roux added a comment - Thanks Sascha, I did not look at the code yesterday evening, it's quite clear now. I was thinking you spoke about the lookup backgroud. I have still the same problem than yesterday though: applying your patch and copying the image in all themes to a clean copy at r917915 I don't see the effect on the partyIdTo lookup in Example though I see fade-background="true" in. What could I be missing? Also I noticed few tabs in framework/images/webapp/images/fieldlookup.js but don't wory about them this time. I will remove them (it's easier for me than applying a new patch). OK, I have just found the reason: in your OFBIZ-3491 patch you put the wrong Id for description-field-name="partyIdFrom" should be description-field-name="partyIdTo". OK I will commit, now...
        Hide
        Sascha Rodekamp added a comment -

        Hi Jacques,
        i attached to screenshots, with and without a faded background.
        In the example screen you can see the effect when calling the second lookup.

        I added a flag called faded-background for the xml files, if this flag is set to true, the background will be faded.
        Means: The js class creates a seperate div under the lookup div which has the height and width from the whole page
        and a repeating background (fade_background.png). This png file has a transparency effect, so if the new layer under the lookuplayer calls this image you see
        the effect which is shown on the screenshots (the effect disapears if the layer is closed).

        Understand what i'm doing here ?

        Bye
        Sascha

        Show
        Sascha Rodekamp added a comment - Hi Jacques, i attached to screenshots, with and without a faded background. In the example screen you can see the effect when calling the second lookup. I added a flag called faded-background for the xml files, if this flag is set to true, the background will be faded. Means: The js class creates a seperate div under the lookup div which has the height and width from the whole page and a repeating background (fade_background.png). This png file has a transparency effect, so if the new layer under the lookuplayer calls this image you see the effect which is shown on the screenshots (the effect disapears if the layer is closed). Understand what i'm doing here ? Bye Sascha
        Hide
        Jacques Le Roux added a comment -

        Sascha,

        I'm sorry but I don't see exactly how, when and where the fading is rendered. Could you explain in more details please? Maybe 2 pictures (before/after) will help?

        Thanks

        Show
        Jacques Le Roux added a comment - Sascha, I'm sorry but I don't see exactly how, when and where the fading is rendered. Could you explain in more details please? Maybe 2 pictures (before/after) will help? Thanks
        Hide
        Sascha Rodekamp added a comment -

        Hi Jacques.

        In my opinion it's nesseary when i want to give a focus to my lookup, it can be helpfull to dim the background (and it's a nice effect i think ).

        The fade_background.png is the image which is responsable for the backgroundfading, i put it in every theme that the fading color can be set theme sprecific (if someone want to).

        Show
        Sascha Rodekamp added a comment - Hi Jacques. In my opinion it's nesseary when i want to give a focus to my lookup, it can be helpfull to dim the background (and it's a nice effect i think ). The fade_background.png is the image which is responsable for the backgroundfading, i put it in every theme that the fading color can be set theme sprecific (if someone want to).
        Hide
        Jacques Le Roux added a comment -

        Hi Sascha,

        Could you please explain why it's necessary?

        Show
        Jacques Le Roux added a comment - Hi Sascha, Could you please explain why it's necessary?
        Hide
        Sascha Rodekamp added a comment -

        Hi Jacques,

        so i created a new (seperate) patch for the fading backgorund.

        The fade_background.png image have to put in the following folders:

        bizznesstime/webapp/bizznesstime/images/
        blulight/webapp/bluelight/images/
        droppingcrumbs/webapp/droppingcrumbs/images/
        flatgrey/webapp/flatgrey/
        tomahawk/webapp/tomahawk/images/

        Show
        Sascha Rodekamp added a comment - Hi Jacques, so i created a new (seperate) patch for the fading backgorund. The fade_background.png image have to put in the following folders: bizznesstime/webapp/bizznesstime/images/ blulight/webapp/bluelight/images/ droppingcrumbs/webapp/droppingcrumbs/images/ flatgrey/webapp/flatgrey/ tomahawk/webapp/tomahawk/images/
        Hide
        Jacques Le Roux added a comment -

        Hi Sascha,

        I have commited the patches for OFBIZ-3491 and OFBIZ-3492 (no need to put links for Jira issues, it's even better without links since then Jira can mark (strike) the issues closed. Could you please create a patch with the only changes for this issue?

        TIA

        Show
        Jacques Le Roux added a comment - Hi Sascha, I have commited the patches for OFBIZ-3491 and OFBIZ-3492 (no need to put links for Jira issues, it's even better without links since then Jira can mark (strike) the issues closed. Could you please create a patch with the only changes for this issue? TIA

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            Sascha Rodekamp
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development