Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Later
    • Affects Version/s: Release Branch 09.04, Trunk
    • Fix Version/s: Trunk
    • Component/s: None
    • Labels:
      None
    • Environment:

      ant build

      Description

      I liked the build script for a new component, so I decided to make one for themes.
      unfortunately I am not able to do a patch so included the script.

      I made it so you can pick a theme as the template and copy the files over to the new theme.

        Activity

        Hide
        BJ Freeman added a comment -

        this is not a patch for the actual script

        Show
        BJ Freeman added a comment - this is not a patch for the actual script
        Hide
        BJ Freeman added a comment -

        once a create an new theme I compare between the new one and one I did not use as a source to see what needs to be changed.

        Show
        BJ Freeman added a comment - once a create an new theme I compare between the new one and one I did not use as a source to see what needs to be changed.
        Hide
        BJ Freeman added a comment -

        hear is the patch

        Show
        BJ Freeman added a comment - hear is the patch
        Hide
        BJ Freeman added a comment -

        I see a create-theme in the build
        can not find the commit for it so can not reference when it was put in.
        so closing this issue.

        Show
        BJ Freeman added a comment - I see a create-theme in the build can not find the commit for it so can not reference when it was put in. so closing this issue.
        Hide
        Jacques Le Roux added a comment -

        Hi BJ,

        I think the create-theme target you saw is your own because there are none in the build file. BTW I wonder what's the point since it's easy to simply copy a theme dir and then poke in. Did you do something more in your patch (I did not take the time to review)?

        Thanks

        Show
        Jacques Le Roux added a comment - Hi BJ, I think the create-theme target you saw is your own because there are none in the build file. BTW I wonder what's the point since it's easy to simply copy a theme dir and then poke in. Did you do something more in your patch (I did not take the time to review)? Thanks
        Hide
        BJ Freeman added a comment -

        your are probably correct.
        as far as the script, if you copy you are ask to rename the top folder but the sub-folders and files are not renamed.
        like the data file and the folder under webapp.
        it is not a big thing but it is easier than remembering what has to done.

        Show
        BJ Freeman added a comment - your are probably correct. as far as the script, if you copy you are ask to rename the top folder but the sub-folders and files are not renamed. like the data file and the folder under webapp. it is not a big thing but it is easier than remembering what has to done.
        Hide
        Jacques Le Roux added a comment -

        I see, then I will review it. From what I laready saw I think we should improve the comment at end, say we ask for the dir names, and it would be great to also rename inside of files but I don't think it's easy (even feasible?) with ant

        Thanks

        Show
        Jacques Le Roux added a comment - I see, then I will review it. From what I laready saw I think we should improve the comment at end, say we ask for the dir names, and it would be great to also rename inside of files but I don't think it's easy (even feasible?) with ant Thanks
        Hide
        BJ Freeman added a comment -

        if you want to go that far then a java class would be used, if I remember right.
        will look into expanding it.
        since is say create should ask of things like graphics to replace in the directories.

        Show
        BJ Freeman added a comment - if you want to go that far then a java class would be used, if I remember right. will look into expanding it. since is say create should ask of things like graphics to replace in the directories.
        Hide
        Jacques Le Roux added a comment -

        I'd not worry too much. We could simply improve the documentation (ie messages on screen) to inform people what to do by hand and such. What do you think?

        Show
        Jacques Le Roux added a comment - I'd not worry too much. We could simply improve the documentation (ie messages on screen) to inform people what to do by hand and such. What do you think?
        Hide
        BJ Freeman added a comment -

        good enough for a start
        can always improve latter if the inclination hits me.

        Show
        BJ Freeman added a comment - good enough for a start can always improve latter if the inclination hits me.
        Hide
        BJ Freeman added a comment -

        A thought occurs to me that with Multi tenant, there will be a need to let the tenant create there own theme.
        so this may be a mute point since that code would be in the content component.

        Show
        BJ Freeman added a comment - A thought occurs to me that with Multi tenant, there will be a need to let the tenant create there own theme. so this may be a mute point since that code would be in the content component.
        Hide
        Jacques Le Roux added a comment -

        Interesting idea about tenant theme... I agree that we should think about a mechanism for them. But I don't think that OOTB we should have to much themes, maintaining them all begins to be burden...

        Show
        Jacques Le Roux added a comment - Interesting idea about tenant theme... I agree that we should think about a mechanism for them. But I don't think that OOTB we should have to much themes, maintaining them all begins to be burden...
        Hide
        BJ Freeman added a comment -

        I agree.
        if you think the script if worth putting in the build fine, if not fine.
        My last comment was that eventually there will be stuff in configure and content to create themes so this would not be needed.
        since they would be loaded from the configure no reboot would be necessary.
        content would write the files and configure of the Defualt would load the data into the tenants db.

        Show
        BJ Freeman added a comment - I agree. if you think the script if worth putting in the build fine, if not fine. My last comment was that eventually there will be stuff in configure and content to create themes so this would not be needed. since they would be loaded from the configure no reboot would be necessary. content would write the files and configure of the Defualt would load the data into the tenants db.
        Hide
        Jacques Le Roux added a comment -

        Yes, I will commit, not exactly as is as, as I said, I'd like to add some "documentation" in ant messages to help users to complete the task manually. If you take care of it, fine. Else I will do when I will get a chance.

        Show
        Jacques Le Roux added a comment - Yes, I will commit, not exactly as is as, as I said, I'd like to add some "documentation" in ant messages to help users to complete the task manually. If you take care of it, fine. Else I will do when I will get a chance.
        Hide
        BJ Freeman added a comment -

        I will review it and see what more I can document.
        if you want to point me in a direction I will do my best to put it in.

        Show
        BJ Freeman added a comment - I will review it and see what more I can document. if you want to point me in a direction I will do my best to put it in.
        Hide
        Jacques Le Roux added a comment -
        • You ask for theme name when it's actually the name of the dir containing the theme which is asked/used.
        • We could also explain in the last message that the user will need to change visualThemeId and resourceValue in the $ {source-theme}

          ThemeData.xml file before they try their new theme

        It's all what I remember, there are maybe some other stuff that could added later...

        Thanks

        Show
        Jacques Le Roux added a comment - You ask for theme name when it's actually the name of the dir containing the theme which is asked/used. We could also explain in the last message that the user will need to change visualThemeId and resourceValue in the $ {source-theme} ThemeData.xml file before they try their new theme It's all what I remember, there are maybe some other stuff that could added later... Thanks
        Hide
        Jacques Le Roux added a comment -
        • Ha also inside the ofbiz-component.xml file!
        Show
        Jacques Le Roux added a comment - Ha also inside the ofbiz-component.xml file!
        Hide
        BJ Freeman added a comment -

        Just walked through doing this and it is more than a script can handle even in doc.
        so going to do a wiki on how to do themes then put a link in the script.

        Show
        BJ Freeman added a comment - Just walked through doing this and it is more than a script can handle even in doc. so going to do a wiki on how to do themes then put a link in the script.
        Hide
        Jacques Le Roux added a comment -

        This sounds like a good idea indeed, looking forward for your progress before committing

        Thanks!

        Show
        Jacques Le Roux added a comment - This sounds like a good idea indeed, looking forward for your progress before committing Thanks!
        Hide
        BJ Freeman added a comment -

        I added a link to the wiki

        Show
        BJ Freeman added a comment - I added a link to the wiki
        Hide
        BJ Freeman added a comment -
        Show
        BJ Freeman added a comment - I will expand the wiki site https://cwiki.apache.org/confluence/display/OFBIZ/Visual+Themes+-+How+to
        Hide
        BJ Freeman added a comment -

        oops. 45Kb is a little to much.

        Show
        BJ Freeman added a comment - oops. 45Kb is a little to much.
        Hide
        BJ Freeman added a comment -

        I will be dong another iteration of this by the end of the year
        it will build more of the files
        I am also going to create a template theme to copy from.

        Show
        BJ Freeman added a comment - I will be dong another iteration of this by the end of the year it will build more of the files I am also going to create a template theme to copy from.
        Hide
        Jacques Le Roux added a comment -

        Ping...

        Show
        Jacques Le Roux added a comment - Ping...
        Hide
        BJ Freeman added a comment -

        yup.
        to organize my energy I have decided to use the doc books to write the help files, then do the scripts.
        as a change, since I am focused on the multitenant, Self service, I want to make this part of the setup so that end users can created/select themes to be installed.

        also need to to some work on the selection of themes so if a theme is marked as copyrighted and private, it does not show up in current theme selections.

        Show
        BJ Freeman added a comment - yup. to organize my energy I have decided to use the doc books to write the help files, then do the scripts. as a change, since I am focused on the multitenant, Self service, I want to make this part of the setup so that end users can created/select themes to be installed. also need to to some work on the selection of themes so if a theme is marked as copyrighted and private, it does not show up in current theme selections.
        Hide
        Jacques Le Roux added a comment -

        HI BJ,

        Should we keep this issue open and try to commit your ant task, or close and rely on the wiki page ?

        Show
        Jacques Le Roux added a comment - HI BJ, Should we keep this issue open and try to commit your ant task, or close and rely on the wiki page ?
        Hide
        BJ Freeman added a comment -

        Rely on wiki, since I DON'T follow ofbiz any more.

        Show
        BJ Freeman added a comment - Rely on wiki, since I DON'T follow ofbiz any more.
        Hide
        Jacques Le Roux added a comment -

        Thanks BJ

        Show
        Jacques Le Roux added a comment - Thanks BJ

          People

          • Assignee:
            Jacques Le Roux
            Reporter:
            BJ Freeman
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development