this is not a patch for the actual script

once a create an new theme I compare between the new one and one I did not use as a source to see what needs to be changed.

hear is the patch

I see a create-theme in the build
can not find the commit for it so can not reference when it was put in.
so closing this issue.

Hi BJ,

I think the create-theme target you saw is your own because there are none in the build file. BTW I wonder what's the point since it's easy to simply copy a theme dir and then poke in. Did you do something more in your patch (I did not take the time to review)?

Thanks

your are probably correct.
as far as the script, if you copy you are ask to rename the top folder but the sub-folders and files are not renamed.
like the data file and the folder under webapp.
it is not a big thing but it is easier than remembering what has to done.

I see, then I will review it. From what I laready saw I think we should improve the comment at end, say we ask for the dir names, and it would be great to also rename inside of files but I don't think it's easy (even feasible?) with ant

Thanks

if you want to go that far then a java class would be used, if I remember right.
will look into expanding it.
since is say create should ask of things like graphics to replace in the directories.

I'd not worry too much. We could simply improve the documentation (ie messages on screen) to inform people what to do by hand and such. What do you think?

good enough for a start
can always improve latter if the inclination hits me.

A thought occurs to me that with Multi tenant, there will be a need to let the tenant create there own theme.
so this may be a mute point since that code would be in the content component.

Interesting idea about tenant theme... I agree that we should think about a mechanism for them. But I don't think that OOTB we should have to much themes, maintaining them all begins to be burden...

I agree.
if you think the script if worth putting in the build fine, if not fine.
My last comment was that eventually there will be stuff in configure and content to create themes so this would not be needed.
since they would be loaded from the configure no reboot would be necessary.
content would write the files and configure of the Defualt would load the data into the tenants db.

Yes, I will commit, not exactly as is as, as I said, I'd like to add some "documentation" in ant messages to help users to complete the task manually. If you take care of it, fine. Else I will do when I will get a chance.

I will review it and see what more I can document.
if you want to point me in a direction I will do my best to put it in.

• You ask for theme name when it's actually the name of the dir containing the theme which is asked/used.
• We could also explain in the last message that the user will need to change visualThemeId and resourceValue in the $ {source-theme}

  ThemeData.xml file before they try their new theme

It's all what I remember, there are maybe some other stuff that could added later...

Thanks

• Ha also inside the ofbiz-component.xml file!

Just walked through doing this and it is more than a script can handle even in doc.
so going to do a wiki on how to do themes then put a link in the script.

This sounds like a good idea indeed, looking forward for your progress before committing

Thanks!

I added a link to the wiki

I will expand the wiki site
https://cwiki.apache.org/confluence/display/OFBIZ/Visual+Themes+-+How+to

oops. 45Kb is a little to much.

I will be dong another iteration of this by the end of the year
it will build more of the files
I am also going to create a template theme to copy from.

Ping...

yup.
to organize my energy I have decided to use the doc books to write the help files, then do the scripts.
as a change, since I am focused on the multitenant, Self service, I want to make this part of the setup so that end users can created/select themes to be installed.

also need to to some work on the selection of themes so if a theme is marked as copyrighted and private, it does not show up in current theme selections.

HI BJ,

Should we keep this issue open and try to commit your ant task, or close and rely on the wiki page ?

Rely on wiki, since I DON'T follow ofbiz any more.

Thanks BJ