Details

    • Type: Sub-task Sub-task
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: None
    • Fix Version/s: SVN trunk
    • Component/s: ALL APPLICATIONS
    • Labels:
      None

      Description

      Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.

      For that please find a patch attached. In this patch I followed a simple S/R tactic:

      • I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
      • I replaced all occurences of <lookup by <lookup presentation="layer" position="center"

      It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.

      I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.

      The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.

      Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

      There are issues to be fixed prior to a commit, see OFBIZ-3446.

      1. Min-max issue from FTL.jpg
        31 kB
        Jacques Le Roux
      2. LayoutFixMinMaxTomah.patch
        0.4 kB
        Sascha Rodekamp
      3. LayoutFixes.patch
        4 kB
        Sascha Rodekamp
      4. LayoutFixes.patch
        3 kB
        Sascha Rodekamp
      5. OFBIZ-3442 replace popup lookups by layered lookups.patch
        9 kB
        Jacques Le Roux
      6. ASF.LICENSE.NOT.GRANTED--OFBIZ-3442 replace popup lookups by layered lookups.patch
        9 kB
        Jacques Le Roux

        Issue Links

          Activity

          Jacques Le Roux made changes -
          Status In Progress [ 3 ] Closed [ 6 ]
          Fix Version/s SVN trunk [ 12311928 ]
          Resolution Fixed [ 1 ]
          Jacques Le Roux made changes -
          Attachment Min-max issue from FTL.jpg [ 12442654 ]
          Sascha Rodekamp made changes -
          Attachment LayoutFixMinMaxTomah.patch [ 12442652 ]
          Sascha Rodekamp made changes -
          Attachment LayoutFixes.patch [ 12442323 ]
          Sascha Rodekamp made changes -
          Attachment LayoutFixes.patch [ 12442287 ]
          Jacques Le Roux made changes -
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12442193 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12442193 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442_OnlyOneLookupFix.patch [ 12442178 ]
          Jacques Le Roux made changes -
          Attachment lookup.htm [ 12441946 ]
          Sascha Rodekamp made changes -
          Attachment OFBIZ-3442_OnlyOneLookupFix.patch [ 12442178 ]
          Jacques Le Roux made changes -
          Attachment lookup.htm [ 12441946 ]
          Jacques Le Roux made changes -
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12439416 ]
          Jacques Le Roux made changes -
          Link This issue blocks OFBIZ-3541 [ OFBIZ-3541 ]
          Gavin made changes -
          Workflow jira [ 12498111 ] OFbiz Workflow [ 12507281 ]
          Jacques Le Roux made changes -
          Link This issue blocks OFBIZ-3541 [ OFBIZ-3541 ]
          Jacques Le Roux made changes -
          Link This issue relates to OFBIZ-3441 [ OFBIZ-3441 ]
          Jacques Le Roux made changes -
          Link This issue relates to OFBIZ-3441 [ OFBIZ-3441 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12439416 ]
          Jacques Le Roux made changes -
          Link This issue is blocked by OFBIZ-3446 [ OFBIZ-3446 ]
          Jacques Le Roux made changes -
          Description Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.

          For that please find a patch attached. In this patch I followed a simple S/R tactic:
          * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
          * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"

          It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.

          I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.

          The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.

          Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.
          Following Sascha Rodekamp's work on layer lookups OFBIZ-3374 and improvements OFBIZ-3430, I propose now to replace old the popup lookups by layered (Ajaxified) lookups.

          For that please find a patch attached. In this patch I followed a simple S/R tactic:
          * I replaced all occurences of LookupDecorator by LookupLayerPopupDecorator in screens
          * I replaced all occurences of <lookup by <lookup presentation="layer" position="center"

          It's as simple as this. For the moment I decided to use as default position="center" because it's was the easiest (sure that any lookups will be out of the screen). I think we will refine this by removing position="center" and use the default (position="normal") which does not move the layer from the point it's called and will be more aesthetic.

          I did not test anything in OFBIz OOTB for the moment, but I already use layered lookups in a custom application without any issues so far.

          The only drawback I found for the moment is when a lookup is called from a lookup. If you are aware of such cases please chime in.

          Of course everybody is encouraged to test this improvement as much as possible. I really think it's a very cool feature for users, and they will appreciate. There are still some ideas like that (see the link Sasca referred to in OFBIZ-3374), and we will try to implement them.

          There are issues to be fixed prior to a commit, see OFBIZ-3446.
          Component/s ALL APPLICATIONS [ 12313113 ]
          Component/s ALL COMPONENTS [ 12312085 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12437693 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12435437 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12435124 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12435092 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12434982 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12434948 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12437693 ]
          Sascha Rodekamp made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12435437 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12435124 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12435092 ]
          Jacques Le Roux made changes -
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12434982 ]
          Jacques Le Roux made changes -
          Status Open [ 1 ] In Progress [ 3 ]
          Jacques Le Roux made changes -
          Assignee Jacques Le Roux [ jacques.le.roux ]
          Jacques Le Roux made changes -
          Parent OFBIZ-3445 [ 12455447 ]
          Issue Type Improvement [ 4 ] Sub-task [ 7 ]
          Jacques Le Roux made changes -
          Field Original Value New Value
          Attachment OFBIZ-3442 replace popup lookups by layered lookups.patch [ 12434948 ]
          Jacques Le Roux created issue -

            People

            • Assignee:
              Jacques Le Roux
              Reporter:
              Jacques Le Roux
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development