OFBiz
  1. OFBiz
  2. OFBIZ-3414

Work Effort Application Is Broken In Trunk

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: workeffort
    • Labels:
      None

      Description

      The work effort application has become unusable. There has been a major regression since R 9.04. See comments for details.

        Activity

        Hide
        Adrian Crum added a comment -

        Issue #1: The Find Work Efforts screen doesn't work.

        Click on the Find button in the 9.04 demo (https://demo904.ofbiz.org/workeffort/control/FindWorkEffort). All work efforts are displayed.

        Click on the Find button in the trunk demo (https://demo.ofbiz.org/workeffort/control/FindWorkEffort). Only some work efforts are displayed.

        Show
        Adrian Crum added a comment - Issue #1: The Find Work Efforts screen doesn't work. Click on the Find button in the 9.04 demo ( https://demo904.ofbiz.org/workeffort/control/FindWorkEffort ). All work efforts are displayed. Click on the Find button in the trunk demo ( https://demo.ofbiz.org/workeffort/control/FindWorkEffort ). Only some work efforts are displayed.
        Hide
        Adrian Crum added a comment -

        Issue #2: Create/Edit Work Effort in Calendar screen doesn't work properly.

        Go to the Calendar screen in the 9.04 demo (https://demo904.ofbiz.org/workeffort/control/day). Click on one of the Add New links. An Edit Work Effort screen appears that allows you to enter any type of work effort.

        Go to the Calendar screen in the trunk demo (https://demo.ofbiz.org/workeffort/control/calendar). Click on one of the Add New links. A screen appears that only lets you enter very limited information, and only for an event. There is no way to enter another type of work effort.

        Show
        Adrian Crum added a comment - Issue #2: Create/Edit Work Effort in Calendar screen doesn't work properly. Go to the Calendar screen in the 9.04 demo ( https://demo904.ofbiz.org/workeffort/control/day ). Click on one of the Add New links. An Edit Work Effort screen appears that allows you to enter any type of work effort. Go to the Calendar screen in the trunk demo ( https://demo.ofbiz.org/workeffort/control/calendar ). Click on one of the Add New links. A screen appears that only lets you enter very limited information, and only for an event. There is no way to enter another type of work effort.
        Hide
        Adrian Crum added a comment -

        Issue #3: The temporal expression demo doesn't work in either version.

        Log into Work Efforts application as admin. Go to Calendar and select Month View. A staff meeting should appear on the first Monday of the month.

        Show
        Adrian Crum added a comment - Issue #3: The temporal expression demo doesn't work in either version. Log into Work Efforts application as admin. Go to Calendar and select Month View. A staff meeting should appear on the first Monday of the month.
        Hide
        Adrian Crum added a comment -

        Issue # 4: The iCalendar demo doesn't work (probably related to #3).

        Using an iCalendar client, view this R 9.04 calendar:

        https://demo904.ofbiz.org/iCalendar/CALENDAR_PUB_DEMO/test.ics

        The staff meeting appears.

        Using an iCalendar client, view this trunk calendar:

        https://demo.ofbiz.org/iCalendar/CALENDAR_PUB_DEMO/test.ics

        The calendar requires authentication. After logging in, no calendar appears.

        Show
        Adrian Crum added a comment - Issue # 4: The iCalendar demo doesn't work (probably related to #3). Using an iCalendar client, view this R 9.04 calendar: https://demo904.ofbiz.org/iCalendar/CALENDAR_PUB_DEMO/test.ics The staff meeting appears. Using an iCalendar client, view this trunk calendar: https://demo.ofbiz.org/iCalendar/CALENDAR_PUB_DEMO/test.ics The calendar requires authentication. After logging in, no calendar appears.
        Hide
        Jacques Le Roux added a comment -

        Hi Adrian,

        In order to better follow the status of each issue, I'd recomment to the commiters who will take care of them to create subtasks

        Thanks

        Show
        Jacques Le Roux added a comment - Hi Adrian, In order to better follow the status of each issue, I'd recomment to the commiters who will take care of them to create subtasks Thanks
        Hide
        Adrian Crum added a comment -

        Issue # 5: When editing a work effort, after clicking Save, you are taken to a calendar screen. This issue appears when certain steps are followed in order:

        Go to the Calendar screen and click on any work effort that appears there. The limited edit work effort screen appears. Leave the work effort as-is and click on the application's Work Effort tab (the one that takes you to the Find Work Efforts screen). Click Find and select any work effort. Click Save on the Edit Work Effort screen. You are taken to a calendar screen after the work effort is saved. What should happen is you stay on the Edit Work Effort screen.

        Show
        Adrian Crum added a comment - Issue # 5: When editing a work effort, after clicking Save, you are taken to a calendar screen. This issue appears when certain steps are followed in order: Go to the Calendar screen and click on any work effort that appears there. The limited edit work effort screen appears. Leave the work effort as-is and click on the application's Work Effort tab (the one that takes you to the Find Work Efforts screen). Click Find and select any work effort. Click Save on the Edit Work Effort screen. You are taken to a calendar screen after the work effort is saved. What should happen is you stay on the Edit Work Effort screen.
        Hide
        Adrian Crum added a comment -

        Jacques,

        I put all these issues in one Jira issue because they were all caused by one person, and my hope is that person will step up to the plate and fix the things they broke.

        Show
        Adrian Crum added a comment - Jacques, I put all these issues in one Jira issue because they were all caused by one person, and my hope is that person will step up to the plate and fix the things they broke.
        Hide
        Jacques Le Roux added a comment -

        Ho, I see! Anyway, it might be helpful for this person to use subtasks

        Show
        Jacques Le Roux added a comment - Ho, I see! Anyway, it might be helpful for this person to use subtasks
        Hide
        Hans Bakker added a comment -

        Thank you Adrian for finding these problems. It shows that the workeffort on itself is not much used however very much in projectmanagement, assetmaintanence, manufacturing, myportal and sfa where it is functions pretty well.
        We will try fix it as quick as possible.

        Regards,
        Hans

        Show
        Hans Bakker added a comment - Thank you Adrian for finding these problems. It shows that the workeffort on itself is not much used however very much in projectmanagement, assetmaintanence, manufacturing, myportal and sfa where it is functions pretty well. We will try fix it as quick as possible. Regards, Hans
        Hide
        Adrian Crum added a comment -

        Hans,

        Thank you very much for taking care of this. My employer uses the Work Effort application out of the box, so it does get used.

        Show
        Adrian Crum added a comment - Hans, Thank you very much for taking care of this. My employer uses the Work Effort application out of the box, so it does get used.
        Hide
        Hans Bakker added a comment -

        Adrian,

        i looked at you first problem, it is showing only the first few work efforts and the pagination is missing
        add
        <set field="viewSize" value="100" type="Integer"/>
        to the actions tag in the ListWorkEfforts form.

        then it will show all workefforts. That it not shows the pagination is probably caused by the conversion from a list iterator to a list in the ListWorkEfforts form?

        Regards,
        Hans

        Show
        Hans Bakker added a comment - Adrian, i looked at you first problem, it is showing only the first few work efforts and the pagination is missing add <set field="viewSize" value="100" type="Integer"/> to the actions tag in the ListWorkEfforts form. then it will show all workefforts. That it not shows the pagination is probably caused by the conversion from a list iterator to a list in the ListWorkEfforts form? Regards, Hans
        Hide
        Adrian Crum added a comment -

        The pagination works fine for me - but not all of the work efforts appear. I don't think the problem is in the form, I think it is in the method of finding all work efforts - some of them are being excluded.

        Show
        Adrian Crum added a comment - The pagination works fine for me - but not all of the work efforts appear. I don't think the problem is in the form, I think it is in the method of finding all work efforts - some of them are being excluded.
        Hide
        Adrian Crum added a comment -

        Okay, that's odd. I had 35 work efforts appear on the Find screen. I created a new work effort event, and saved it. Now only a handful of work efforts appear on the Find screen. Something very strange is going on there.

        Show
        Adrian Crum added a comment - Okay, that's odd. I had 35 work efforts appear on the Find screen. I created a new work effort event, and saved it. Now only a handful of work efforts appear on the Find screen. Something very strange is going on there.
        Hide
        Adrian Crum added a comment -

        Hans,

        I don't have a lot of time to help you investigate, but I can give you some clues that might help. I had to fix the Find screen in revision 794327. The Find screen was listing a lot of duplicate work efforts - something it didn't do before. So, something broke between R 9.04 and trunk rev 794327.

        Show
        Adrian Crum added a comment - Hans, I don't have a lot of time to help you investigate, but I can give you some clues that might help. I had to fix the Find screen in revision 794327. The Find screen was listing a lot of duplicate work efforts - something it didn't do before. So, something broke between R 9.04 and trunk rev 794327.
        Hide
        Hans Bakker added a comment -

        Adrian,

        this form is just using performFind which provides the list of the first
        20 work efforts, then a duplicate workeffort service is included which
        deletes the duplicates and convert it into a list

        I did not touch this part of the system ever....

        Regards,
        Hans

        Show
        Hans Bakker added a comment - Adrian, this form is just using performFind which provides the list of the first 20 work efforts, then a duplicate workeffort service is included which deletes the duplicates and convert it into a list I did not touch this part of the system ever.... Regards, Hans
        Hide
        Hans Bakker added a comment -

        if you talking about a lot of duplicate workefforts? I created workeffort demodata for the projectmanager which has more than one partyrole per workeffort. Because this find workeffort uses a view which includes roles i can imagine you will get a lot of duplicates....

        I tried to fix your problem, however with the current design i do not see how this can ever work.....

        Regards,
        Hans

        Show
        Hans Bakker added a comment - if you talking about a lot of duplicate workefforts? I created workeffort demodata for the projectmanager which has more than one partyrole per workeffort. Because this find workeffort uses a view which includes roles i can imagine you will get a lot of duplicates.... I tried to fix your problem, however with the current design i do not see how this can ever work..... Regards, Hans
        Hide
        Hans Bakker added a comment -

        comment number 3 is working fine here......please provide more info.....

        Regards,
        Hans

        Show
        Hans Bakker added a comment - comment number 3 is working fine here......please provide more info..... Regards, Hans
        Hide
        Adrian Crum added a comment -

        The solution seems pretty simple to me: have project manager use the view, and put the work effort application back the way it was.

        Show
        Adrian Crum added a comment - The solution seems pretty simple to me: have project manager use the view, and put the work effort application back the way it was.
        Hide
        Adrian Crum added a comment -

        I agree on #3. When I added that comment it was not working in either online demo.

        I'm beginning to notice a pattern, which might be another clue. If I run ant clean-all, then ant run-install, the Work Effort application starts off working as it should. If I go to the Edit Work Effort screen and click save, then the entire Work Effort application starts to go berzerk.

        Show
        Adrian Crum added a comment - I agree on #3. When I added that comment it was not working in either online demo. I'm beginning to notice a pattern, which might be another clue. If I run ant clean-all, then ant run-install, the Work Effort application starts off working as it should. If I go to the Edit Work Effort screen and click save, then the entire Work Effort application starts to go berzerk.
        Hide
        Hans Bakker added a comment -

        Your #2 please check revision 901102 there you can create a any workeffortype within the calendar portlet.

        Regards,
        hans

        Show
        Hans Bakker added a comment - Your #2 please check revision 901102 there you can create a any workeffortype within the calendar portlet. Regards, hans
        Hide
        Adrian Crum added a comment -

        Hans,

        I don't see where #2 has changed. It still doesn't take me to the Edit Work Effort screen. How do I enter the running time? Or the setup time? Or a temporal expression? Or percent complete?

        The approach you are trying to take is backwards. Instead of making Project Manager (a special purpose component) reuse work effort application artifacts, you are trying to make the work effort application BE a project manager.

        Show
        Adrian Crum added a comment - Hans, I don't see where #2 has changed. It still doesn't take me to the Edit Work Effort screen. How do I enter the running time? Or the setup time? Or a temporal expression? Or percent complete? The approach you are trying to take is backwards. Instead of making Project Manager (a special purpose component) reuse work effort application artifacts, you are trying to make the work effort application BE a project manager.
        Hide
        Adrian Crum added a comment -

        Issues 3 & 4 fixed in rev 905475.

        Show
        Adrian Crum added a comment - Issues 3 & 4 fixed in rev 905475.
        Hide
        Jacopo Cappellato added a comment -

        can we close this issue now?

        Show
        Jacopo Cappellato added a comment - can we close this issue now?

          People

          • Assignee:
            Hans Bakker
            Reporter:
            Adrian Crum
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development