OFBiz
  1. OFBiz
  2. OFBIZ-3319

Adding selenium-server library, and documentation update

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: Trunk
    • Component/s: ALL APPLICATIONS
    • Labels:
      None

      Description

      Adding the selenium-server library will help OFBiz to be ready to use / test for everyone. As the driver is already present, it would be easier to have the server included.

      In this patch :

      • help is updated
      • tests for the presence of the selenium server are removed
      • licenses are updated
      • classpath is updated
      • in seleniumXml.properties, the configuration for Iceweasel is added (as a comment)
      • build.xml files are also updated
      • marketing test has his locale forced to english at the start
      1. OFBIZ-3319.diff
        17 kB
        Erwan de FERRIERES
      2. OFBIZ-3319.reduced.diff
        2 kB
        Erwan de FERRIERES

        Issue Links

          Activity

          Hide
          Scott Gray added a comment -

          Hi Erwan, I don't remember the exact details but the server was excluded from distribution on purpose due to some licensing issues with code used by the server. If you search for the jira issue that introduced selenium there should be a full discussion for you to take a look at.

          Show
          Scott Gray added a comment - Hi Erwan, I don't remember the exact details but the server was excluded from distribution on purpose due to some licensing issues with code used by the server. If you search for the jira issue that introduced selenium there should be a full discussion for you to take a look at.
          Hide
          Erwan de FERRIERES added a comment -

          Hi Scott,

          from what I saw on selenium website, there should be no more problems are the devs are under the Apache2 licence, as it is said there : http://seleniumhq.org/about/license.html

          Cheers,

          Show
          Erwan de FERRIERES added a comment - Hi Scott, from what I saw on selenium website, there should be no more problems are the devs are under the Apache2 licence, as it is said there : http://seleniumhq.org/about/license.html Cheers,
          Hide
          Jacques Le Roux added a comment -
          Show
          Jacques Le Roux added a comment - Scott, Erwan, Last thread on this subject
          Hide
          Scott Gray added a comment -

          Just because a project releases itself under a given license does not mean that it actually complies with that license. As I suggested please review the original jira issue to gain a better understanding of the issues faced.

          Show
          Scott Gray added a comment - Just because a project releases itself under a given license does not mean that it actually complies with that license. As I suggested please review the original jira issue to gain a better understanding of the issues faced.
          Hide
          Jacques Le Roux added a comment -

          Hi Erwan,

          Is the patch still appliable as is ?

          Show
          Jacques Le Roux added a comment - Hi Erwan, Is the patch still appliable as is ?
          Hide
          Erwan de FERRIERES added a comment -

          Hi Jacques,

          No, it's not...

          I need to make a new patch, with less modifications in it. The first goal of this issue was to help automating Selenium testing, and have a ready-to-use solution when downloading OFBiz. As there are some issues with the license (and I saw that I was part of the discussion last year, I've a got an elephant memory....), the patch is losing most of his reason to be.
          The next steps :

          • provide a patch with only the changes not related to the selenium-server.jar file
          • mail to the cssQuery's author (Brett did that last year, but it seems he got no answer)

          Cheers,

          Show
          Erwan de FERRIERES added a comment - Hi Jacques, No, it's not... I need to make a new patch, with less modifications in it. The first goal of this issue was to help automating Selenium testing, and have a ready-to-use solution when downloading OFBiz. As there are some issues with the license (and I saw that I was part of the discussion last year, I've a got an elephant memory....), the patch is losing most of his reason to be. The next steps : provide a patch with only the changes not related to the selenium-server.jar file mail to the cssQuery's author (Brett did that last year, but it seems he got no answer) Cheers,
          Hide
          Scott Gray added a comment -

          I'm surprised the selenium team aren't more concerned about licensing problems like this but such is life.

          One thing we could consider doing is ripping cssQuery out of the source code and replacing it with something else, querying the dom using css selectors is fairly common and if I'm not wrong you can do it with prototype fairly easily. Ideally we'd find a solution that can be given back to selenium so that we don't have to maintain anything.

          Show
          Scott Gray added a comment - I'm surprised the selenium team aren't more concerned about licensing problems like this but such is life. One thing we could consider doing is ripping cssQuery out of the source code and replacing it with something else, querying the dom using css selectors is fairly common and if I'm not wrong you can do it with prototype fairly easily. Ideally we'd find a solution that can be given back to selenium so that we don't have to maintain anything.
          Hide
          Jacques Le Roux added a comment -

          Yes Scott,

          IIRW that was the next step Brett suggested (for both issues?). Looks like Selenium team (and some others...) have not the luck to have a legal team and all an infrastructure behind

          Show
          Jacques Le Roux added a comment - Yes Scott, IIRW that was the next step Brett suggested (for both issues?). Looks like Selenium team (and some others...) have not the luck to have a legal team and all an infrastructure behind
          Hide
          Erwan de FERRIERES added a comment -

          From what I know, LGPL is not a viral licence and files can be used as long as they are not modified or as long as you provide their full code source. And this is why in selenium-server.jar they provide a compiled version, and in a sub-directory the full source-code of the cssQuery library

          http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html

          Show
          Erwan de FERRIERES added a comment - From what I know, LGPL is not a viral licence and files can be used as long as they are not modified or as long as you provide their full code source. And this is why in selenium-server.jar they provide a compiled version, and in a sub-directory the full source-code of the cssQuery library http://www.gnu.org/licenses/old-licenses/lgpl-2.1.html
          Hide
          Erwan de FERRIERES added a comment -

          All the modifications not related to selenium-server.jar

          Show
          Erwan de FERRIERES added a comment - All the modifications not related to selenium-server.jar
          Hide
          Jacques Le Roux added a comment -
          Show
          Jacques Le Roux added a comment - Seems that legal team does not agree
          Hide
          Erwan de FERRIERES added a comment -

          Here is a draft of the mail I'd like to send to Dean Edwards, the creator of the cssQuery library. If it's ok with you, I will then send it.

          Hi Dean,

          first of all, thanks for your work on cssQuery.
          I'm coming to you about your cssQuery library. As you know, it is already used by the Selenium application which allows functional testing on websites. I am myself using it, and I'm working on an Apache project which is called OFBiz. As you may know, only work licensed under the Apache2 license can be included in those projects, or any code with a compatible licence. There is then a problem with Selenium (for the Apache Fundation) as it is using your library, you can see it there : http://www.apache.org/legal/resolved.html#category-x
          It's then why I come to you, to know if it would be possible to double-licensing your work, or change the license of the cssQuery library to one of the licenses compatible with the Apache Fundation guidelines : http://www.apache.org/legal/resolved.html#category-a

          Thanks a lot for considerating this request, and I'm ready to discuss more about this with you if needed.

          Erwan

          Show
          Erwan de FERRIERES added a comment - Here is a draft of the mail I'd like to send to Dean Edwards, the creator of the cssQuery library. If it's ok with you, I will then send it. Hi Dean, first of all, thanks for your work on cssQuery. I'm coming to you about your cssQuery library. As you know, it is already used by the Selenium application which allows functional testing on websites. I am myself using it, and I'm working on an Apache project which is called OFBiz. As you may know, only work licensed under the Apache2 license can be included in those projects, or any code with a compatible licence. There is then a problem with Selenium (for the Apache Fundation) as it is using your library, you can see it there : http://www.apache.org/legal/resolved.html#category-x It's then why I come to you, to know if it would be possible to double-licensing your work, or change the license of the cssQuery library to one of the licenses compatible with the Apache Fundation guidelines : http://www.apache.org/legal/resolved.html#category-a Thanks a lot for considerating this request, and I'm ready to discuss more about this with you if needed. Erwan
          Hide
          Jacques Le Roux added a comment -

          Hi Erwan,

          This looks good to me, but what about the point 3 here
          I'm not sure it's still an issue but we should check anyway.

          Show
          Jacques Le Roux added a comment - Hi Erwan, This looks good to me, but what about the point 3 here I'm not sure it's still an issue but we should check anyway.
          Hide
          Erwan de FERRIERES added a comment -

          at rev. 899120

          Show
          Erwan de FERRIERES added a comment - at rev. 899120

            People

            • Assignee:
              Erwan de FERRIERES
              Reporter:
              Erwan de FERRIERES
            • Votes:
              0 Vote for this issue
              Watchers:
              1 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development