OFBiz
  1. OFBiz
  2. OFBIZ-3293

Receiving Return for Manual Return Adjustment gives Service invocation error.

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: order
    • Labels:
      None

      Description

      When you receive return for Manual Return Adjustment gives following error: org.ofbiz.webapp.event.EventHandlerException: Service invocation error (null)

      Steps to regenerate error:
      1. Create Return from Ordermgr > Return > New
      2. Fill following information in the create Return form:

      • From Party Id : Customer's party Id
      • To Party Id : Company's PartyId

      3. Click submit button.
      4. Go to Return Item tab & select the order id from the dropdown and click on Load Order Item for Return.
      5. Now in the Manual Return Adjustment section: Enter the details/reason for return, the amount & Select the return type "Store Credit"
      6. Check the check box against Manual Return Adjustment fields and click "Return Selected Item" button.
      7. Accept Return from Return Header screen or Return Item screen.
      8. From The Return Header screen receive return.

      Receive Return works fine if there is a product returned with the Manual Return Adjustment

      1. OFBIZ-3293.patch
        1 kB
        Ashish Vijaywargiya

        Issue Links

          Activity

          Hide
          Ashish Vijaywargiya added a comment -

          Patch from Akash.

          Show
          Ashish Vijaywargiya added a comment - Patch from Akash.
          Hide
          Ashish Vijaywargiya added a comment -

          Thanks Akash for the contribution - Done at r887083.

          I will close this issue as soon as we resolve dependent issue.


          Ashish

          Show
          Ashish Vijaywargiya added a comment - Thanks Akash for the contribution - Done at r887083. I will close this issue as soon as we resolve dependent issue. – Ashish
          Hide
          Ean Schuessler added a comment -

          There are some other problems with this code. When you generate a return it tries to use the order items to locate the order_header for selection of billing account vs financial account. This fails since there are no order items. I'm working up a patch to use the ReturnAdjustment records to locate the order header.

          As a side note, it looks like this code would select the order header and, therefore, the product store preferences with a single operation at the beginning of the return. In practice, it seems like items in a single return could potentially be from multiple stores. The UI doesn't so much allow that but it looks to me like the services and data structures would not preclude it. Should the order header and product store actually be re-determined for each order item and order adjustment?

          Show
          Ean Schuessler added a comment - There are some other problems with this code. When you generate a return it tries to use the order items to locate the order_header for selection of billing account vs financial account. This fails since there are no order items. I'm working up a patch to use the ReturnAdjustment records to locate the order header. As a side note, it looks like this code would select the order header and, therefore, the product store preferences with a single operation at the beginning of the return. In practice, it seems like items in a single return could potentially be from multiple stores. The UI doesn't so much allow that but it looks to me like the services and data structures would not preclude it. Should the order header and product store actually be re-determined for each order item and order adjustment?

            People

            • Assignee:
              Ashish Vijaywargiya
              Reporter:
              Ashish Vijaywargiya
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development