OFBiz
  1. OFBiz
  2. OFBIZ-3155

Enhancing the useability of SFA by including an overview of the agreements of the account into the Account Screen

    Details

    • Type: Improvement Improvement
    • Status: Patch Available
    • Priority: Major Major
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: SVN trunk
    • Component/s: marketing
    • Labels:
      None

      Description

      This improvement includes:
      Adding an overview of associated agreements with the account to the account screen
      Adding the functionality to create agreements from the account screen, with setting the default agreement parties (Company and the account)

      The modifications are realized on:
      \applications\accounting\widgets\agreementscreen.xml - setting default agreement parties
      \applications\party\webapp\partymgr\static\partymgr.css - including of style elements for overviews in the bottom position of account screen
      \applications\party\widget\partymgr\profilescreens.xml - including a screen for partyAgreements
      \applications\party\widget\partymgr\partyforms.xml - including a form to render the overview of agreements for accounts
      \applications\marketing\widget\sfa\sfamenus.xml - including the menu to create new agreements from the acount screen
      \applications\marketing\widget\sfa\commonscreen.xml - including functionality to add the overview of agreements to the bottom of the account screen.

        Activity

        Hide
        Erwan de FERRIERES added a comment -

        only use what's in the context

        Show
        Erwan de FERRIERES added a comment - only use what's in the context
        Hide
        Pierre Smits added a comment -

        I know. I have learned since back then.

        What do you suggest, regarding setting values?

        Regards,

        Pierre

        Show
        Pierre Smits added a comment - I know. I have learned since back then. What do you suggest, regarding setting values? Regards, Pierre
        Hide
        Erwan de FERRIERES added a comment -

        Pierre,

        I reviewed your patch. You should look to the contributor's best practices, and configure your IDE (tabs to spaces).
        css modification is not needed, as already existing.
        And for the modification for agreementScreens.xml#EditAgreement (setting values) I don't agree with it, you shouldn't set company directly in the code.

        Show
        Erwan de FERRIERES added a comment - Pierre, I reviewed your patch. You should look to the contributor's best practices, and configure your IDE (tabs to spaces). css modification is not needed, as already existing. And for the modification for agreementScreens.xml#EditAgreement (setting values) I don't agree with it, you shouldn't set company directly in the code.
        Hide
        Jacques Le Roux added a comment -

        Pierre,

        As I said (No review) I just created a new patch, no review, hence no commit

        Show
        Jacques Le Roux added a comment - Pierre, As I said (No review) I just created a new patch, no review, hence no commit
        Hide
        Pierre Smits added a comment -

        Jacques,

        Applied as in committed to trunk?

        Regards,

        Pierre

        Show
        Pierre Smits added a comment - Jacques, Applied as in committed to trunk? Regards, Pierre
        Hide
        Jacques Le Roux added a comment -

        Pierre,

        Here is a new patch which applies on trunk. I applied yours with few fuzz. No review

        Show
        Jacques Le Roux added a comment - Pierre, Here is a new patch which applies on trunk. I applied yours with few fuzz. No review
        Hide
        Pierre Smits added a comment -

        Jacques,

        You are right. Last night I tested the patch against the current version of the trunk. It didn't pass. Indeed the window of opportunity closed on us, as now rework is required.

        Show
        Pierre Smits added a comment - Jacques, You are right. Last night I tested the patch against the current version of the trunk. It didn't pass. Indeed the window of opportunity closed on us, as now rework is required.
        Hide
        Pierre Smits added a comment -

        Attached file includes the modifications described

        Show
        Pierre Smits added a comment - Attached file includes the modifications described

          People

          • Assignee:
            Unassigned
            Reporter:
            Pierre Smits
          • Votes:
            0 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

            • Created:
              Updated:

              Development