Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: SVN trunk
    • Fix Version/s: None
    • Component/s: order
    • Labels:
      None

      Description

      Copy of http://jira.undersunconsulting.com/browse/OFBIZ-889 from Si Chen.

      =======================================

      I was reading Hans's README.pdf for opentravelsystems and thought one of his ideas could be added to OFBiz. Hans had added "S" for sales orders and "P" for purchase orders in orderIds, and I thought we could set it so that OrderType can have two additional fields:

      • useStorePrefix - If set to "N", then do not use productStoreId's prefix.
      • orderTypePrefix - Someone can set a prefix for this order type.

      So purchase orders could be set to useStorePrefix="N" and orderTypePrefix="P" and sales orders could be set to useStorePrefix="Y" and orderTypePrefix=null or ="S"

      All Comments Work Log Change History Sort Order:
      Comment by Fred Forester [20/May/06 06:44 AM] [ Permlink ]
      Si,

      I was looking at how to do this the night before you posted it to jira. I may need a little more detail on where these changes would go and would be glad to do the coding for it.

      Fred

      Comment by Si Chen [22/May/06 11:08 AM] [ Permlink ]
      I was thinking about adding two more fields into OrderType entity and then in OrderServices.java createOrder service, early on, to load the OrderType based on the orderTypeId passed in and check those two fields.

      This should be pretty easy to do but I want to make sure David, Jacopo, Hans, etc. like the idea as well.

      Comment by Jacopo Cappellato [01/Sep/06 09:31 AM] [ Permlink ]
      Si,

      I like this idea. However we could slightly simplify it:

      1) add a new field OrderType.orderTypePrefix (or orderTypeId)
      2) if orderTypePrefix is null then the prefix set in the product store is used (if present)

      Comment by Marco Risaliti [13/Sep/06 04:08 PM] [ Permlink ]
      is this improvement will be implemented ?
      In this case I will move it to the new jira server.

      Thanks
      Marco

      It's a copy of the old-jira issue OFBIZ-889.

        Activity

        Marco Risaliti created issue -
        Hide
        Daniel Kunkel added a comment -

        Why not just have the prefix, and let it be null, nothing, or "" if someone doesn't want to use it:

        orderSalesPrefix="S" or ="" for nothing
        orderPurchasePrefix="P" or =""

        Show
        Daniel Kunkel added a comment - Why not just have the prefix, and let it be null, nothing, or "" if someone doesn't want to use it: orderSalesPrefix="S" or ="" for nothing orderPurchasePrefix="P" or =""
        Jacopo Cappellato made changes -
        Field Original Value New Value
        Description I was reading Hans's README.pdf for opentravelsystems and thought one of his ideas could be added to OFBiz. Hans had added "S" for sales orders and "P" for purchase orders in orderIds, and I thought we could set it so that OrderType can have two additional fields:

        - useStorePrefix - If set to "N", then do not use productStoreId's prefix.
        - orderTypePrefix - Someone can set a prefix for this order type.

        So purchase orders could be set to useStorePrefix="N" and orderTypePrefix="P" and sales orders could be set to useStorePrefix="Y" and orderTypePrefix=null or ="S"
         
         

         All Comments Work Log Change History Sort Order:
        Comment by Fred Forester [20/May/06 06:44 AM] [ Permlink ]
        Si,

        I was looking at how to do this the night before you posted it to jira. I may need a little more detail on where these changes would go and would be glad to do the coding for it.

        Fred


        Comment by Si Chen [22/May/06 11:08 AM] [ Permlink ]
        I was thinking about adding two more fields into OrderType entity and then in OrderServices.java createOrder service, early on, to load the OrderType based on the orderTypeId passed in and check those two fields.

        This should be pretty easy to do but I want to make sure David, Jacopo, Hans, etc. like the idea as well.

        Comment by Jacopo Cappellato [01/Sep/06 09:31 AM] [ Permlink ]
        Si,

        I like this idea. However we could slightly simplify it:

        1) add a new field OrderType.orderTypePrefix (or orderTypeId)
        2) if orderTypePrefix is null then the prefix set in the product store is used (if present)



        Comment by Marco Risaliti [13/Sep/06 04:08 PM] [ Permlink ]
        is this improvement will be implemented ?
        In this case I will move it to the new jira server.

        Thanks
        Marco

        It's a copy of the old-jira issue OFBIZ-889.
        Copy of http://jira.undersunconsulting.com/browse/OFBIZ-889 from Si Chen.

        =======================================

        I was reading Hans's README.pdf for opentravelsystems and thought one of his ideas could be added to OFBiz. Hans had added "S" for sales orders and "P" for purchase orders in orderIds, and I thought we could set it so that OrderType can have two additional fields:

        - useStorePrefix - If set to "N", then do not use productStoreId's prefix.
        - orderTypePrefix - Someone can set a prefix for this order type.

        So purchase orders could be set to useStorePrefix="N" and orderTypePrefix="P" and sales orders could be set to useStorePrefix="Y" and orderTypePrefix=null or ="S"
         
         

         All Comments Work Log Change History Sort Order:
        Comment by Fred Forester [20/May/06 06:44 AM] [ Permlink ]
        Si,

        I was looking at how to do this the night before you posted it to jira. I may need a little more detail on where these changes would go and would be glad to do the coding for it.

        Fred


        Comment by Si Chen [22/May/06 11:08 AM] [ Permlink ]
        I was thinking about adding two more fields into OrderType entity and then in OrderServices.java createOrder service, early on, to load the OrderType based on the orderTypeId passed in and check those two fields.

        This should be pretty easy to do but I want to make sure David, Jacopo, Hans, etc. like the idea as well.

        Comment by Jacopo Cappellato [01/Sep/06 09:31 AM] [ Permlink ]
        Si,

        I like this idea. However we could slightly simplify it:

        1) add a new field OrderType.orderTypePrefix (or orderTypeId)
        2) if orderTypePrefix is null then the prefix set in the product store is used (if present)



        Comment by Marco Risaliti [13/Sep/06 04:08 PM] [ Permlink ]
        is this improvement will be implemented ?
        In this case I will move it to the new jira server.

        Thanks
        Marco

        It's a copy of the old-jira issue OFBIZ-889.
        Gavin made changes -
        Workflow jira [ 12383739 ] OFbiz Workflow [ 12504453 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Marco Risaliti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development