OFBiz
  1. OFBiz
  2. OFBIZ-2915

ViewGeneric screen not showing BigDecimal columns as editable

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: None
    • Component/s: framework
    • Labels:
      None
    • Environment:

      WinXP

      Description

      When editing a record that has BigDecimal columns defined, no edit boxes were generated in the "Edit Value" box

        Issue Links

          Activity

          Hide
          Stephen Rufle added a comment -

          Added BigDecimal sections to ViewGeneric.groovy and ViewGeneric.ftl

          Show
          Stephen Rufle added a comment - Added BigDecimal sections to ViewGeneric.groovy and ViewGeneric.ftl
          Hide
          Stephen Rufle added a comment -

          Bump, can someone review


          Stephen P Rufle
          srufle@salmonllc.com
          H1:480-626-8022
          H2:480-802-7173
          Yahoo IM: stephen_rufle
          AOL IM: stephen1rufle

          Show
          Stephen Rufle added a comment - Bump, can someone review – Stephen P Rufle srufle@salmonllc.com H1:480-626-8022 H2:480-802-7173 Yahoo IM: stephen_rufle AOL IM: stephen1rufle
          Hide
          Scott Gray added a comment -

          Looks fine to me, my only comment is that you shouldn't use toString() with BigDecimals because you'll end up with scientific notation sooner or later. Use toPlainString() instead.

          Show
          Scott Gray added a comment - Looks fine to me, my only comment is that you shouldn't use toString() with BigDecimals because you'll end up with scientific notation sooner or later. Use toPlainString() instead.
          Hide
          Stephen Rufle added a comment -

          Does that mean I should also modify
          org.ofbiz.base.util.UtilFormatOut.safeToString(Object) to deal with BigDecimal specifically?

          Calling toPlainString() for BigDecimal objects. If no one object that is what I will put in my next patch.

          Show
          Stephen Rufle added a comment - Does that mean I should also modify org.ofbiz.base.util.UtilFormatOut.safeToString(Object) to deal with BigDecimal specifically? Calling toPlainString() for BigDecimal objects. If no one object that is what I will put in my next patch.
          Hide
          Scott Gray added a comment -

          I would just do it locally so that we don't have to do an additional instanceof check for every object that passes through the method, all it does it a null check anyway.

          Show
          Scott Gray added a comment - I would just do it locally so that we don't have to do an additional instanceof check for every object that passes through the method, all it does it a null check anyway.
          Hide
          Adam Heath added a comment -

          This bug was fixed by revision 916925.

          Show
          Adam Heath added a comment - This bug was fixed by revision 916925.

            People

            • Assignee:
              Unassigned
              Reporter:
              Stephen Rufle
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development