Details
-
Improvement
-
Status: Open
-
Major
-
Resolution: Unresolved
-
Trunk, Upcoming Branch
-
None
-
None
-
Bug Crush Event - 21/2/2015
Description
ShoppingCartEvents.loadCartFromOrder has the following near the bottom of the method:
// Since we only need the cart items, so set the order id as null
cart.setOrderId(null);
I believe this is ok with standard Ofbiz applications because the only time a shopping cart is loaded from an order i when you wish to initiate the order entry process from an existing order (you will be creating a new order). In our system however, you can start an order, persist it, and then pick it up later to make more adjustments. In this scenario the actual orderId should be available (and accurate) to the order that was used for loading.
Recommendation - create a new service method "initializeCartFromOrder" or provide a parameter that indicates if the intent is to load into the cart for initialization (vs. for existing order manipulation).