Details
-
Bug
-
Status: Closed
-
Critical
-
Resolution: Fixed
-
Release Branch 4.0, Release Branch 09.04, Trunk
-
None
-
All
Description
Let's say I want to create a new category which ID is DVD+R
Creation is ok through the admin interface, but whenever i want to access this category, the get parameter productCategoryId=.... of the url is wrong as it's not url encoded, so we have :
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD+R instead of
https://localhost:8443/catalog/control/EditCategory?productCategoryId=DVD%2BR
Both <@ofbizUrl> tag and menu widgets are not encoding get parameters.
Way to correct :
framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java modify the makeLink function
framework/widget/src/org/ofbiz/widget/WidgetWorker.java : function buildhyperlinkUrl need to use defaultWebEncoder.encodeForURL instead of simpleEncoder
Beofre i do the fix, can a core developper let me know about possible side effects