OFBiz
  1. OFBiz
  2. OFBIZ-2618

double forward slashes in ecommerce emails

    Details

      Description

      in the widets
      <set field="baseEcommerceSecureUrl"
      value="$

      {baseSecureUrl}

      /ecommerce/control/"/>
      has a trailing forward slash
      then the added url has a leading forward slash
      /orderstatus?orderId=
      so you get
      /ecommerce/control//orderstatus?orderId=

      removed the trailing forward slash

      1. OFBIZ-2618.patch
        11 kB
        Arun Patidar
      2. Ofbiz_2618_ecommerceEmail.patch
        12 kB
        BJ Freeman

        Activity

        Hide
        BJ Freeman added a comment -

        patch

        Show
        BJ Freeman added a comment - patch
        Hide
        Jacques Le Roux added a comment -

        HI Bj,

        I can't commit your patch as is. At least 2 reasons

        1. Please don't add the following lines in the header
          ### Eclipse Workspace Patch 1.0
          #P ofbiz_09_04
          

          For this in the create patch wizard choose your project and not the workspace

        2. Don't cut your lines since this generate conflicts when paching (in Eclipse at least), example
          +                <property-map resource="EcommerceUiLabels" map-name="uiLabelMap"
          +                    global="true"/>
          

          should be

          +                <property-map resource="EcommerceUiLabels" map-name="uiLabelMap" global="true"/>
          

        Thanks

        Show
        Jacques Le Roux added a comment - HI Bj, I can't commit your patch as is. At least 2 reasons Please don't add the following lines in the header ### Eclipse Workspace Patch 1.0 #P ofbiz_09_04 For this in the create patch wizard choose your project and not the workspace Don't cut your lines since this generate conflicts when paching (in Eclipse at least), example + <property-map resource= "EcommerceUiLabels" map-name= "uiLabelMap" + global= " true " /> should be + <property-map resource= "EcommerceUiLabels" map-name= "uiLabelMap" global= " true " /> Thanks
        Hide
        Arun Patidar added a comment -

        Attached is modified patch to fix the same issue. Issue can be check in Order Complete Notification email with orderId link.

        Show
        Arun Patidar added a comment - Attached is modified patch to fix the same issue. Issue can be check in Order Complete Notification email with orderId link.
        Hide
        Ashish Vijaywargiya added a comment -

        Thanks BJ for creating the issue and providing first patch. Thanks Arun for the contribution.

        Anil has committed the patch at revisions - r1632764, r1632781, r1632782

        Show
        Ashish Vijaywargiya added a comment - Thanks BJ for creating the issue and providing first patch. Thanks Arun for the contribution. Anil has committed the patch at revisions - r1632764, r1632781, r1632782

          People

          • Assignee:
            Ashish Vijaywargiya
            Reporter:
            BJ Freeman
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development