OFBiz
  1. OFBiz
  2. OFBIZ-2589

New Shipment Gateway Config entities

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: product
    • Labels:
      None

      Description

      Add some new entities/fields to move the shipment gateway config from shipment.properties to the new entities.

      1. ShipmentGatewayConfig.patch
        114 kB
        Marco Risaliti
      2. ShipmentGatewayConfig2.patch
        115 kB
        Marco Risaliti

        Activity

        Hide
        Marco Risaliti added a comment -

        First patch to support new Shipment Gateway Config entities.

        Show
        Marco Risaliti added a comment - First patch to support new Shipment Gateway Config entities.
        Hide
        David E. Jones added a comment -

        I haven't tried to run this, but it's looking good Marco.

        Show
        David E. Jones added a comment - I haven't tried to run this, but it's looking good Marco.
        Hide
        Marco Risaliti added a comment -

        Updated patch.

        Show
        Marco Risaliti added a comment - Updated patch.
        Hide
        Marco Risaliti added a comment -

        Implemented into rev. 796874.

        Show
        Marco Risaliti added a comment - Implemented into rev. 796874.
        Hide
        Adam Heath added a comment -

        This is not done. While there are entities now, there is no way to know if they are actually correct. Nothing in the system actually uses any of these changes. This is extremely confusing, when you see entity definitions, and config screens, and you go to a lot of work to configure them all, then find that all your work isn't used.

        Show
        Adam Heath added a comment - This is not done. While there are entities now, there is no way to know if they are actually correct. Nothing in the system actually uses any of these changes. This is extremely confusing, when you see entity definitions, and config screens, and you go to a lot of work to configure them all, then find that all your work isn't used.
        Hide
        Jacques Le Roux added a comment -

        Thanks Adam,

        Sorry for you, it avoid me this useless "lot of work". I will see though if it's worth to continue Marco's work, I can't believe 115 kb of work is totally useless...

        Show
        Jacques Le Roux added a comment - Thanks Adam, Sorry for you, it avoid me this useless "lot of work". I will see though if it's worth to continue Marco's work, I can't believe 115 kb of work is totally useless...
        Hide
        Adam Heath added a comment -

        It is rather useless. Nothing reads the values in the database. None of the shipment integration code does. Having these config screens in the web backends makes one thing that they actually drive code. So, after spending tons of time to configure them, you find out that the shipment services still end up reading the property file for their data. That means this feature has wasted my time.

        Much work was done to actually figure out what settings each class is fetching from the property file; that's good. The entities themselves look like they would provide was is needed. It's just that none of the java code was ever modified to query such data.

        Show
        Adam Heath added a comment - It is rather useless. Nothing reads the values in the database. None of the shipment integration code does. Having these config screens in the web backends makes one thing that they actually drive code. So, after spending tons of time to configure them, you find out that the shipment services still end up reading the property file for their data. That means this feature has wasted my time. Much work was done to actually figure out what settings each class is fetching from the property file; that's good. The entities themselves look like they would provide was is needed. It's just that none of the java code was ever modified to query such data.
        Hide
        Jacques Le Roux added a comment -

        Thanks Adam,

        So it's an incomplete WIP, right?

        Show
        Jacques Le Roux added a comment - Thanks Adam, So it's an incomplete WIP, right?
        Hide
        Jacques Le Roux added a comment -

        Ha sorry,

        I did not look at the workflow (using All tab) and as Marco did not clearly wrote that it has been commited at r796874, did not clearly understand what was happening here. Now I understand you reopened it, and why.

        Show
        Jacques Le Roux added a comment - Ha sorry, I did not look at the workflow (using All tab) and as Marco did not clearly wrote that it has been commited at r796874, did not clearly understand what was happening here. Now I understand you reopened it, and why.
        Hide
        Marco Risaliti added a comment -

        I will provide an example of shipment gateway that it will use the new shipment gateway config entities.

        Thanks
        Marco

        Show
        Marco Risaliti added a comment - I will provide an example of shipment gateway that it will use the new shipment gateway config entities. Thanks Marco
        Hide
        Marco Risaliti added a comment -

        Now that all the shipment gateway supports the new Config entities I could close the main issue.

        Thanks
        Marco

        Show
        Marco Risaliti added a comment - Now that all the shipment gateway supports the new Config entities I could close the main issue. Thanks Marco

          People

          • Assignee:
            Marco Risaliti
            Reporter:
            Marco Risaliti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development