Details

    • Type: Sub-task Sub-task
    • Status: Open
    • Priority: Trivial Trivial
    • Resolution: Unresolved
    • Affects Version/s: Release Branch 4.0
    • Fix Version/s: None
    • Component/s: product
    • Labels:
      None

      Description

      The conditions for the error:

      • the order maysplit = Y
      • the order must have at least 1 backordered item and 1 item not backordered
      • a picklist is created with the non-backordered item

      If you create another picklist, it will include the non-backordered item.

      Also for some reason it looks like this situation causes a bin number to not be included in the picklist. I created a picklist of 5 orders and Bin Num 1 is missing.

      1. picklist.patch
        2 kB
        Albert Mayo

        Activity

        Albert Mayo created issue -
        Hide
        Albert Mayo added a comment -

        Unfortunately, I don't have time to officially contribute to the OFBiz project by properly submitting a patch, but I can explain the patch I am working on that seems to work.

        In PicklistServices.xml under the simple-method findOrdersToPickMove, around line 187, the code tries to filter out backordered items. The problem is it gives the condition <if-compare field-name="orderItemShipGroup.maySplit" operator="equals" value="Y"/>. This will make a backordered item to allow that order to the picklist. Since this order is added to the picklist, somewhere down road the order's non-backordered items are added to the picklist, even if it is already part of another picklist.

        I made 1 other modification that could be considered an enhancement or a bug. If a picked is marked as picked, any order in that picklist that was accidently missed will never show up in a future picklist. I made a modification to filter out Picked picklists, just as it does with Cancelled picklists, so that no orders are missed. This mod was made around line 151 with the addition of <condition-expr field-name="statusId" operator="not-equals" value="PICKLIST_PICKED"/>.

        I attached a patch for your reference only. It is from my personal repository.

        Show
        Albert Mayo added a comment - Unfortunately, I don't have time to officially contribute to the OFBiz project by properly submitting a patch, but I can explain the patch I am working on that seems to work. In PicklistServices.xml under the simple-method findOrdersToPickMove, around line 187, the code tries to filter out backordered items. The problem is it gives the condition <if-compare field-name="orderItemShipGroup.maySplit" operator="equals" value="Y"/>. This will make a backordered item to allow that order to the picklist. Since this order is added to the picklist, somewhere down road the order's non-backordered items are added to the picklist, even if it is already part of another picklist. I made 1 other modification that could be considered an enhancement or a bug. If a picked is marked as picked, any order in that picklist that was accidently missed will never show up in a future picklist. I made a modification to filter out Picked picklists, just as it does with Cancelled picklists, so that no orders are missed. This mod was made around line 151 with the addition of <condition-expr field-name="statusId" operator="not-equals" value="PICKLIST_PICKED"/>. I attached a patch for your reference only. It is from my personal repository.
        Hide
        Albert Mayo added a comment -

        attached patch for reference

        Show
        Albert Mayo added a comment - attached patch for reference
        Albert Mayo made changes -
        Field Original Value New Value
        Attachment picklist.patch [ 12408823 ]
        Jacques Le Roux made changes -
        Parent OFBIZ-3268 [ 12441818 ]
        Issue Type Bug [ 1 ] Sub-task [ 7 ]
        Gavin made changes -
        Workflow jira [ 12464124 ] OFbiz Workflow [ 12506972 ]

          People

          • Assignee:
            Unassigned
            Reporter:
            Albert Mayo
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development