OFBiz
  1. OFBiz
  2. OFBIZ-2070

New tool to get labels information

    Details

    • Type: New Feature New Feature
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: ALL COMPONENTS
    • Labels:
      None

      Description

      New tool to get labels information used in OFBiz.

      1. LabelsReferences8.patch
        66 kB
        Marco Risaliti
      2. LabelsReferences7.patch
        61 kB
        Marco Risaliti
      3. LabelsReferences6.patch
        213 kB
        Marco Risaliti
      4. LabelReferences5.patch
        6 kB
        Marco Risaliti
      5. CommonEntityLabels.patch
        160 kB
        Marco Risaliti
      6. LabelReferences4.patch
        215 kB
        Marco Risaliti
      7. LabelReferences3.patch
        18 kB
        Marco Risaliti
      8. LabelReferences2.patch
        62 kB
        Marco Risaliti
      9. LabelsInfo16.patch
        84 kB
        Marco Risaliti
      10. LabelsInfo14.patch
        71 kB
        Marco Risaliti
      11. LabelsInfo15.patch
        16 kB
        Marco Risaliti
      12. LabelsInfo14.patch
        71 kB
        Marco Risaliti
      13. LabelsInfo13.patch
        7 kB
        Marco Risaliti
      14. CleanupLabelsJLR.patch
        1.02 MB
        Jacques Le Roux
      15. LabelsInfo11.patch
        9 kB
        Marco Risaliti
      16. APACHE2_HEADER_FOR_XML
        0.8 kB
        Marco Risaliti
      17. LabelsInfo9.patch
        55 kB
        Marco Risaliti
      18. LabelsInfo5.png
        167 kB
        Marco Risaliti

        Issue Links

          Activity

          Hide
          Marco Risaliti added a comment -

          I'm closing this issue for the moment, if I need something more I will create a new issue.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - I'm closing this issue for the moment, if I need something more I will create a new issue. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          BTW It seems that Jira is more clever now and that I don't need anymore to add OFBIZ-issueNumber at end. Before it was not able to figure it out from the url, the 2 posts above show it can now

          Show
          Jacques Le Roux added a comment - BTW It seems that Jira is more clever now and that I don't need anymore to add OFBIZ-issueNumber at end. Before it was not able to figure it out from the url, the 2 posts above show it can now
          Hide
          Jacques Le Roux added a comment -

          Hi Marco,

          Your patch is in trunk (as you can see above )

          Show
          Jacques Le Roux added a comment - Hi Marco, Your patch is in trunk (as you can see above )
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          is it possible for you to review this patch that contains some labels hard-coded in the framework components.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, is it possible for you to review this patch that contains some labels hard-coded in the framework components. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          Updated LabelsReference8.patch to recently revision.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Updated LabelsReference8.patch to recently revision. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Please Marco, update before doing your patches : impossible to merge

          Thanks

          Show
          Jacques Le Roux added a comment - Please Marco, update before doing your patches : impossible to merge Thanks
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          is it possible for you to review LabelsReferences8.patch that contains some hard-coded labels into framework components.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, is it possible for you to review LabelsReferences8.patch that contains some hard-coded labels into framework components. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          No problem Jacques, probably I was not so clear.

          Thanks for your support
          Marco

          Show
          Marco Risaliti added a comment - No problem Jacques, probably I was not so clear. Thanks for your support Marco
          Hide
          Jacques Le Roux added a comment -

          Sorry Marco,

          I should have checked the files at beginning :/ (lesson learned)

          Done at r754754 and r754756

          Show
          Jacques Le Roux added a comment - Sorry Marco, I should have checked the files at beginning :/ (lesson learned) Done at r754754 and r754756
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          my last patch is only the result of put this svn property:

          svn:eol-style=native
          svn:mime-type=text/plain
          svn:keywords="Date Rev Author URL Id"

          any other changes has been done on those files.

          Could you simply change those svn property for the files of labelmanager ?

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, my last patch is only the result of put this svn property: svn:eol-style=native svn:mime-type=text/plain svn:keywords="Date Rev Author URL Id" any other changes has been done on those files. Could you simply change those svn property for the files of labelmanager ? Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Marco,

          LabelsReferences7.patch is not good. It's easy to check when there are one empty line between evry real lines : the patch is wrong. So seems that the problems remains...

          Show
          Jacques Le Roux added a comment - Marco, LabelsReferences7.patch is not good. It's easy to check when there are one empty line between evry real lines : the patch is wrong. So seems that the problems remains...
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          thanks a lot for your review and commit.
          It could be possible that when I change my laptop I forgot to insert the svn configuration and so could you please also commit LabelsReferences7.patch so that all these new files having the corrected svn property.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, thanks a lot for your review and commit. It could be possible that when I change my laptop I forgot to insert the svn configuration and so could you please also commit LabelsReferences7.patch so that all these new files having the corrected svn property. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Thanks Marco,

          LabelsReferences6 is in trunk at revision: 754649 .

          Have you forgotten to use the subversion client config file previously ?

          Show
          Jacques Le Roux added a comment - Thanks Marco, LabelsReferences6 is in trunk at revision: 754649 . Have you forgotten to use the subversion client config file previously ?
          Hide
          Marco Risaliti added a comment -

          HI Jacques,

          I'm uploading the new LabelsReferences6.patch that contains now also the svn properties that was missing on the first add to svn.
          I'm hoping that this was the problems to apply my patches.
          I have add now also the possibility to save a label into memory or into the xml file directly from update label form.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - HI Jacques, I'm uploading the new LabelsReferences6.patch that contains now also the svn properties that was missing on the first add to svn. I'm hoping that this was the problems to apply my patches. I have add now also the possibility to save a label into memory or into the xml file directly from update label form. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Sorry Marco,

          I can't apply this patch, even using http://my-i-p.com/Remove_Empty_Lines_from_Text.html

          Show
          Jacques Le Roux added a comment - Sorry Marco, I can't apply this patch, even using http://my-i-p.com/Remove_Empty_Lines_from_Text.html
          Hide
          Marco Risaliti added a comment -

          LabelReferences5.patch contains some fix about recent changes for security and some fix on autoFieldsService/autoFieldEntity.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - LabelReferences5.patch contains some fix about recent changes for security and some fix on autoFieldsService/autoFieldEntity. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          LabelReferences5.patch contains some small fix about recent changes for security and label references fix for autoFieldsEntity/autoFieldsService.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - LabelReferences5.patch contains some small fix about recent changes for security and label references fix for autoFieldsEntity/autoFieldsService. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          Thanks Jacques,

          I will provide a new patch with only the translation exceptions.

          Marco

          Show
          Marco Risaliti added a comment - Thanks Jacques, I will provide a new patch with only the translation exceptions. Marco
          Hide
          Jacques Le Roux added a comment -

          Hi Marco,

          There are a lot of duplicated labels in this patch. I mean in different languages (here, en and it) we repeat information already in data. This will make the process of maintaining these labels in other languages harder. Don't you thin in such cases we should simply rely on data ?

          Show
          Jacques Le Roux added a comment - Hi Marco, There are a lot of duplicated labels in this patch. I mean in different languages (here, en and it) we repeat information already in data. This will make the process of maintaining these labels in other languages harder. Don't you thin in such cases we should simply rely on data ?
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          could you check the CommonEntityLabel.patch that contains some translations about Enumeration/Geo.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, could you check the CommonEntityLabel.patch that contains some translations about Enumeration/Geo. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Hi Marco,

          One more time I got trapped with weird empty lines in your patch. I tried Ultraedit (Windows, I did not used it for years, I prefer Scite) but noways.
          I was saved by http://my-i-p.com/Remove_Empty_Lines_from_Text.html (just had to be sure to copy with right encoding, ie UTF8)
          I did a cursory review, sounds good.

          Your patch is in trunk at revision: 748732

          Thanks!

          Show
          Jacques Le Roux added a comment - Hi Marco, One more time I got trapped with weird empty lines in your patch. I tried Ultraedit (Windows, I did not used it for years, I prefer Scite) but noways. I was saved by http://my-i-p.com/Remove_Empty_Lines_from_Text.html (just had to be sure to copy with right encoding, ie UTF8) I did a cursory review, sounds good. Your patch is in trunk at revision: 748732 Thanks!
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          the new patch LabelReferences4.patch contains some improvements on Label Manager References.
          It contains also a lot of missing Common Entity Labels and Security Entity Labels.

          There are some improvements on Label Manager forms and it now also retrieve some entity labels references and webapp title.

          Is still present some issues about CommonEmptyHeader label still remain empty and possibility so save xml file during add/update of a label.

          I will provide more patches so please do not close thise issue.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, the new patch LabelReferences4.patch contains some improvements on Label Manager References. It contains also a lot of missing Common Entity Labels and Security Entity Labels. There are some improvements on Label Manager forms and it now also retrieve some entity labels references and webapp title. Is still present some issues about CommonEmptyHeader label still remain empty and possibility so save xml file during add/update of a label. I will provide more patches so please do not close thise issue. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Thanks Marco,

          Your patch is in trunk at revision: 744842

          I really appreciate the new "missing labels" feature, this will allow to update labels in language really easily. Just one point, CommonEmptyHeader is empty in all other languages but English because I removed the redundancy, anyway forget it, it's an exception. There are some others like that I don't remember from the top of my head.
          I like your last proposition, shall we still have to reload the complete list though ?

          Show
          Jacques Le Roux added a comment - Thanks Marco, Your patch is in trunk at revision: 744842 I really appreciate the new "missing labels" feature, this will allow to update labels in language really easily. Just one point, CommonEmptyHeader is empty in all other languages but English because I removed the redundancy, anyway forget it, it's an exception. There are some others like that I don't remember from the top of my head. I like your last proposition, shall we still have to reload the complete list though ?
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          this new patch includes some improvements to Label Manager references to see in details in which files are the labels used.
          I have also implemented the possibility to search labels to be translated for a language.
          It still to be implemented tree widget references as you proposed.
          About the problem that when you create or update a new label I propose that when we press update button we can also automatically save the changes to the xml file and be immediately visible in OFBiz without restarting it.

          Thanks for you help
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, this new patch includes some improvements to Label Manager references to see in details in which files are the labels used. I have also implemented the possibility to search labels to be translated for a language. It still to be implemented tree widget references as you proposed. About the problem that when you create or update a new label I propose that when we press update button we can also automatically save the changes to the xml file and be immediately visible in OFBiz without restarting it. Thanks for you help Marco
          Hide
          Jacques Le Roux added a comment -

          Thanks Marco,

          Your last patch is in trunk at revision: 744635.

          I know it's not much used but did you consider to have a getLabelsFromTreeWidgets ?

          In my opinion must have would be :

          • a list of missing labels. Since we can select a language it's would be a handy way to update labels from time to time.
          • A problem currently is when you update a label you have to reload all the labels to continue your translation on other labels. Because of this I don't use this feature but search the missing labels in French and create them using Eclipse+Oxygen+Intel® XML Software Suite
          Show
          Jacques Le Roux added a comment - Thanks Marco, Your last patch is in trunk at revision: 744635. I know it's not much used but did you consider to have a getLabelsFromTreeWidgets ? In my opinion must have would be : a list of missing labels. Since we can select a language it's would be a handy way to update labels from time to time. A problem currently is when you update a label you have to reload all the labels to continue your translation on other labels. Because of this I don't use this feature but search the missing labels in French and create them using Eclipse+Oxygen+Intel® XML Software Suite
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          please consider only this updated patch.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, please consider only this updated patch. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          the new class LabelReferences.java was not included in the patch with svn diff so I upload it now.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, the new class LabelReferences.java was not included in the patch with svn diff so I upload it now. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Hi Marco,

          Just applied the patch (looks good) and got this error building

          [javac15] D:\Workspace\ofbizRun\framework\webtools\src\org\ofbiz\webtools\labelmanager\LabelManagerFactory.java:153: cannot find symbol
          [javac15] symbol : variable LabelReferences
          [javac15] location: class org.ofbiz.webtools.labelmanager.LabelManagerFactory
          [javac15] references = LabelReferences.getLabelReferences();
          [javac15] ^
          [javac15] 1 error
          [javac15] 4 warnings

          BUILD FAILED
          D:\Workspace\ofbizRun\build.xml:146: The following error occurred while executing this line:
          D:\Workspace\ofbizRun\framework\build.xml:140: The following error occurred while executing this line:
          D:\Workspace\ofbizRun\macros.xml:27: The following error occurred while executing this line:
          D:\Workspace\ofbizRun\framework\webtools\build.xml:55: Compile failed; see the compiler error output for details.

          Show
          Jacques Le Roux added a comment - Hi Marco, Just applied the patch (looks good) and got this error building [javac15] D:\Workspace\ofbizRun\framework\webtools\src\org\ofbiz\webtools\labelmanager\LabelManagerFactory.java:153: cannot find symbol [javac15] symbol : variable LabelReferences [javac15] location: class org.ofbiz.webtools.labelmanager.LabelManagerFactory [javac15] references = LabelReferences.getLabelReferences(); [javac15] ^ [javac15] 1 error [javac15] 4 warnings BUILD FAILED D:\Workspace\ofbizRun\build.xml:146: The following error occurred while executing this line: D:\Workspace\ofbizRun\framework\build.xml:140: The following error occurred while executing this line: D:\Workspace\ofbizRun\macros.xml:27: The following error occurred while executing this line: D:\Workspace\ofbizRun\framework\webtools\build.xml:55: Compile failed; see the compiler error output for details.
          Hide
          Marco Risaliti added a comment -

          A new patch that now include some changes into Label Manager to see the references of labels into the sources.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - A new patch that now include some changes into Label Manager to see the references of labels into the sources. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          First version of label manager references, it needs to more patches to be completed.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - First version of label manager references, it needs to more patches to be completed. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Ho sorry Marco,

          I was really tired when I wrote such stupidity, of course it's the right solution !
          I have commited your proposed change in revision 741495.

          Show
          Jacques Le Roux added a comment - Ho sorry Marco, I was really tired when I wrote such stupidity, of course it's the right solution ! I have commited your proposed change in revision 741495.
          Hide
          Jacques Le Roux added a comment -

          Ha yes

           

          of course ! Mmm... contradictory with our rule "notHTML in labels". You could for now though if that ease your work. But can't you rather put a specific rule with "> <" in fot this case only ?

          Show
          Jacques Le Roux added a comment - Ha yes &nbsp; of course ! Mmm... contradictory with our rule "notHTML in labels". You could for now though if that ease your work. But can't you rather put a specific rule with "> <" in fot this case only ?
          Hide
          Jacques Le Roux added a comment -

          In this case if you try to that a look at ManufacturingDuplicatedComponentInBOM we have not lost of infomation with Label Manager.
          This is a workaround but for the moment acceptable.

          Yes, I saw. It's ok with me

          For CommonEmptyHeader why don't we change the content from space to , what did you think of it ?

          Hu ? I suppose a special char, but which one ?

          Show
          Jacques Le Roux added a comment - In this case if you try to that a look at ManufacturingDuplicatedComponentInBOM we have not lost of infomation with Label Manager. This is a workaround but for the moment acceptable. Yes, I saw. It's ok with me For CommonEmptyHeader why don't we change the content from space to , what did you think of it ? Hu ? I suppose a special char, but which one ?
          Hide
          Marco Risaliti added a comment -

          One I have completed to fix most of those bugs and Label Manager can be used normally, I would like to add to this tool a new column that show us where a label is referenced into the sources (screens/forms/ftl/java classes/minilang/ect.).

          Marco

          Show
          Marco Risaliti added a comment - One I have completed to fix most of those bugs and Label Manager can be used normally, I would like to add to this tool a new column that show us where a label is referenced into the sources (screens/forms/ftl/java classes/minilang/ect.). Marco
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          I agree with you that if we reduce the special characters from xml files that will be more readable.
          We agreed to remove it from label files but for the moment I convert it to made working correctly Label Manager.
          In this case if you try to that a look at ManufacturingDuplicatedComponentInBOM we have not lost of infomation with Label Manager.
          This is a workaround but for the moment acceptable.

          For CommonEmptyHeader why don't we change the content from space to  , what did you think of it ?

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, I agree with you that if we reduce the special characters from xml files that will be more readable. We agreed to remove it from label files but for the moment I convert it to made working correctly Label Manager. In this case if you try to that a look at ManufacturingDuplicatedComponentInBOM we have not lost of infomation with Label Manager. This is a workaround but for the moment acceptable. For CommonEmptyHeader why don't we change the content from space to  , what did you think of it ? Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Hi Marco,

          I agree that we can't have ampersand (&) and the left angle bracket (<) characters in xml but all others should be fine.
          This is only to keep labels more readable, not a big deal...
          Anyway, we also agreed on dev ML that we should not have any HTLM in labels. So actually we should extract them an put them where labels are called...

          Thanks

          Show
          Jacques Le Roux added a comment - Hi Marco, I agree that we can't have ampersand (&) and the left angle bracket (<) characters in xml but all others should be fine. This is only to keep labels more readable, not a big deal... Anyway, we also agreed on dev ML that we should not have any HTLM in labels. So actually we should extract them an put them where labels are called... Thanks
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          I have dig into the issue on label ManufacturingDuplicatedComponentInBOM and it's ok that Label Manager transform > into > inside an xml tag also because if you insert < it can be in conflict with </value.
          So in this case is dom xml serializer that transform < in >

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, I have dig into the issue on label ManufacturingDuplicatedComponentInBOM and it's ok that Label Manager transform > into > inside an xml tag also because if you insert < it can be in conflict with </value. So in this case is dom xml serializer that transform < in > Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Even more annoying

          <property key="ManufacturingNote3">
          <value xml:lang="en">, association has expired (<u>and should probably be deleted</u>).</value>
          <value xml:lang="es">, la asociación ya no es válida (<u>y probablemente debería borrarse</u>.</value>
          <value xml:lang="fr">, l'association a expiré (<u>et devrait probablement être supprimée</u>.</value>
          <value xml:lang="it">, associazione è scaduta (<u>e dovrebbe probabilmente essere cancellata</u>).</value>
          <value xml:lang="th">, มีกลุ่มที่ไม่เข้าร่วม (<u>และควรจะลบ</u>)</value>
          </property>

          <property key="ManufacturingNote3">
          <value xml:lang="en">, association has expired ().</value>
          <value xml:lang="es">, la asociación ya no es válida (.</value>
          <value xml:lang="fr">, l'association a expiré (.</value>
          <value xml:lang="it">, associazione è scaduta ().</value>
          <value xml:lang="th">, มีกลุ่มที่ไม่เข้าร่วม ()</value>
          </property>

          Show
          Jacques Le Roux added a comment - Even more annoying <property key="ManufacturingNote3"> <value xml:lang="en">, association has expired (<u>and should probably be deleted</u>).</value> <value xml:lang="es">, la asociación ya no es válida (<u>y probablemente debería borrarse</u>.</value> <value xml:lang="fr">, l'association a expiré (<u>et devrait probablement être supprimée</u>.</value> <value xml:lang="it">, associazione è scaduta (<u>e dovrebbe probabilmente essere cancellata</u>).</value> <value xml:lang="th">, มีกลุ่มที่ไม่เข้าร่วม (<u>และควรจะลบ</u>)</value> </property> <property key="ManufacturingNote3"> <value xml:lang="en">, association has expired ().</value> <value xml:lang="es">, la asociación ya no es válida (.</value> <value xml:lang="fr">, l'association a expiré (.</value> <value xml:lang="it">, associazione è scaduta ().</value> <value xml:lang="th">, มีกลุ่มที่ไม่เข้าร่วม ()</value> </property>
          Hide
          Jacques Le Roux added a comment -

          Still a problem with

          <property key="CommonEmptyHeader">
          <value xml:lang="de"> </value>
          <value xml:lang="en"> </value>
          <value xml:lang="es"> </value>
          <value xml:lang="fr"> </value>
          <value xml:lang="it"> </value>
          <value xml:lang="pt"> </value>
          <value xml:lang="th"> </value>
          </property>

          <property key="CommonEmptyHeader">
          <value xml:lang="de"/>
          <value xml:lang="en"/>
          <value xml:lang="es"/>
          <value xml:lang="fr"/>
          <value xml:lang="it"/>

          And we are still loosing some char that should be unchanged

              <property key="ManufacturingDuplicatedComponentInBOM">
                  <value xml:lang="de">Die folgenden Zuordnungen könnten Endlosschleifen verursachen:  {0} --> {1}</value>
                  <value xml:lang="en">The following association could cause loops: {0} --> {1}</value>
                  <value xml:lang="es">La siguiente asociación puede causar recursión: {0} --> {1}</value>
                  <value xml:lang="fr">L'association existante suivante pourrait causer des boucles : {0} --> {1}</value>
                  <value xml:lang="it">Le seguenti associazioni esistono utilizzando le cause: {0} --> {1}</value>
                  <value xml:lang="ro">Urmatoarele asocieri exista utilizand cauzele: {0} --> {1}</value>
                  <value xml:lang="th">ตามการรวมกลุ่มสามารถทำให้เกิดเป็นรอบวงกลมได้</value>
                  <value xml:lang="zh">下列关联可能会导致循环: {0} --> {1}</value>
              </property>
          
              <property key="ManufacturingDuplicatedComponentInBOM">
                  <value xml:lang="de">Die folgenden Zuordnungen könnten Endlosschleifen verursachen:  {0} --&gt; {1}</value>
                  <value xml:lang="en">The following association could cause loops: {0} --&gt; {1}</value>
                  <value xml:lang="es">La siguiente asociación puede causar recursión: {0} --&gt; {1}</value>
                  <value xml:lang="fr">L'association existante suivante pourrait causer des boucles : {0} --&gt; {1}</value>
                  <value xml:lang="it">Le seguenti associazioni esistono utilizzando le cause: {0} --&gt; {1}</value>
                  <value xml:lang="ro">Urmatoarele asocieri exista utilizand cauzele: {0} --&gt; {1}</value>
                  <value xml:lang="th">ตามการรวมกลุ่มสามารถทำให้เกิดเป็นรอบวงกลมได้</value>
                  <value xml:lang="zh">下列关联可能会导致循环: {0} --&gt; {1}</value>
              </property>
          
          Show
          Jacques Le Roux added a comment - Still a problem with <property key="CommonEmptyHeader"> <value xml:lang="de"> </value> <value xml:lang="en"> </value> <value xml:lang="es"> </value> <value xml:lang="fr"> </value> <value xml:lang="it"> </value> <value xml:lang="pt"> </value> <value xml:lang="th"> </value> </property> <property key="CommonEmptyHeader"> <value xml:lang="de"/> <value xml:lang="en"/> <value xml:lang="es"/> <value xml:lang="fr"/> <value xml:lang="it"/> And we are still loosing some char that should be unchanged <property key= "ManufacturingDuplicatedComponentInBOM" > <value xml:lang= "de" >Die folgenden Zuordnungen könnten Endlosschleifen verursachen: {0} --> {1}</value> <value xml:lang= "en" >The following association could cause loops: {0} --> {1}</value> <value xml:lang= "es" >La siguiente asociación puede causar recursión: {0} --> {1}</value> <value xml:lang= "fr" >L'association existante suivante pourrait causer des boucles : {0} --> {1}</value> <value xml:lang= "it" >Le seguenti associazioni esistono utilizzando le cause: {0} --> {1}</value> <value xml:lang= "ro" >Urmatoarele asocieri exista utilizand cauzele: {0} --> {1}</value> <value xml:lang= "th" >ตามการรวมกลุ่มสามารถทำให้เกิดเป็นรอบวงกลมได้</value> <value xml:lang= "zh" >下列关联可能会导致循环: {0} --> {1}</value> </property> <property key= "ManufacturingDuplicatedComponentInBOM" > <value xml:lang= "de" >Die folgenden Zuordnungen könnten Endlosschleifen verursachen: {0} --&gt; {1}</value> <value xml:lang= "en" >The following association could cause loops: {0} --&gt; {1}</value> <value xml:lang= "es" >La siguiente asociación puede causar recursión: {0} --&gt; {1}</value> <value xml:lang= "fr" >L'association existante suivante pourrait causer des boucles : {0} --&gt; {1}</value> <value xml:lang= "it" >Le seguenti associazioni esistono utilizzando le cause: {0} --&gt; {1}</value> <value xml:lang= "ro" >Urmatoarele asocieri exista utilizand cauzele: {0} --&gt; {1}</value> <value xml:lang= "th" >ตามการรวมกลุ่มสามารถทำให้เกิดเป็นรอบวงกลมได้</value> <value xml:lang= "zh" >下列关联可能会导致循环: {0} --&gt; {1}</value> </property>
          Hide
          Jacques Le Roux added a comment -

          About comments, some are ok though

          Working base
          <value xml:lang="es">Taza</value>
          <value xml:lang="fr">Cup (236,59 cm³)</value> <!-- a very good link : http://unit-converter.org -->
          <value xml:lang="it">Tazza</value>

          Working copy (after saving files in Label Manager)
          <value xml:lang="es">Taza</value>
          <value xml:lang="fr">Cup (236,59 cm³)</value>
          <!-- a very good link : http://unit-converter.org -->
          <value xml:lang="it">Tazza</value>

          Show
          Jacques Le Roux added a comment - About comments, some are ok though Working base <value xml:lang="es">Taza</value> <value xml:lang="fr">Cup (236,59 cm³)</value> <!-- a very good link : http://unit-converter.org --> <value xml:lang="it">Tazza</value> Working copy (after saving files in Label Manager) <value xml:lang="es">Taza</value> <value xml:lang="fr">Cup (236,59 cm³)</value> <!-- a very good link : http://unit-converter.org --> <value xml:lang="it">Tazza</value>
          Hide
          Jacques Le Roux added a comment -

          Hi Marco,

          One more point : the Label Manager should write file using the OS EOL type (ie CRLF for Windows for instance). Because else you get tons of false changes (only EOLs changed)

          Also there are still issues with comments

          Working base

                  <!--value xml:lang="ro">Parte accesibila pentru Business Family of Open Source Software</value-->
                  <!--value xml:lang="ro">Parte din Open for Business Family of Open Source Software</value-->
                  <value xml:lang="ro">Partea de Deschidere Pentru Afaceri Familiale din Open Source Software</value>
                  <!--value xml:lang="ru">Часть семейства ПО Open For Business</value-->
                  <!--value xml:lang="ru">Часть семейства "Open For Business Family" программных продуктов Open Source </value-->
                  <value xml:lang="ru">Входит в состав семейства Open For Business</value>
                  <!--value xml:lang="th">เป็นส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value-->
                  <value xml:lang="th">ส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value>
                  <!--value xml:lang="zh">开源软件OFBiz的组成部分</value-->
                  <!--value xml:lang="zh">开源软件OFBiz的组成部分</value-->
          

          Worling copy (after saving files in Label Manager)

                  <!--value xml:lang="ro">Parte accesibila pentru Business Family of Open Source Software</valuevalue xml:lang="ro">Parte din Open for Business Family of Open Source Software</value-->
                  <value xml:lang="ro">Partea de Deschidere Pentru Afaceri Familiale din Open Source Software</value>
                  <!--value xml:lang="ru">Часть семейства ПО Open For Business</valuevalue xml:lang="ru">Часть семейства "Open For Business Family" программных продуктов Open Source </value-->
                  <value xml:lang="ru">Входит в состав семейства Open For Business</value>
                  <!--value xml:lang="th">เป็นส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value-->
                  <value xml:lang="th">ส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value>
                  <!--value xml:lang="zh">开源软件OFBiz的组成部分</valuevalue xml:lang="zh">开源软件OFBiz的组成部分</value-->
          

          Anyway, I will already commit this to facilitate your work and mine

          Show
          Jacques Le Roux added a comment - Hi Marco, One more point : the Label Manager should write file using the OS EOL type (ie CRLF for Windows for instance). Because else you get tons of false changes (only EOLs changed) Also there are still issues with comments Working base <!--value xml:lang= "ro" >Parte accesibila pentru Business Family of Open Source Software</value--> <!--value xml:lang= "ro" >Parte din Open for Business Family of Open Source Software</value--> <value xml:lang= "ro" >Partea de Deschidere Pentru Afaceri Familiale din Open Source Software</value> <!--value xml:lang= "ru" >Часть семейства ПО Open For Business</value--> <!--value xml:lang= "ru" >Часть семейства "Open For Business Family" программных продуктов Open Source </value--> <value xml:lang= "ru" >Входит в состав семейства Open For Business</value> <!--value xml:lang= "th" >เป็นส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value--> <value xml:lang= "th" >ส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value> <!--value xml:lang= "zh" >开源软件OFBiz的组成部分</value--> <!--value xml:lang= "zh" >开源软件OFBiz的组成部分</value--> Worling copy (after saving files in Label Manager) <!--value xml:lang= "ro" >Parte accesibila pentru Business Family of Open Source Software</valuevalue xml:lang= "ro" >Parte din Open for Business Family of Open Source Software</value--> <value xml:lang= "ro" >Partea de Deschidere Pentru Afaceri Familiale din Open Source Software</value> <!--value xml:lang= "ru" >Часть семейства ПО Open For Business</valuevalue xml:lang= "ru" >Часть семейства "Open For Business Family" программных продуктов Open Source </value--> <value xml:lang= "ru" >Входит в состав семейства Open For Business</value> <!--value xml:lang= "th" >เป็นส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value--> <value xml:lang= "th" >ส่วนหนึ่งของธุรกิจแบบครอบครัวที่เป็นซอฟต์แวร์โอเพนซอส</value> <!--value xml:lang= "zh" >开源软件OFBiz的组成部分</valuevalue xml:lang= "zh" >开源软件OFBiz的组成部分</value--> Anyway, I will already commit this to facilitate your work and mine
          Hide
          Jacques Le Roux added a comment -

          Finally I was able to do it. On Windows I used this tool and then with Winmerge I replaced the lines needed (not real empty lines).
          There is still this weird sorting : something empty is placed after the same line but not empty. IMO it should not (but it's minor I agree ;o), like

          <property key="CharacterSet.description.ISO-8859-10">
          <value xml:lang="de">ISO-8859-10</value>
          <value xml:lang="en">ISO-8859-10</value>
          <value xml:lang="es">ISO-8859-10 ?</value>
          <value xml:lang="fr">ISO-8859-10</value>
          <value xml:lang="it">ISO-8859-10</value>
          <value xml:lang="th">ISO-8859-10</value>
          </property>
          <property key="CharacterSet.description.ISO-8859-1">
          <value xml:lang="de">ISO-8859-1</value>
          <value xml:lang="en">ISO-8859-1</value>
          <value xml:lang="es">ISO-8859-1 Inglés</value>
          <value xml:lang="fr">ISO-8859-1</value>
          <value xml:lang="it">ISO-8859-1</value>
          <value xml:lang="th">ISO-8859-1</value>
          </property>

          IMO <property key="CharacterSet.description.ISO-8859-1"> should be before <property key="CharacterSet.description.ISO-8859-10">

          Show
          Jacques Le Roux added a comment - Finally I was able to do it. On Windows I used this tool and then with Winmerge I replaced the lines needed (not real empty lines). There is still this weird sorting : something empty is placed after the same line but not empty. IMO it should not (but it's minor I agree ;o), like <property key="CharacterSet.description.ISO-8859-10"> <value xml:lang="de">ISO-8859-10</value> <value xml:lang="en">ISO-8859-10</value> <value xml:lang="es">ISO-8859-10 ?</value> <value xml:lang="fr">ISO-8859-10</value> <value xml:lang="it">ISO-8859-10</value> <value xml:lang="th">ISO-8859-10</value> </property> <property key="CharacterSet.description.ISO-8859-1"> <value xml:lang="de">ISO-8859-1</value> <value xml:lang="en">ISO-8859-1</value> <value xml:lang="es">ISO-8859-1 Inglés</value> <value xml:lang="fr">ISO-8859-1</value> <value xml:lang="it">ISO-8859-1</value> <value xml:lang="th">ISO-8859-1</value> </property> IMO <property key="CharacterSet.description.ISO-8859-1"> should be before <property key="CharacterSet.description.ISO-8859-10">
          Hide
          Jacques Le Roux added a comment -

          Hi Marco,

          Same problem. Some blank lines (with only LF) are in some files. Look at UpdateLabel.ftl in patch for instance.
          You could try http://www.cyberciti.biz/faq/howto-linux-unix-command-remove-all-blank-lines/ but be sure top remove only real blank lines and not the ones with a space in. And even doing that I'm not sure it will resolve this issue because maybe some blank lines are needed in the patch...

          I can dot it by hand with Scite, but it would be very tedious, especially if I have to do it for every patches

          Show
          Jacques Le Roux added a comment - Hi Marco, Same problem. Some blank lines (with only LF) are in some files. Look at UpdateLabel.ftl in patch for instance. You could try http://www.cyberciti.biz/faq/howto-linux-unix-command-remove-all-blank-lines/ but be sure top remove only real blank lines and not the ones with a space in. And even doing that I'm not sure it will resolve this issue because maybe some blank lines are needed in the patch... I can dot it by hand with Scite, but it would be very tedious, especially if I have to do it for every patches
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          I have done convert line delimiter to MacOS 9 and this is the updated patch.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, I have done convert line delimiter to MacOS 9 and this is the updated patch. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Hi Marco,

          Same problem for some files in LabelsInfo14.patch. Could you try to make all EOL the same using Eclipse before patching ?

          1. Select the project root
          2. Use menu File/Convert Line Delimiters To
          Show
          Jacques Le Roux added a comment - Hi Marco, Same problem for some files in LabelsInfo14.patch. Could you try to make all EOL the same using Eclipse before patching ? Select the project root Use menu File/Convert Line Delimiters To
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          LabelsInfo15.patch contains some comments for property and value tag to be moved before those tags.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, LabelsInfo15.patch contains some comments for property and value tag to be moved before those tags. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          I have seen that some comments are after the property or value tag instead they must be before.
          I will commit some changes to support comments correctly.

          Show
          Marco Risaliti added a comment - I have seen that some comments are after the property or value tag instead they must be before. I will commit some changes to support comments correctly.
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          Label manager now supports also comments at property and value level in the UiLabel xml files.
          In the attached patch you can find also replace of \r\n to \n.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, Label manager now supports also comments at property and value level in the UiLabel xml files. In the attached patch you can find also replace of \r\n to \n. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          CleanupLabelsJLR.patch has been committed (amended)

          Show
          Jacques Le Roux added a comment - CleanupLabelsJLR.patch has been committed (amended)
          Hide
          Jacques Le Roux added a comment -

          Hi Marco,

          • Yes certainly an issue migrating from Windows to PC. We will see later if other issues arise...
          • CommonEmptyHeader labels is not totally empty, there are at least a space in them

          LabelsInfo13.patch is in trunk revision: 737491

          Thanks

          Show
          Jacques Le Roux added a comment - Hi Marco, Yes certainly an issue migrating from Windows to PC. We will see later if other issues arise... CommonEmptyHeader labels is not totally empty, there are at least a space in them LabelsInfo13.patch is in trunk revision: 737491 Thanks
          Hide
          Marco Risaliti added a comment -

          With the following patch it can be also be possible to remove a label from Label Manager.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - With the following patch it can be also be possible to remove a label from Label Manager. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          first of all thank you for all your work you have done with my patches.
          Can be possible that when I moved the patches from XP to Mac it cause those problems ?
          I'm now checking all your bugs you have seen and most of them I had already seen some days ago but I still not having the time to fix it.
          For the moment with this patch it can be possible to fix the problem about editing labels that doesn't show the translations.
          I have seen also that the label CommonEmptyHeader will be deleted because all the rows is empty.
          In this case probably I have to leave like it and use a specific button to remove completely a label.
          I will work on the others issue step by step and provide some patches.

          Thanks a lot
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, first of all thank you for all your work you have done with my patches. Can be possible that when I moved the patches from XP to Mac it cause those problems ? I'm now checking all your bugs you have seen and most of them I had already seen some days ago but I still not having the time to fix it. For the moment with this patch it can be possible to fix the problem about editing labels that doesn't show the translations. I have seen also that the label CommonEmptyHeader will be deleted because all the rows is empty. In this case probably I have to leave like it and use a specific button to remove completely a label. I will work on the others issue step by step and provide some patches. Thanks a lot Marco
          Hide
          Jacques Le Roux added a comment -

          In CleanupLabelsJLR.patch patch

          1. <property key="CharacterSet.description.ISO-8859-10"> should be after <property key="CharacterSet.description.ISO-8859-1"> (same than point 1 above)

          Ho, I gave up, I will do it file by file...

          Show
          Jacques Le Roux added a comment - In CleanupLabelsJLR.patch patch <property key="CharacterSet.description.ISO-8859-10"> should be after <property key="CharacterSet.description.ISO-8859-1"> (same than point 1 above) Ho, I gave up, I will do it file by file...
          Hide
          Jacques Le Roux added a comment -

          Mmm... This sentence

          After applying this patch (reversible), if you make a change using Labels Manager and save it, you will find a bunch of errors of (at least) the 4 types above. This should help you to fix them.

          is wrong : we need to fix the Labels Manager before else it will overwrite the corrections I made manually in this patch... So please only check it's ok and I will commit it...

          Show
          Jacques Le Roux added a comment - Mmm... This sentence After applying this patch (reversible), if you make a change using Labels Manager and save it, you will find a bunch of errors of (at least) the 4 types above. This should help you to fix them. is wrong : we need to fix the Labels Manager before else it will overwrite the corrections I made manually in this patch... So please only check it's ok and I will commit it...
          Hide
          Jacques Le Roux added a comment -

          CleanupLabelsJLR.patch n: not intended to be committed yet...

          Show
          Jacques Le Roux added a comment - CleanupLabelsJLR.patch n: not intended to be committed yet...
          Hide
          Jacques Le Roux added a comment -

          Marco,

          We can't still use the Label Manager wihout checking each changes because :

          1. It removes comments in files, and I used comments to keep some alternatives available for future check/use (see ManufacturingCompanySubtitle for instance)
          2. Still few labels not correctly sorted (MimeType.description.application/vnd.ofbiz.survey should not move for instance, but it's very minor so far...)
          3. It removes html tags in labels without any notices (see ManufacturingNote3). I agree that there should not be html tags in labels (tough is may be discused) but we should not remove/loose them without knowing it... Even ManufacturingDuplicatedComponentInBOM do not have to be changed, only the ampersand character (&) and the left angle bracket (<) should be changed.
          4. It destroys CommonEmptyHeader

          I have created the patch CleanupLabelsJLR.patch. It contains changes I checked should be OK. Could you please double-check I did not forget something ?

          After applying this patch (reversible), if you make a change using Labels Manager and save it, you will find a bunch of errors of (at least) the 4 types above. This should help you to fix them.

          Thanks

          Show
          Jacques Le Roux added a comment - Marco, We can't still use the Label Manager wihout checking each changes because : It removes comments in files, and I used comments to keep some alternatives available for future check/use (see ManufacturingCompanySubtitle for instance) Still few labels not correctly sorted (MimeType.description.application/vnd.ofbiz.survey should not move for instance, but it's very minor so far...) It removes html tags in labels without any notices (see ManufacturingNote3). I agree that there should not be html tags in labels (tough is may be discused) but we should not remove/loose them without knowing it... Even ManufacturingDuplicatedComponentInBOM do not have to be changed, only the ampersand character (&) and the left angle bracket (<) should be changed . It destroys CommonEmptyHeader I have created the patch CleanupLabelsJLR.patch. It contains changes I checked should be OK. Could you please double-check I did not forget something ? After applying this patch (reversible), if you make a change using Labels Manager and save it, you will find a bunch of errors of (at least) the 4 types above. This should help you to fix them. Thanks
          Hide
          Jacques Le Roux added a comment -

          Marco,

          Something that seems to not work anymore : when you edit a label you don't find the existing translations (for instance trying to add OrderPromotion translation in French I don't see English and Italian translations). I think we should always show all existing translations, it helps translation.

          Anyway I guess we will make other enhancements (I foresee, list of empty translations, etc.). Should we close this issue ?

          Show
          Jacques Le Roux added a comment - Marco, Something that seems to not work anymore : when you edit a label you don't find the existing translations (for instance trying to add OrderPromotion translation in French I don't see English and Italian translations). I think we should always show all existing translations, it helps translation. Anyway I guess we will make other enhancements (I foresee, list of empty translations, etc.). Should we close this issue ?
          Hide
          Jacques Le Roux added a comment -

          Hi Marco,

          Still the same problem. There is somehting weird in your patches (10 and 11 I mean). It comes from LabelManagerFactory.java. There seems to be duplicated blank lines in the patch. I don't know if it comes from the java file or patch creation.

          The 1st error appears at line 11. I was able to fix it by removing this blank line. But then I got trap with line 63 again. Then I used Scite with menu option View/End Of Line checked, and I then see (on Windows) strange LFs in green (there are also LFs in other colors that I'm used to see). I tried to remove only the line 63, but then got the same problem in line 64. So I removed (by hand, not doable with replace feature apparently) all the green LFs and was able to merge.

          These green LFs don't appear in FileUtil.java. Really weird... I searched an explanation Googling for "Scite green LF" an "Scite colored end of line" but find nothing clear...

          I already tried in previous attemps to replace LF by CRLF but it does not fix the merging issue. Please could you check your both other java files ? It would be better to find the reason, if possible, than to have to deal with that later

          Also I removed a tab in
          + labels.remove(key + keySeparator + fileName);
          and fixed a small bug in UpdateLabel.ftl[59]
          <#assign labelVal = (label.getLabelValue(localeFound))?if_exists>

          I attach the modified patch (without green LFs), HTH

          Finally your patch is in trunk at revision: 737382.

          It seems to work well, but I have still to check the 32 XML files I modified while only adding a l10n for key "ebay" in French, great work

          Show
          Jacques Le Roux added a comment - Hi Marco, Still the same problem. There is somehting weird in your patches (10 and 11 I mean). It comes from LabelManagerFactory.java. There seems to be duplicated blank lines in the patch. I don't know if it comes from the java file or patch creation. The 1st error appears at line 11. I was able to fix it by removing this blank line. But then I got trap with line 63 again. Then I used Scite with menu option View/End Of Line checked, and I then see (on Windows) strange LFs in green (there are also LFs in other colors that I'm used to see). I tried to remove only the line 63, but then got the same problem in line 64. So I removed (by hand, not doable with replace feature apparently) all the green LFs and was able to merge. These green LFs don't appear in FileUtil.java. Really weird... I searched an explanation Googling for "Scite green LF" an "Scite colored end of line" but find nothing clear... I already tried in previous attemps to replace LF by CRLF but it does not fix the merging issue. Please could you check your both other java files ? It would be better to find the reason, if possible, than to have to deal with that later Also I removed a tab in + labels.remove(key + keySeparator + fileName); and fixed a small bug in UpdateLabel.ftl [59] <#assign labelVal = (label.getLabelValue(localeFound))?if_exists> I attach the modified patch (without green LFs), HTH Finally your patch is in trunk at revision: 737382. It seems to work well, but I have still to check the 32 XML files I modified while only adding a l10n for key "ebay" in French, great work
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          I have uploaded a new patch.
          I have tried to do those steps:

          • copy the patch into the root folder of OFBiz
          • patch -p0 -iLabelsInfo11.patch
          • copy the APACHE2_HEADER_FOR_XML under framework/webtools/config

          Let me know if you get some more issues.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, I have uploaded a new patch. I have tried to do those steps: copy the patch into the root folder of OFBiz patch -p0 -iLabelsInfo11.patch copy the APACHE2_HEADER_FOR_XML under framework/webtools/config Let me know if you get some more issues. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          A new updated patch.

          Show
          Marco Risaliti added a comment - A new updated patch.
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          you have also to add this file on the root of OFBiz.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, you have also to add this file on the root of OFBiz. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          I have tried to create it from svn client.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, I have tried to create it from svn client. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Oops, I did no get the right patch (I took the old one ).
          Anyway also a pb with the right one :

          D:\Workspace\ofbizRun>patch -p0 0<LabelsInfo10.patch
          patching file framework/base/src/org/ofbiz/base/util/FileUtil.java
          patching file framework/webtools/src/org/ofbiz/webtools/labelmanager/SaveLabelsToXmlFile.java
          patch: **** malformed patch at line 161:

          Show
          Jacques Le Roux added a comment - Oops, I did no get the right patch (I took the old one ). Anyway also a pb with the right one : D:\Workspace\ofbizRun>patch -p0 0<LabelsInfo10.patch patching file framework/base/src/org/ofbiz/base/util/FileUtil.java patching file framework/webtools/src/org/ofbiz/webtools/labelmanager/SaveLabelsToXmlFile.java patch: **** malformed patch at line 161:
          Hide
          Jacques Le Roux added a comment -

          Marco,

          Sorry but you did not update. I have already commited some changes in revision 731370. I should not have some (revision 0) I see in your patch. Could you please update and create a new patch

          Thanks

          Show
          Jacques Le Roux added a comment - Marco, Sorry but you did not update. I have already commited some changes in revision 731370. I should not have some (revision 0) I see in your patch. Could you please update and create a new patch Thanks
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          the attached file LabelsInfo10.patch , solve the main issues you have found:

          • adding the ASL header
          • taking care of labels sorting in the case described above

          the other improvements requested will be implemented later.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, the attached file LabelsInfo10.patch , solve the main issues you have found: adding the ASL header taking care of labels sorting in the case described above the other improvements requested will be implemented later. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          I had another idea : it would be great to use the Ajax way to edit fields (cf. Ajax Example).
          This would be particularly convenient when dealing with a sole language, which is the most common case.

          Show
          Jacques Le Roux added a comment - I had another idea : it would be great to use the Ajax way to edit fields (cf. Ajax Example). This would be particularly convenient when dealing with a sole language, which is the most common case.
          Hide
          Jacques Le Roux added a comment -

          From Bruno Busco in dev ML

          Great stuff !
          I agree, thanks Marco.

          It would be also nice to have a translation percentage.
          For each language: Number of translated label / Total number of labels * 100

          Show
          Jacques Le Roux added a comment - From Bruno Busco in dev ML Great stuff ! I agree, thanks Marco. It would be also nice to have a translation percentage. For each language: Number of translated label / Total number of labels * 100
          Hide
          Jacques Le Roux added a comment -

          One more comment : it would be great to color lines where at least one labels is missing. When searching for a lanquage it would be of a great help. We could even propose to return a list of missing labels for one language, etc.

          Great stuff !

          Show
          Jacques Le Roux added a comment - One more comment : it would be great to color lines where at least one labels is missing. When searching for a lanquage it would be of a great help. We could even propose to return a list of missing labels for one language, etc. Great stuff !
          Hide
          Marco Risaliti added a comment -

          Thanks a lot Jacques to commit this changed patch.
          I will work on those issues as soon as I get the time.

          Marco

          Show
          Marco Risaliti added a comment - Thanks a lot Jacques to commit this changed patch. I will work on those issues as soon as I get the time. Marco
          Hide
          Jacques Le Roux added a comment -

          I commited a modified LabelsInfo9.patch in 731370 :

          I commented out for now the lines in SaveLabelsToXmlFile.java which write the XML changes.
          We have, at least, known 2 issued related to SaveLabelsToXmlFile :

          • adding the ASL header
          • taking care of labels sorting in the case described above
          Show
          Jacques Le Roux added a comment - I commited a modified LabelsInfo9.patch in 731370 : I commented out for now the lines in SaveLabelsToXmlFile.java which write the XML changes. We have, at least, known 2 issued related to SaveLabelsToXmlFile : adding the ASL header taking care of labels sorting in the case described above
          Hide
          Jacques Le Roux added a comment -

          Marco,

          I tried this afternoon to fix the "apache licence header comment in the xml file generated", from here seemed pretty easy but, as you, did not succed so far.

          I found another issue. When you save a file, the Labels Manager doest not strictly respect the order. You get this kind of things : a label, with other labels having the same beginning, is posted at the end of the group. For instance
          <property key="AccountingAccount">
          will be after
          <property key="AccountingAccounts"> (the last of the group)

          I'm a bit struggling, merging changes I made between LabelsInfo8.patch and LabelsInfo9.patch, at the end we will finally have good tools for translation works !

          Show
          Jacques Le Roux added a comment - Marco, I tried this afternoon to fix the "apache licence header comment in the xml file generated", from here seemed pretty easy but, as you, did not succed so far. I found another issue. When you save a file, the Labels Manager doest not strictly respect the order. You get this kind of things : a label, with other labels having the same beginning, is posted at the end of the group. For instance <property key="AccountingAccount"> will be after <property key="AccountingAccounts"> (the last of the group) I'm a bit struggling, merging changes I made between LabelsInfo8.patch and LabelsInfo9.patch, at the end we will finally have good tools for translation works !
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          I have uploaded a new patch for label manager and I have solved some of your requests :

          1. Currently, during 1st pass when loading the Labels manager page, I'm stopping in debugger at LabelManagerFactory.java[110] to know which labels are duplicated . Not tedious for me, but impractical for most people, I guess

          It was not normally happens that there are duplicated locales for the same labels and for the moment when it happens it cannot permit to save the changes to the xml file from label manager.

          2. There is an issue with cache : if you clear it an reload the page (1st pass again) all lables are counted as duplicated.

          Fixed in the new patch.

          3. I noticed also that when you choose all languages, you get the current language as 1st column with another column duplicated farther. But the 1st column is empty

          Fixed in rev. 731313.

          4. Anyway I think I will wait also for the "apache licence header comment in the xml file generated" before commiting anything.

          Is still need to be fixed because I was not able to put the comment at beginning of the xml file.

          Probably can it be committed but it has not so completed and tested for using it definitely ?
          What others thinking about it ?

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, I have uploaded a new patch for label manager and I have solved some of your requests : 1. Currently, during 1st pass when loading the Labels manager page, I'm stopping in debugger at LabelManagerFactory.java [110] to know which labels are duplicated . Not tedious for me, but impractical for most people, I guess It was not normally happens that there are duplicated locales for the same labels and for the moment when it happens it cannot permit to save the changes to the xml file from label manager. 2. There is an issue with cache : if you clear it an reload the page (1st pass again) all lables are counted as duplicated. Fixed in the new patch. 3. I noticed also that when you choose all languages, you get the current language as 1st column with another column duplicated farther. But the 1st column is empty Fixed in rev. 731313. 4. Anyway I think I will wait also for the "apache licence header comment in the xml file generated" before commiting anything. Is still need to be fixed because I was not able to put the comment at beginning of the xml file. Probably can it be committed but it has not so completed and tested for using it definitely ? What others thinking about it ? Thanks Marco
          Hide
          Marco Risaliti added a comment -

          An updated patch for label manager.

          Show
          Marco Risaliti added a comment - An updated patch for label manager.
          Hide
          Jacques Le Roux added a comment -
          • I noticed also that when you choose all languages, you get the current language as 1st column with another column duplicated farther. But the 1st column is empty
          • Anyway I think I will wait also for the "apache licence header comment in the xml file generated" before commiting anything.
          Show
          Jacques Le Roux added a comment - I noticed also that when you choose all languages, you get the current language as 1st column with another column duplicated farther. But the 1st column is empty Anyway I think I will wait also for the "apache licence header comment in the xml file generated" before commiting anything.
          Hide
          Jacques Le Roux added a comment -

          I like this tool, it's very usefull to track down labels issues. I have some requests though :

          1. Currently, during 1st pass when loading the Labels manager page, I'm stopping in debugger at LabelManagerFactory.java[110] to know which labels are duplicated . Not tedious for me, but impractical for most people, I guess
          2. There is an issue with cache : if you clear it an reload the page (1st pass again) all lables are counted as duplicated.

          I will try to cope with the 2d issue, and will see the 1st later ...

          Then ( 2d issue, ok) I will commit even if it's not totally complete : this tools is a must as soon as you have to deal with labels !

          Thanks Marco !

          Show
          Jacques Le Roux added a comment - I like this tool, it's very usefull to track down labels issues. I have some requests though : Currently, during 1st pass when loading the Labels manager page, I'm stopping in debugger at LabelManagerFactory.java [110] to know which labels are duplicated . Not tedious for me, but impractical for most people, I guess There is an issue with cache : if you clear it an reload the page (1st pass again) all lables are counted as duplicated. I will try to cope with the 2d issue, and will see the 1st later ... Then ( 2d issue, ok) I will commit even if it's not totally complete : this tools is a must as soon as you have to deal with labels ! Thanks Marco !
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          when you try to update labels files it sorts the labels by the key and inside a label it will be sorted by locales.
          Is still missing to add the apache licence header comment in the xml file generated, I'm not able to fix this issue at the moment.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, when you try to update labels files it sorts the labels by the key and inside a label it will be sorted by locales. Is still missing to add the apache licence header comment in the xml file generated, I'm not able to fix this issue at the moment. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          It replace the previous broken patch.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - It replace the previous broken patch. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          BTW Marco, have you a plan to integrate Erik Wegner's sort-labels-groovy-script from OFBIZ-2068 ?

          Show
          Jacques Le Roux added a comment - BTW Marco, have you a plan to integrate Erik Wegner's sort-labels-groovy-script from OFBIZ-2068 ?
          Hide
          Jacques Le Roux added a comment -

          I tested without the labels, very useful !

          Show
          Jacques Le Roux added a comment - I tested without the labels, very useful !
          Hide
          Jacques Le Roux added a comment -

          Marco,

          No, I mean that I can't apply the patch At least I can't merge the uilabels files modified, using Tortoise or Eclipse

          Have a look for instance in WebtoolsErrorUiLabels.xml at
          <property key="foundgenericWebEvent.conversion_failed"> in French or
          <property key="utilCache.couldNotClearCacheNotFoundName"> in Italian

          Or <property key="FormFieldTitle_entitySyncId"> in WebtoolsUiLabels.xml

          Show
          Jacques Le Roux added a comment - Marco, No, I mean that I can't apply the patch At least I can't merge the uilabels files modified, using Tortoise or Eclipse Have a look for instance in WebtoolsErrorUiLabels.xml at <property key="foundgenericWebEvent.conversion_failed"> in French or <property key="utilCache.couldNotClearCacheNotFoundName"> in Italian Or <property key="FormFieldTitle_entitySyncId"> in WebtoolsUiLabels.xml
          Hide
          Marco Risaliti added a comment -

          Hi Jacques,

          did you mean that after save the xml file from Label Manager you have seen some characters not encoded correctly in UTF-8 ?
          Can you give an example to understand the issue ?
          Anyway it is still not completed because the apache license header it is not saved.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Jacques, did you mean that after save the xml file from Label Manager you have seen some characters not encoded correctly in UTF-8 ? Can you give an example to understand the issue ? Anyway it is still not completed because the apache license header it is not saved. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Hi Marco,

          It seems that there are some issues with your uilabels.xml files encoding. Could you check please ?

          Thanks

          Show
          Jacques Le Roux added a comment - Hi Marco, It seems that there are some issues with your uilabels.xml files encoding. Could you check please ? Thanks
          Hide
          Marco Risaliti added a comment -

          A new updated patch that replace the other ones.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - A new updated patch that replace the other ones. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          A new updated patch that replace the previous one.
          Still something to be implemented not ready to be commited.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - A new updated patch that replace the previous one. Still something to be implemented not ready to be commited. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          New screenshot.

          Show
          Marco Risaliti added a comment - New screenshot.
          Hide
          Marco Risaliti added a comment -

          New screenshot.

          Show
          Marco Risaliti added a comment - New screenshot.
          Hide
          Marco Risaliti added a comment -

          New screenshot.

          Show
          Marco Risaliti added a comment - New screenshot.
          Hide
          Marco Risaliti added a comment -

          Updated patch but still something to be implented not ready to be commited.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Updated patch but still something to be implented not ready to be commited. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          I have done some changes but still not been completed, please do not commit it's only if someone want to review it.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - I have done some changes but still not been completed, please do not commit it's only if someone want to review it. Thanks Marco
          Hide
          Jacques Le Roux added a comment -

          Oops, I did not intend to make a blocker link

          Show
          Jacques Le Roux added a comment - Oops, I did not intend to make a blocker link
          Hide
          Jacques Le Roux added a comment -

          Erik Wegner submited a tool to sort labels in OFBIZ-2068. I think we could put it under the Labels Manager

          Show
          Jacques Le Roux added a comment - Erik Wegner submited a tool to sort labels in OFBIZ-2068 . I think we could put it under the Labels Manager
          Hide
          Marco Risaliti added a comment -

          I also like to change the name of this tool to "Label Manager" and implements some new features but I didn't know when I get the time to complete those steps:

          • change the name from Labels Info to Label Manager
          • add the standard Find collapsile/expand features to this new tool
          • add the possibility to add new labels directly from Label Manager
          • add the possibility to write the new inserted label into the corresponding UiLabels xml file
          • check if it's possible to see the new inserted labels without restarting OFBiz

          Thanks for your good ideas
          Marco

          Show
          Marco Risaliti added a comment - I also like to change the name of this tool to "Label Manager" and implements some new features but I didn't know when I get the time to complete those steps: change the name from Labels Info to Label Manager add the standard Find collapsile/expand features to this new tool add the possibility to add new labels directly from Label Manager add the possibility to write the new inserted label into the corresponding UiLabels xml file check if it's possible to see the new inserted labels without restarting OFBiz Thanks for your good ideas Marco
          Hide
          Ashish Vijaywargiya added a comment -

          "Label Manager" is better name for this new tool.

          Thanks Bruno.


          Ashish

          Show
          Ashish Vijaywargiya added a comment - "Label Manager" is better name for this new tool. Thanks Bruno. – Ashish
          Hide
          Erwan de FERRIERES added a comment -

          Very nice improvements !

          A last question, do you think that modifying the labels in this interface will be possible, and make them usable without restarting the server ?

          Once again, well done !


          Erwan

          Show
          Erwan de FERRIERES added a comment - Very nice improvements ! A last question, do you think that modifying the labels in this interface will be possible, and make them usable without restarting the server ? Once again, well done ! – Erwan
          Hide
          Ashish Vijaywargiya added a comment -

          Hello Marco,

          Thanks for introducing this tool.
          I liked your contribution ...

          Can we think about a good name for this tool ?
          Like :- "Label Analyzer" or "Label Modifier" ...or may be some better name ?


          Ashish

          Show
          Ashish Vijaywargiya added a comment - Hello Marco, Thanks for introducing this tool. I liked your contribution ... Can we think about a good name for this tool ? Like :- "Label Analyzer" or "Label Modifier" ...or may be some better name ? – Ashish
          Hide
          Marco Risaliti added a comment -

          Hi Bruno and Erwan,

          I add some of your requests into the new patch that I have uploaded now.

          Thanks
          Marco

          Show
          Marco Risaliti added a comment - Hi Bruno and Erwan, I add some of your requests into the new patch that I have uploaded now. Thanks Marco
          Hide
          Marco Risaliti added a comment -

          Screenshot of the new searching form on labels info.

          Show
          Marco Risaliti added a comment - Screenshot of the new searching form on labels info.
          Hide
          Marco Risaliti added a comment -

          I add some filters criteria (by key, component, file name, locale).

          Show
          Marco Risaliti added a comment - I add some filters criteria (by key, component, file name, locale).
          Hide
          Erwan de FERRIERES added a comment -

          Hi,

          From the screenshot you've added, maybe one of the filters would be the component ?
          What do you think ?


          Erwan

          Show
          Erwan de FERRIERES added a comment - Hi, From the screenshot you've added, maybe one of the filters would be the component ? What do you think ? – Erwan
          Hide
          Bruno Busco added a comment -

          Hi Marco,
          thank you very much for this tool. It looks really promising and I am sure it will open the road to a very usefull feature into OFBiz.

          I started testing your patch and I think that a sort of pagination and search filter would allow a much greater usability.
          At the moment the page takes too much time to load.
          What do you think?
          -Bruno

          Show
          Bruno Busco added a comment - Hi Marco, thank you very much for this tool. It looks really promising and I am sure it will open the road to a very usefull feature into OFBiz. I started testing your patch and I think that a sort of pagination and search filter would allow a much greater usability. At the moment the page takes too much time to load. What do you think? -Bruno
          Hide
          Marco Risaliti added a comment -

          That's a screenshot of the labels info form.

          Show
          Marco Risaliti added a comment - That's a screenshot of the labels info form.
          Hide
          Marco Risaliti added a comment -

          Second patch tha replace the first one and now it can be visible also the extended locales (example pt_BR).

          Show
          Marco Risaliti added a comment - Second patch tha replace the first one and now it can be visible also the extended locales (example pt_BR).

            People

            • Assignee:
              Marco Risaliti
              Reporter:
              Marco Risaliti
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved:

                Development