OFBiz
  1. OFBiz
  2. OFBIZ-205

CustomerEvents.xml & WorkflowMapProcessor and not localized

    Details

      Description

      CustomerEvents.xml & WorkflowMapProcessor and not localized, they contains hardcoded messages in english.
      This patch contains solve this issue and contains also same changes due to wrong translation in Italian that I have already included in the patch for issue OFBIZ-179 but not still commit.
      Once you have tested and commit this patch you can also close the old-jira issue OFBIZ-486/OFBIZ-487.

      Thanks
      Marco

        Activity

        Hide
        Jacques Le Roux added a comment -

        Hi Marco,

        How have you planned to manage the "wrong translation in Italian" ? Does this mean that this patch must be applied after OFBIZ-179 ?

        Marco I think that it will be better not to mix i18n and i10n with other changes as much as possible. You will thus avoid these kind of problems.

        Jacques

        Show
        Jacques Le Roux added a comment - Hi Marco, How have you planned to manage the "wrong translation in Italian" ? Does this mean that this patch must be applied after OFBIZ-179 ? Marco I think that it will be better not to mix i18n and i10n with other changes as much as possible. You will thus avoid these kind of problems. Jacques
        Hide
        Marco Risaliti added a comment -

        Hi Jacques,

        This wrong translation in Italian are already included into this patch they are only a few and they are also included in another patch for issue OFBIZ-179 but you have not to wait that this patchh has been committed.
        The two patches shares only EcommerceUiLabels.properties & EcommerceUiLabels_it.properties and this patch has also new labels specific for this issue.
        I'm hoping that this can be commit without problems to you.

        Thanks
        Marco

        Show
        Marco Risaliti added a comment - Hi Jacques, This wrong translation in Italian are already included into this patch they are only a few and they are also included in another patch for issue OFBIZ-179 but you have not to wait that this patchh has been committed. The two patches shares only EcommerceUiLabels.properties & EcommerceUiLabels_it.properties and this patch has also new labels specific for this issue. I'm hoping that this can be commit without problems to you. Thanks Marco
        Hide
        Jacques Le Roux added a comment -

        Marco,

        Yes but it would better then to extract EcommerceUiLabels.properties & EcommerceUiLabels_it.properties from the OFBIZ-179 patch. Because else there is chance that there will be conflicts when patching from OFBIZ-179.

        Anyway, I already commited this in rev 440990.

        To be franck, I only reviewed it but had not enough time to test. I suppose you did.

        Thanks

        Show
        Jacques Le Roux added a comment - Marco, Yes but it would better then to extract EcommerceUiLabels.properties & EcommerceUiLabels_it.properties from the OFBIZ-179 patch. Because else there is chance that there will be conflicts when patching from OFBIZ-179 . Anyway, I already commited this in rev 440990. To be franck, I only reviewed it but had not enough time to test. I suppose you did. Thanks
        Hide
        Marco Risaliti added a comment -

        Hi Jacques,

        thanks a lot for you work.
        Is it possible for you to close also the old-jira issue OFBIZ-486 and OFBIZ-487, those are related to the same problems resolved with this patch.

        Thanks a lot
        Marco

        Show
        Marco Risaliti added a comment - Hi Jacques, thanks a lot for you work. Is it possible for you to close also the old-jira issue OFBIZ-486 and OFBIZ-487 , those are related to the same problems resolved with this patch. Thanks a lot Marco
        Hide
        Jacques Le Roux added a comment -

        Yes Marco,

        Thanks for the reminder ;o)

        Show
        Jacques Le Roux added a comment - Yes Marco, Thanks for the reminder ;o)

          People

          • Assignee:
            Unassigned
            Reporter:
            Marco Risaliti
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development