OFBiz
  1. OFBiz
  2. OFBIZ-1948

The ecommerce.css file should be moved to /applications/ecommerce

    Details

    • Type: Improvement Improvement
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: None
    • Fix Version/s: None
    • Labels:
      None

      Description

      In order to have the framework not dependent from applications

        Issue Links

          Activity

          Hide
          Adrian Crum added a comment -

          This has been proposed in the past and rejected. The CSS files and other static content are kept in a single folder so that it can be hosted remotely.

          Show
          Adrian Crum added a comment - This has been proposed in the past and rejected. The CSS files and other static content are kept in a single folder so that it can be hosted remotely.
          Hide
          BJ Freeman added a comment -

          Frame work is not dependent on ecommerce.css.
          but the Ecommerce component is dependent on the Frame work.
          that is the purpose of the framework.

          Show
          BJ Freeman added a comment - Frame work is not dependent on ecommerce.css. but the Ecommerce component is dependent on the Frame work. that is the purpose of the framework.
          Hide
          Bruno Busco added a comment -

          Adrian,
          what about the way we are thinking the Visual Themes? (OFBIZ-1885)
          They, at the moment, to be pluggable are defined like a hot-deploy component with its own webapp that serves the .css, gifs and all related stuff.
          I understood we where ok on this.

          Show
          Bruno Busco added a comment - Adrian, what about the way we are thinking the Visual Themes? ( OFBIZ-1885 ) They, at the moment, to be pluggable are defined like a hot-deploy component with its own webapp that serves the .css, gifs and all related stuff. I understood we where ok on this.
          Hide
          Bruno Busco added a comment -

          BJ,
          framework is not dependent on ecommerce.css, I see it, but the file is located in the framework folder tree.
          So, when the framework will be released by itself we will have the ecommerce.css installed even if someone is not interested and has not installed the ecommerce application.
          Or, may be, I am missim something?

          Show
          Bruno Busco added a comment - BJ, framework is not dependent on ecommerce.css, I see it, but the file is located in the framework folder tree. So, when the framework will be released by itself we will have the ecommerce.css installed even if someone is not interested and has not installed the ecommerce application. Or, may be, I am missim something?
          Hide
          BJ Freeman added a comment -

          to carry that logic forward
          someone may not use Shark component, but it goes with the framework.

          Show
          BJ Freeman added a comment - to carry that logic forward someone may not use Shark component, but it goes with the framework.
          Show
          Adrian Crum added a comment - http://mail-archives.apache.org/mod_mbox/ofbiz-dev/200708.mbox/%3c46C5DB43.4020505@undersunconsulting.com%3e
          Hide
          Bruno Busco added a comment -

          Could we think to have all application-related images and css in a images subfolder?

          Something like this:

          \framework\images\webapp\images
          for framework images and css

          \framework\images\webapp\images\ecommerce
          for ecommerce application images and css

          \framework\images\webapp\images\catalog
          for catalog application images and css

          and so on...

          this will let the framework installation and packaging script to copy only the files in the \framework\images\webapp\images
          and all other application installation add their related subfolder.

          Show
          Bruno Busco added a comment - Could we think to have all application-related images and css in a images subfolder? Something like this: \framework\images\webapp\images for framework images and css \framework\images\webapp\images\ecommerce for ecommerce application images and css \framework\images\webapp\images\catalog for catalog application images and css and so on... this will let the framework installation and packaging script to copy only the files in the \framework\images\webapp\images and all other application installation add their related subfolder.
          Hide
          Bruno Busco added a comment -

          What do you think about?
          Is it a feasible solution in order to have independance of framework from applications?

          Show
          Bruno Busco added a comment - What do you think about? Is it a feasible solution in order to have independance of framework from applications?
          Hide
          Jacques Le Roux added a comment -

          I agree with David ( Akamai, CacheFly) from the link Adrian provided above. But should we see css has static content ? I don't think so. So I think last Bruno's proposition is valid and should be done... one day or another... to ensure Framework independence

          Show
          Jacques Le Roux added a comment - I agree with David ( Akamai, CacheFly) from the link Adrian provided above. But should we see css has static content ? I don't think so. So I think last Bruno's proposition is valid and should be done... one day or another... to ensure Framework independence
          Hide
          David E. Jones added a comment -

          About the framework independence... you may be thinking of it backwards.

          The applications are supposed to depend on the framework, but the framework must not depend on the applications. If the file exists in the framework and ecommerce (which really should be specialpurpose, BTW, and not in applications... and we might want to consider moving that before our next release branch) points to it that's fine. If it exists in ecommerce and there is some reference to it in the framework, that's bad.

          Show
          David E. Jones added a comment - About the framework independence... you may be thinking of it backwards. The applications are supposed to depend on the framework, but the framework must not depend on the applications. If the file exists in the framework and ecommerce (which really should be specialpurpose, BTW, and not in applications... and we might want to consider moving that before our next release branch) points to it that's fine. If it exists in ecommerce and there is some reference to it in the framework, that's bad.
          Hide
          Jacques Le Roux added a comment -

          Yes, I totally agree, "to ensure Framework independence" was a wrong statement. It just that it would be easier to have them separated as Bruno suggested.

          Show
          Jacques Le Roux added a comment - Yes, I totally agree, "to ensure Framework independence" was a wrong statement. It just that it would be easier to have them separated as Bruno suggested.

            People

            • Assignee:
              Unassigned
              Reporter:
              Bruno Busco
            • Votes:
              0 Vote for this issue
              Watchers:
              0 Start watching this issue

              Dates

              • Created:
                Updated:

                Development