OFBiz
  1. OFBiz
  2. OFBIZ-18

Added sequenceNum to ProductFeatureGroupAppl

    Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Fixed
    • Affects Version/s: SVN trunk
    • Fix Version/s: None
    • Component/s: product
    • Labels:
      None

      Description

      Hi

      I have added a sequenceNum field to the ProductFeatureGroupAppl entity, and updated the EditFeatureGroupAppls.bsh to load the sequenceNum's when using:

      Product>Features>Add Product Feature From Category or Group>

      This way if a group of features always need to be sorted the same way you don't need to enter the sequence every time you add the feature group to a product.

      Also see:
      http://lists.ofbiz.org/pipermail/dev/2006-June/011325.html

      1. ProdGroupFeatApplSeq.patch
        12 kB
        Scott Gray
      2. ProdGroupFeatApplSeq_0906.patch
        24 kB
        Scott Gray

        Activity

        Hide
        Scott Gray added a comment -

        Attached patch details:

        -Added sequenceNum to ProductFeatureGroupAppl entity
        -Converted the main form in EditFeatureGroupAppls to widgets
        -Added ui support for the new field
        -Amended EditFeatureGroupAppls.bsh to load the new sequenceNums (my first (minor)attempt with beanshell so i'm not sure if this was the best way to do it?)

        Thanks
        Scott

        Show
        Scott Gray added a comment - Attached patch details: -Added sequenceNum to ProductFeatureGroupAppl entity -Converted the main form in EditFeatureGroupAppls to widgets -Added ui support for the new field -Amended EditFeatureGroupAppls.bsh to load the new sequenceNums (my first (minor)attempt with beanshell so i'm not sure if this was the best way to do it?) Thanks Scott
        Hide
        Scott Gray added a comment -

        Hi Si

        If you haven't started looking at this yet, could you hold fire please. I've been using the product feature groups some more and i wanted to make a couple more changes:

        1. Switch the product feature group applications form to a use-row-submit so that all sequenceNums can be updated in one go.
        2. Change the Apply Features From Category form at the bottom of the screen to also use the row-submit to apply all the selected features in one hit.

        Thanks
        Scott

        Show
        Scott Gray added a comment - Hi Si If you haven't started looking at this yet, could you hold fire please. I've been using the product feature groups some more and i wanted to make a couple more changes: 1. Switch the product feature group applications form to a use-row-submit so that all sequenceNums can be updated in one go. 2. Change the Apply Features From Category form at the bottom of the screen to also use the row-submit to apply all the selected features in one hit. Thanks Scott
        Hide
        Jacques Le Roux added a comment -

        Scott,

        I vote for !

        Show
        Jacques Le Roux added a comment - Scott, I vote for !
        Hide
        Scott Gray added a comment -

        Here's the latest patch, with the changes mentioned above

        Thanks
        Scott

        Show
        Scott Gray added a comment - Here's the latest patch, with the changes mentioned above Thanks Scott
        Hide
        Si Chen added a comment -

        Thanks very much. I committed it in r 7781. Can you check if I got all the files correctly? One file which I did not commit was StoreScreens.xml - it seems to refer to files which were not there, and that screen did not work when I committed.

        Show
        Si Chen added a comment - Thanks very much. I committed it in r 7781. Can you check if I got all the files correctly? One file which I did not commit was StoreScreens.xml - it seems to refer to files which were not there, and that screen did not work when I committed.
        Hide
        Scott Gray added a comment -

        Hi Si

        Sorry i haven't replied sooner, i missed the email. The StoreScreens.xml shouldn't have been in there, I thought I had taken out all of the references to another patch I was working on at the time, sorry about that.

        Thanks for the quick commit
        Scott

        Show
        Scott Gray added a comment - Hi Si Sorry i haven't replied sooner, i missed the email. The StoreScreens.xml shouldn't have been in there, I thought I had taken out all of the references to another patch I was working on at the time, sorry about that. Thanks for the quick commit Scott

          People

          • Assignee:
            Si Chen
            Reporter:
            Scott Gray
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development