OFBiz
  1. OFBiz
  2. OFBIZ-1690

Set widget default url encode value to true

    Details

    • Type: Bug Bug
    • Status: Open
    • Priority: Minor Minor
    • Resolution: Unresolved
    • Affects Version/s: Release 4.0, Trunk
    • Fix Version/s: None
    • Component/s: framework
    • Labels:
      None
    • Sprint:
      Bug Crush Event - 21/2/2015

      Description

      The bug is explained here: http://www.nabble.com/Question-about-ofbiz-url-encoding-to15638660.html#a15638660
      Can someone with framework access commit it please.

      Thanks,
      Bilgin

      1. encode.patch
        5 kB
        Bilgin Ibryam
      2. encode.patch
        2 kB
        Bilgin Ibryam

        Activity

        Bilgin Ibryam created issue -
        Bilgin Ibryam made changes -
        Field Original Value New Value
        Attachment encode.patch [ 12377021 ]
        Hide
        Adrian Crum added a comment -

        Bilgin,

        I'd like to hear more comments on the subject. Your patch only changes the default in the widget's xsd, it doesn't address the scenario where the xsd is not available. To handle that case, the model widgets would have to default the setting to true also. That could break a lot of existing code.

        Show
        Adrian Crum added a comment - Bilgin, I'd like to hear more comments on the subject. Your patch only changes the default in the widget's xsd, it doesn't address the scenario where the xsd is not available. To handle that case, the model widgets would have to default the setting to true also. That could break a lot of existing code.
        Bilgin Ibryam made changes -
        Attachment encode.patch [ 12377045 ]
        Hide
        Bilgin Ibryam added a comment -

        Adrian,

        I updated the patch according to your remarks.
        Can you tell me what kind of existing code this patch could break?

        Thanks for your review and comments!

        Show
        Bilgin Ibryam added a comment - Adrian, I updated the patch according to your remarks. Can you tell me what kind of existing code this patch could break? Thanks for your review and comments!
        Hide
        Adrian Crum added a comment -

        Bilgin,

        My concern is with external links - will the jsessionid parameter get appended to them also.

        Show
        Adrian Crum added a comment - Bilgin, My concern is with external links - will the jsessionid parameter get appended to them also.
        Hide
        Bilgin Ibryam added a comment -

        Adrian you are right,
        but setting encode attribute to false for external links should solve this issue?

        Show
        Bilgin Ibryam added a comment - Adrian you are right, but setting encode attribute to false for external links should solve this issue?
        Gavin made changes -
        Workflow jira [ 12424995 ] OFbiz Workflow [ 12505677 ]
        Jacopo Cappellato made changes -
        Affects Version/s Release 4.0 [ 12314978 ]
        Affects Version/s Release Branch 4.0 [ 12312469 ]
        Jacopo Cappellato made changes -
        Fix Version/s Trunk [ 12311928 ]
        Jacopo Cappellato made changes -
        Fix Version/s Release Branch 4.0 [ 12312469 ]
        Sharan Foga made changes -
        Sprint Bug Crush Event - 21/2/2015 [ 91 ]
        Sharan Foga made changes -
        Rank Ranked higher
        Sharan Foga made changes -
        Rank Ranked higher
        Sharan Foga made changes -
        Rank Ranked higher

          People

          • Assignee:
            Unassigned
            Reporter:
            Bilgin Ibryam
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:

              Development

                Agile