Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-1592

Database spikes lead to permanent user privilege loss

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Critical
    • Resolution: Fixed
    • Trunk
    • Trunk
    • framework
    • None

    Description

      We found a critical bug in OFBiz security where temporary database spikes can lead to permanent privilege loss for users trying to log in or do something during the spike. The loss lasts until a cache refresh or a restart. A symptom is customers not being able to log in to do a checkout, not being able to create new accounts, and backend users not being able to perform their duties due to privilege loss.

      The reason for the bug was found to be in the caching of UserLoginSecurityGroup in OFBizSecurity. When there's an SQL exception, such as during a lag spike, an empty list will be stored in the cache. Subsequent security checks will retrieve this empty list and never ask the database again what the actual security groups are.

      Attachments

        1. permanent-security-loss.patch
          2 kB
          Leon Torres
        2. OFBizSecurity.patch
          1 kB
          Adrian Crum

        Activity

          People

            jonesde David E. Jones
            leontorres Leon Torres
            Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: