[OFBIZ-12717] Eca createPaymentFromOrder failed if payment already exist

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 22.01.01
• Fix Version/s: 22.01.01
• Component/s: accounting
• Assignee: Jacques Le Roux
• Reporter: Marie-Aline Pantais
• Created: 02/Dec/22 14:52
• Updated: 04/Dec/22 09:28
• Resolved: 04/Dec/22 09:28

Description

Groovy migration

Before migration  was

 

<if-not-empty field="orderPaymentPrefAndPayments">
  <log level="info" message="Payment not created for order ${orderHeader.orderId}, at least a single payment already exists"/>
  <return/>
</if-not-empty> )

 

After migration is

 

if (from("OrderPaymentPrefAndPayment")
        .where([EntityCondition.makeCondition("orderId", orderHeader.orderId),
                EntityCondition.makeCondition("statusId", EntityOperator.NOT_EQUAL, "PAYMENT_CANCELLED")])
        .queryCount() > 1) {
    return error("Payment not created for order ${orderHeader.orderId}, at least a single payment already exists")
}

queryCount() > 1 had to be queryCount() > 0
return error had to be return failure