[OFBIZ-12660] Wrong Less file URL when locale is tr-TR

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: 18.12.06, 22.01.01, Upcoming Branch
• Fix Version/s: 22.01.01
• Component/s: themes
• Assignee: Jacques Le Roux
• Reporter: Florian Motteau
• Created: 27/Jun/22 13:30
• Updated: 10/Aug/22 08:57
• Resolved: 10/Aug/22 08:48

Description

If

• current locale is tr-TR (and most certainly az-AZ, maybe others, where dotless i exists),
• the theme name contains a "i" (`RAINBOWSTONE-SAPHIR` for example),
• the theme uses this line in /template/includes/Header.ftl to generate a link to a Less file (rainbowstone, helveticus, maybe others) :

<link rel="stylesheet/less" href="<@ofbizContentUrl>/helveticus/${visualTheme.visualThemeId?replace("_","-")?lower_case}.less</@ofbizContentUrl>" type="text/css"/>

Then

• the Freemarker `lower_case` function generates dotless i's when lowercasing "I",
• the link to the Less ends up with a 404
• no more styles :/

See turkish-dotless-i-bug.mp4

Leads to fix this

• Find a way to override the current locale for `lower_case` calls (and always use en-EN)
• Do not rely on a locale sensitive function to generate links to style files
• Ban "i" from visual theme names
• more ideas ?

Issue Links

• links to: GitHub Pull Request #521
• links to: Issue on Freemarker project
• links to: Javadoc
• links to: Other related SO post
• links to: Related Baeldung post
• links to: Related SO post