Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-12061

Comment out HideUtilityClassConstructor in checkstyle.xml

    XMLWordPrintableJSON

Details

    • Improvement
    • Status: Closed
    • Major
    • Resolution: Implemented
    • None
    • None
    • None
    • None
    • OFBiz Community Day (Nov 2020)

    Description

      Currently Checkstyle returns 222 occurrences of the message "Utility classes should not have a public or default constructor."

      This is due to https://checkstyle.sourceforge.io/config_design.html#HideUtilityClassConstructor
      I don't think we need to follow the "prevents calls from subclass" suggestion there.

      I rather suggest to comment out the related class in checkstyle.xml:

      ie <!-- <module name="HideUtilityClassConstructor"/> -->

      Then should remain only 280 errors and hopefully most will be easy to fix. At least they will be easier to spot...

      Attachments

        Activity

          People

            jleroux Jacques Le Roux
            jleroux Jacques Le Roux
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: