Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-11350 Checkstyle improvements
  3. OFBIZ-11886

Allow single line statements in checkstyle

    XMLWordPrintableJSON

    Details

    • Type: Sub-task
    • Status: Closed
    • Priority: Major
    • Resolution: Implemented
    • Affects Version/s: None
    • Fix Version/s: Upcoming Branch
    • Component/s: ALL COMPONENTS
    • Labels:
      None
    • Sprint:
      OFBiz Community Day (May 2020), OFBiz Community Day (Aug 2020)

      Description

      We need to add this module in checkstyle.xml

      <module name="NeedBraces">
          <property name="allowSingleLineStatement" value="true"/>
      </module>

      After this, single line statements like:

      if (Debug.verboseOn()) Debug.logVerbose(...)

      Will be considered safe.

        Attachments

        1. OFBIZ-11886.patch
          248 kB
          Suraj Khurana
        2. OFBIZ-11886.patch
          0.6 kB
          Suraj Khurana
        3. OFBIZ-11886-format-LoginServices-checkNewPassword.patch
          31 kB
          Jacques Le Roux
        4. OFBIZ-11886-plugins.patch
          11 kB
          Suraj Khurana

          Activity

            People

            • Assignee:
              surajk Suraj Khurana
              Reporter:
              surajk Suraj Khurana
            • Votes:
              1 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: