[OFBIZ-11740] Handle FileLength Checkstyle rule

• Type: Sub-task
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: Trunk, Upcoming Branch
• Component/s: ALL COMPONENTS
• Assignee: Unassigned
• Reporter: Jacques Le Roux
• Created: 25/May/20 14:04
• Updated: 11/Jan/22 08:48

Description

Hi All,

surajk rightly mentioned directly to me in Slack that we have no FileLength checkstyle rule and the max default is 2000 lines: https://checkstyle.sourceforge.io/config_sizes.html#FileLength

We have some very large Java files in trunk ( see filesLengths.txt) and few (19) are longer than 2000 lines:

    2059 ./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelScreenWidget.java
    2131 ./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartEvents.java
    2581 ./applications/product/src/main/java/org/apache/ofbiz/product/product/ProductSearch.java
    2631 ./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartItem.java
    2643 ./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReturnServices.java
    2662 ./framework/entity/src/main/java/org/apache/ofbiz/entity/GenericDelegator.java
    2676 ./applications/party/src/main/java/org/apache/ofbiz/party/party/PartyServices.java
    2811 ./framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/DatabaseUtil.java
    2953 ./plugins/ebaystore/src/main/java/org/apache/ofbiz/ebaystore/EbayStore.java
    3133 ./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderReadHelper.java
    3433 ./framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
    3638 ./applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
    3712 ./applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java
    3720 ./applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java
    3734 ./applications/product/src/main/java/org/apache/ofbiz/shipment/thirdparty/ups/UpsServices.java
    4417 ./framework/widget/src/main/java/org/apache/ofbiz/widget/model/ModelFormField.java
    5437 ./applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java
    7194 ./applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java

The question is should we increase to hide the issue (19 errors) or try to split those files, if it makes sense in some cases...