Details

      Description

      Hi guys,
      I want to ask what is the purpose of Black list in ofbiz and how should it really work?
      I tried to use it and found that it is not working at all.

      1) First of all we ALWAYS pass the checkBlackList request with success and always go to processpayment request. The reason is in the return value of the checkBlackList event...The applied patch fix this problem.

      2) Is the intend of checkBlackList is preventing from order creation (when someone is in BlackList) or creating the order but preventing from processpayment request, as it is now? Currently the order is created and then we check the black list. if we fail on the black list check we are again in Order Confirmation screen (btw there is no message in the UI saying that there is an error or cannot pass the black list check) but the order is created. If we press again the Create Order button another order is created but we are still in Order Confirmation screen thinking that the order is not created for some reason...The applied patch shows an error message.
      In ecommerce it works better. If we fail on checkOrderBlacklist, then failedBlacklistCheck event changes the order status to rejected, the user login is disabled and there is some info for it on the screen. I can add an event like this for order application, that will change the order status to rejected, without disabling the userlogin, what do you think?

      3)This should be another issue for improvement. There is not a screen or service for populating the black list. How and where should we put such a screen or button for blocking a email, phone, postall address, cc and may be some other types.

      4)A question: How can I add a person (not only his email, or phone but everything) to the OrderBlacklist? Is it correct to add a new Blacklist Type BLACKLIST_PARTY and to add the partyId to the Black list?

      Regards,
      Bilgin Ibryam

      1. blacklist.patch
        4 kB
        Bilgin Ibryam

        Activity

        Gavin made changes -
        Workflow jira [ 12408634 ] OFbiz Workflow [ 12505116 ]
        Bilgin Ibryam made changes -
        Fix Version/s Release Branch 4.0 [ 12312469 ]
        Hide
        Bilgin Ibryam added a comment -

        Committed in 4.0 rev. 612793

        Show
        Bilgin Ibryam added a comment - Committed in 4.0 rev. 612793
        Bilgin Ibryam made changes -
        Fix Version/s Release Branch 4.0 [ 12312469 ]
        Status Open [ 1 ] Closed [ 6 ]
        Resolution Fixed [ 1 ]
        Hide
        Bilgin Ibryam added a comment -

        After a small discussion in dev list, i committed a modified patch in trunk r612767 that fixes the bugs described in point 1 and 2 (and even one more bug caused when using anonymous user login)
        About point 3 there should be another improvement issue.

        Show
        Bilgin Ibryam added a comment - After a small discussion in dev list, i committed a modified patch in trunk r612767 that fixes the bugs described in point 1 and 2 (and even one more bug caused when using anonymous user login) About point 3 there should be another improvement issue.
        Hide
        Bilgin Ibryam added a comment -

        Hi Jacques, Thanks for the reminder.
        I will take care of it, very soon!

        Show
        Bilgin Ibryam added a comment - Hi Jacques, Thanks for the reminder. I will take care of it, very soon!
        Hide
        Jacques Le Roux added a comment -

        Hi Bilgin,

        You are now able to commit it ;o) Maybe your question could have more impact on dev ML ?

        Show
        Jacques Le Roux added a comment - Hi Bilgin, You are now able to commit it ;o) Maybe your question could have more impact on dev ML ?
        Jacopo Cappellato made changes -
        Assignee Jacopo Cappellato [ jacopoc ] Bilgin Ibryam [ bibryam ]
        Jacopo Cappellato made changes -
        Assignee Jacopo Cappellato [ jacopoc ]
        Bilgin Ibryam made changes -
        Field Original Value New Value
        Attachment blacklist.patch [ 12361989 ]
        Hide
        Bilgin Ibryam added a comment -

        this patch fixes point 1 and some part of point 2

        Show
        Bilgin Ibryam added a comment - this patch fixes point 1 and some part of point 2
        Bilgin Ibryam created issue -

          People

          • Assignee:
            Bilgin Ibryam
            Reporter:
            Bilgin Ibryam
          • Votes:
            1 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development