[OFBIZ-11441] createMissingCategoryAndProductAltUrls service misses a transaction

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 17.12.02, 18.12.01
• Component/s: framework
• Assignee: Jacques Le Roux
• Reporter: Jacques Le Roux
• Created: 05/Mar/20 08:07
• Updated: 05/Mar/20 09:18
• Resolved: 05/Mar/20 09:18

Description

I'm not sure if this is always an issue, but getting to CreateSeoProdCatalog throws this error in log:

2020-03-04 17:11:50,610 |jsse-nio-9443-exec-6 |ControlServlet                |T| [[[catalog::CreateSeoProdCatalog (Domain:https://localhost)] Request Begun, encoding=[UTF-8]- total:0.0,since last(Begin):0.0]]
2020-03-04 17:11:50,640 |jsse-nio-9443-exec-6 |GenericDelegator              |E| ERROR: Cannot do a find that returns an EntityListIterator with no transaction in place. Wrap this call in a transaction.
java.lang.Exception: Stack Trace
        at org.apache.ofbiz.entity.GenericDelegator.find(GenericDelegator.java:1523) [main/:?]
        at org.apache.ofbiz.entity.util.EntityQuery.queryIterator(EntityQuery.java:397) [main/:?]
        at org.apache.ofbiz.entity.util.EntityQuery.getFieldList(EntityQuery.java:533) [main/:?]
        at org.apache.ofbiz.entity.util.EntityQuery$getFieldList$6.call(Unknown Source) [main/:?]
        at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCall(CallSiteArray.java:47) [groovy-2.5.8.jar:2.5.8]
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:115) [groovy-2.5.8.jar:2.5.8]
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.call(AbstractCallSite.java:127) [groovy-2.5.8.jar:2.5.8]
        at CatalogServices.createMissingCategoryAltUrlInline(CatalogServices.groovy:403) [script:?]
        at CatalogServices$createMissingCategoryAltUrlInline.callCurrent(Unknown Source) [script:?]
        at org.codehaus.groovy.runtime.callsite.CallSiteArray.defaultCallCurrent(CallSiteArray.java:51) [groovy-2.5.8.jar:2.5.8]
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:156) [groovy-2.5.8.jar:2.5.8]
        at org.codehaus.groovy.runtime.callsite.AbstractCallSite.callCurrent(AbstractCallSite.java:168) [groovy-2.5.8.jar:2.5.8]
        at CatalogServices.createMissingCategoryAndProductAltUrls(CatalogServices.groovy:306) [script:?]
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method) ~[?:1.8.0_202]
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) ~[?:1.8.0_202]
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) ~[?:1.8.0_202]
        at java.lang.reflect.Method.invoke(Method.java:498) ~[?:1.8.0_202]
        at org.codehaus.groovy.reflection.CachedMethod.invoke(CachedMethod.java:101) [groovy-2.5.8.jar:2.5.8]
        at groovy.lang.MetaMethod.doMethodInvoke(MetaMethod.java:323) [groovy-2.5.8.jar:2.5.8]
        at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1217) [groovy-2.5.8.jar:2.5.8]
        at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:1041) [groovy-2.5.8.jar:2.5.8]
        at groovy.lang.MetaClassImpl.invokeMethod(MetaClassImpl.java:821) [groovy-2.5.8.jar:2.5.8]
        at groovy.lang.GroovyObjectSupport.invokeMethod(GroovyObjectSupport.java:44) [groovy-2.5.8.jar:2.5.8]
        at groovy.lang.Script.invokeMethod(Script.java:77) [groovy-2.5.8.jar:2.5.8]
        at org.apache.ofbiz.service.engine.GroovyEngine.runSync(GroovyEngine.java:110) [main/:?]

There is no others impacts. Maybe it was "broken by" OFBIZ-10808

You can reproduce by getting to Catalogs in catalog webapp, selecting a catalog there and using "Create SEO category/products"