[OFBIZ-11430] getDimensionIdFromNaturalKey should return '_NF_' when no Dimension record found

• Type: Sub-task
• Status: Patch Available
• Priority: Major
• Resolution: Unresolved
• Affects Version/s: Trunk, Upcoming Branch
• Component/s: bi
• Labels: refactoring
• Assignee: Pierre Smits
• Reporter: Pierre Smits
• Created: 01/Mar/20 09:46
• Updated: 11/Jan/22 08:48

Description

Currently the 'getDimensionIdFromNaturalKey' function in DimensionServices.java returns the DimensionId when found with following code excerpt

if (UtilValidate.isNotEmpty(lastDimensionValue)) {
            resultMap.put("dimensionId", lastDimensionValue.getString("dimensionId"));
        }
return resultMap;

And when not found it returns an empty result, leaving the using function upstream to set the '_NF' value.

The 'getDimensionIdFromNaturalKey' function should return the 'NF' value when no matching dimensionId is found.

This would simplify the upstream code.