Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-1133

Unescaped quotes break lookup screens functionality

    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Minor
    • Resolution: Fixed
    • Release Branch 4.0, Trunk
    • Trunk
    • None
    • None

    Description

      Example, it's impossible to select product in LookupProductAndPrice (used in EditQuoteItem) if product internal name contains quotas or apostrophe. The reason is obvious. The script "javascript:set_values('10112', 'Test product - Monitor 17", gray')" has error, unnecessary quote. I think the problem is common.

      Simple solution is to remove second parameter. There is no field internalName in opener form. But it's feckless way.

      Have anybody suggestion how rightly correct this problem? Modify HtmlFormRenderer?

      Please explain me why we don't store escaped string in database. This is generally accepted solution.

      Attachments

        1. patch_ofbiz_LookupProductAndPrice-branch.diff
          1 kB
          Christian Geisert
        2. patch_ofbiz_LookupProductAndPrice-trunk.diff
          1 kB
          Christian Geisert

        Activity

          People

            jacopoc Jacopo Cappellato
            redcat Oleg Andreyev
            Votes:
            2 Vote for this issue
            Watchers:
            1 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved: