[OFBIZ-11167] Use Codenarc to test Groovy code

• Type: New Feature
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Fix Version/s: 22.01.01, Upcoming Branch
• Component/s: framework
• Assignee: Gil Portenseigne
• Reporter: Jacques Le Roux
• Created: 24/Aug/19 07:56
• Updated: 19/Jul/23 22:35
• Resolved: 12/Apr/23 15:37

Description

Thread of community discussion about the rules to implement : https://www.mail-archive.com/search?l=dev%40ofbiz.apache.org&q=subject:%22Codenarc+integration%2C+rules+to+use.%22&o=newest&f=1

 

Now that we use Groovy more and more, I think we should really have a look a Codenarc
https://docs.gradle.org/current/userguide/codenarc_plugin.html

We already discussed it at https://markmail.org/message/uigcpnxqgizhd2oi and https://markmail.org/message/rp6njoiohkkiodbe

We know it's a crucial task but not an easy but rather a long term one

Here are some interesting links (before I delete my FF tabs group about it)
http://codenarc.sourceforge.net/codenarc-other-tools-frameworks.html
http://codenarc.sourceforge.net/codenarc-creating-ruleset.html
https://github.com/gradle/gradle/tree/master/config
https://stackoverflow.com/questions/14358471/how-to-generate-codenarc-report-for-main-and-test-classes-using-different-rule-s
https://mrhaki.blogspot.com/2011/01/gradle-goodness-use-groovy-ruleset-file.html

Issue Links

• breaks: OFBIZ-12801 Error at CommunicationEventServices.groovy:489 due to OFBIZ-11167
• breaks: OFBIZ-12838 IndexOutOfBoundsException occured while placing order

Sub-Tasks

• Create IDE profiles for groovy styling: Open