[OFBIZ-11029] Issue in function getVariantSelectionFeatures of ProductWorker.java

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Release Branch 16.11, Release Branch 18.12, Release Branch 17.12, Trunk
• Fix Version/s: 16.11.06, 17.12.01, 18.12.01
• Component/s: product
• Labels: product variant
• Assignee: Aditya Sharma
• Reporter: Denglong Zhou
• Created: 14/May/19 07:16
• Updated: 16/May/19 12:46
• Resolved: 15/May/19 05:23

Description

//代码占位符
public static List<GenericValue> getVariantSelectionFeatures(GenericValue variantProduct) {
if (!"Y".equals(variantProduct.getString("isVariant"))) {
return null;
}
GenericValue virtualProduct = ProductWorker.getParentProduct(variantProduct.getString("productId"), variantProduct.getDelegator());
if (virtualProduct == null || !"Y".equals(virtualProduct.getString("productId"))) {
return null;
}

for the above coding, i guess the part colored by red should be the following,

//代码占位符
if (virtualProduct == null || !"Y".equals(virtualProduct.getString("isVirtual"))) {

thanks!