[OFBIZ-11021] The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Release Branch 18.12, Trunk
• Fix Version/s: 18.12.01
• Component/s: order
• Sprint: OFBiz Community Day (May 2019)
• Assignee: Suraj Khurana
• Reporter: Pawan Verma
• Created: 11/May/19 06:22
• Updated: 25/May/19 06:14
• Resolved: 25/May/19 06:14

Description

The drop-ship process behaves incorrectly when a combination of drop-ship and non-drop-ship products are added into the cart.
 
Suppose we have two items in the cart:

1. The first item is drop-shippable.
2. The second item is not drop-shippable.

For the first item, the implementation works fine.
For the second item, this is not working correctly.
 
For drop shipment process, cart method 'createDropShipGroups' decides RequirementMethodEnumId in the order of property set at ProductStore -> ProductFacility -> Product which work fine in case of all drop-ship products and if the drop-ship product(s) is added last in the cart.
 
The issue I found is that if a combination of a dropship and non-drop ship products are added into the cart and the non-drop shippable product(s) is added after the drop shippable product(s) then the non-drop-shippable products also considered as drop-shippable.