[OFBIZ-10724] Refactor ServiceUtil.isSuccess(), isError() and isFailure() methods

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Trunk
• Component/s: framework
• Assignee: Aditya Sharma
• Reporter: Aditya Sharma
• Created: 20/Dec/18 09:29
• Updated: 11/Jan/22 09:36
• Resolved: 22/Dec/18 10:48

Description

Following lines for isSuccess():

if (ServiceUtil.isError(results) || ServiceUtil.isFailure(results)) { 
return false; 
} 
return true;

can be changed to

return !(ServiceUtil.isError(results) || ServiceUtil.isFailure(results));

Following lines for isFailure():

if (results == null || results.get(ModelService.RESPONSE_MESSAGE) == null) {
    return false;
}
return ModelService.RESPOND_FAIL.equals(results.get(ModelService.RESPONSE_MESSAGE));

can be changed to

return !(results == null || results.get(ModelService.RESPONSE_MESSAGE) == null) &&
        ModelService.RESPOND_FAIL.equals(results.get(ModelService.RESPONSE_MESSAGE));

Following lines for isError():

 

if (results == null || results.get(ModelService.RESPONSE_MESSAGE) == null) {
    return false;
}
return ModelService.RESPOND_ERROR.equals(results.get(ModelService.RESPONSE_MESSAGE));

can be changed to

return !(results == null || results.get(ModelService.RESPONSE_MESSAGE) == null) &&
        ModelService.RESPOND_ERROR.equals(results.get(ModelService.RESPONSE_MESSAGE));