[OFBIZ-10696] ConcurrentModificationException in ShoppingCart.cleanUpShipGroups

• Type: Bug
• Status: Closed
• Priority: Major
• Resolution: Fixed
• Affects Version/s: Trunk
• Fix Version/s: 16.11.06, 17.12.01
• Component/s: order
• Assignee: Jacques Le Roux
• Reporter: Danny Trunk
• Created: 06/Dec/18 09:02
• Updated: 08/Dec/18 18:20
• Resolved: 06/Dec/18 16:22

Description

java.util.ConcurrentModificationException: null
        at java.util.LinkedList$ListItr.checkForComodification(LinkedList.java:966) ~[?:1.8.0_181]
        at java.util.LinkedList$ListItr.next(LinkedList.java:888) ~[?:1.8.0_181]
        at org.apache.ofbiz.order.shoppingcart.ShoppingCart.cleanUpShipGroups(ShoppingCart.java:2199) ~[ofbiz.jar:?]

There's a for-loop over shipInfo and a call to clear inside this loop which leads to a ConcurrentModificationException: https://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java?view=markup#l2251