[OFBIZ-10593] ‘EntityConditionVisitor’ is a confused visitor pattern

• Type: Improvement
• Status: Closed
• Priority: Major
• Resolution: Implemented
• Affects Version/s: Trunk
• Fix Version/s: 18.12.01
• Assignee: Gil Portenseigne
• Reporter: Mathieu Lirzin (Inactive)
• Created: 03/Oct/18 14:29
• Updated: 07/Oct/19 18:41
• Resolved: 13/Oct/18 19:52

Description

EntityConditionVisitor interface is supposed to implement the visitor pattern which supposes a set of classes meant to be visited using an accept method and a visitor with multiple visit method overloads (one for each visited class).

Currently EntityConditionVisitor contains both accept and visit methods which make no sense

public interface EntityConditionVisitor {
    <T> void visit(T obj);
    <T> void accept(T obj);
    void acceptObject(Object obj);
    void acceptEntityCondition(EntityCondition condition);
    <T extends EntityCondition> void acceptEntityJoinOperator(EntityJoinOperator op, List<T> conditions);
    <L,R,T> void acceptEntityOperator(EntityOperator<L, R, T> op, L lhs, R rhs);
    <L,R> void acceptEntityComparisonOperator(EntityComparisonOperator<L, R> op, L lhs, R rhs);
    void acceptEntityConditionValue(EntityConditionValue value);
    void acceptEntityFieldValue(EntityFieldValue value);

    void acceptEntityExpr(EntityExpr expr);
    <T extends EntityCondition> void acceptEntityConditionList(EntityConditionList<T> list);
    void acceptEntityFieldMap(EntityFieldMap fieldMap);
    void acceptEntityConditionFunction(EntityConditionFunction func, EntityCondition nested);
    <T extends Comparable<?>> void acceptEntityFunction(EntityFunction<T> func);
    void acceptEntityWhereString(EntityWhereString condition);

    void acceptEntityDateFilterCondition(EntityDateFilterCondition condition);
}

this confusion is visible in the EntityCondition which has both a visit and an accept method, even if it is only supposed to accept a visitor.

Issue Links

• blocks: OFBIZ-10579 Date filtered queries with caching should be restricted to cache