[OFBIZ-10571] [FB] Package org.apache.ofbiz.minilang

• Type: Sub-task
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: Trunk
• Component/s: ALL APPLICATIONS
• Assignee: Suraj Khurana
• Reporter: Girish Vasmatkar
• Created: 18/Sep/18 09:07
• Updated: 11/Jan/22 09:37
• Resolved: 26/Feb/20 10:38

Description

• Should be a static inner class

This class is an inner class, but does not use its embedded reference to the object which created it.  This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary.  If possible, the class should be made static.

Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC

org.apache.ofbiz.minilang.method.callops.CallService**

 

• Could be refactored into a named static inner class

This class is an inner class, but does not use its embedded reference to the object which created it.  This reference makes the instances of the class larger, and may keep the reference to the creator object alive longer than necessary.  If possible, the class should be made into a static inner class. Since anonymous inner classes cannot be marked as static, doing this will require refactoring the inner class so that it is a named inner class.

Bug kind and pattern: SIC - SIC_INNER_SHOULD_BE_STATIC_ANON

org.apache.ofbiz.minilang.method.conditional.CombinedConditional

 

• Boxing/unboxing to parse a primitive

A boxed primitive is created from a String, just to extract the unboxed primitive value. It is more efficient to just call the static parseXXX method.

**

Bug kind and pattern: Bx - DM_BOXED_PRIMITIVE_FOR_PARSING

org.apache.ofbiz.minilang.method.otherops.Calculate