Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-10337

Check for only QOH while doing reservations

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Major
    • Resolution: Fixed
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Branch
    • Component/s: product
    • Labels:
      None

      Description

      While checking around code around inventory reservations, I was surprised to see that reserveProductInventory service only checks for QOH quantity greater than zero apart from that when reserveFromInventoryItemInline is called, it checks for ATP confirming system to behave as required.

      Everything works fine but this is redundant code and we can have check for ATP at top level so make reservations logic works faster. We can improve this flow by adding ATP check at reserveProductInventory service as well.

      We can check QOH being on safer side, but ideally a system will always have lesser ATP than QOH and logically we should only check for ATP while doing reservations.

      Same discussion is also available on dev ML.

        Attachments

          Activity

            People

            • Assignee:
              rishisolankii Rishi Solanki
              Reporter:
              suraj.khurana Suraj Khurana
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: