Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-10304

The "request" attribute type of the userLogin service is wrong

Attach filesAttach ScreenshotVotersWatch issueWatchersCreate sub-taskLinkCloneUpdate Comment AuthorReplace String in CommentUpdate Comment VisibilityDelete Comments
    XMLWordPrintableJSON

Details

    • Bug
    • Status: Closed
    • Blocker
    • Resolution: Fixed
    • 17.12.01
    • 17.12.01
    • framework
    • None

    Description

      I commited http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/ContextFilter.java?r1=1813679&r2=1813678&pathrev=1813679 which I guess forced (or allowed?) James Yong to use the javax.servlet.http.HttpServletRequest as type of "request" attribute of the userLogin service at http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/framework/common/servicedef/services.xml?r1=1819133&r2=1819132&pathrev=1819133

      Else it would (should?) have been
      <attribute name="request" mode="IN" type="org.apache.catalina.connector.RequestFacade" optional="true"/>

      Now I need to revert/remove the wrapper in ContextFilter which is useless and silly (my bad).

      After a deeper investigation today (saturday 2019-03-24) the right solution is now attached as a patch
      UPDATE: we had a discussion on this subject at https://markmail.org/message/4jwrnbhpapb4ncrd and Scott suggested to rather temporary use the <type-validate> child element of the <service> <attribute> element. Temporary because the definitive solution (w/o using <type-validate>) could be either to update to Tomcat 9 (preferred) or even downgrade to Tomcat 8. I guess nobody really want the later because only the trunk and not yet released R17.12 branch are concerned.

      Attachments

        Issue Links

        Activity

          This comment will be Viewable by All Users Viewable by All Users
          Cancel

          People

            jleroux Jacques Le Roux
            jleroux Jacques Le Roux
            Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

              Created:
              Updated:
              Resolved:

              Issue deployment