Details

    • Type: Improvement Improvement
    • Status: Closed
    • Priority: Minor Minor
    • Resolution: Won't Fix
    • Affects Version/s: SVN trunk
    • Fix Version/s: SVN trunk
    • Component/s: framework
    • Labels:
      None
    • Environment:

      Win XP

      Description

      This issue is part of Key-Work Ofbiz Contribution Proposal.
      http://docs.ofbiz.org/display/OFBIZ/Key-Work+Ofbiz+Contribution+Proposal

      Based on Release: 540035
      Includes: -
      Required: JIRA-1016
      Recommended:
      Classes: TransactionUtil.java, OfbizTransactionState.java,
      DebugXaResource.java, TxDelegate.java,
      CommonServices.java
      Description: Refactoring of TransactionUtil and helper for wrapping
      single operations in a new transaction.

      1. special-interest-code.zip
        171 kB
        Karl Eilebrecht
      2. OfbizTransactionHandlingEn.pdf
        44 kB
        Karl Eilebrecht
      3. patch9671.patch
        106 kB
        Karl Eilebrecht

        Activity

        Hide
        Karl Eilebrecht added a comment -

        Hi Philippe!

        Of course I'd never come to the disgusting idea to provide code in another way than a patch, because this would violate OFBiz-conventions!

        However one could take a look into the attached zip-file, maybe accidently some classes slipped into ...

        Regards.
        Karl

        Show
        Karl Eilebrecht added a comment - Hi Philippe! Of course I'd never come to the disgusting idea to provide code in another way than a patch, because this would violate OFBiz-conventions! However one could take a look into the attached zip-file, maybe accidently some classes slipped into ... Regards. Karl
        Hide
        Philippe Mouawad added a comment -

        Hello Karl,
        I looked at the patch but it is rather hard to read, could you attach the classes in a zip file instead of patch format ?

        Thank you
        Regards
        Philippe
        http://www.ubik-ingenierie.com

        Show
        Philippe Mouawad added a comment - Hello Karl, I looked at the patch but it is rather hard to read, could you attach the classes in a zip file instead of patch format ? Thank you Regards Philippe http://www.ubik-ingenierie.com
        Hide
        David E. Jones added a comment -

        I reviewed an early patch from Karl related to this and had some comments, but it was a long time ago and possibly just on the mailing list, so I don't know where those are.

        I haven't reviewed this enough to vote yes or no, but before we do anything with something really low level like this a few people should thoroughly review it and vote +1 before we do it, and each reviewer should make sure they understand well this patch and all of the code it touches, as well as apply it and run it first.

        It would be great to get this reviewed and committed. I'm guessing to properly review and test and commit this would take a day or two, so hopefully someone with relevant expertise has the time to do so!

        Show
        David E. Jones added a comment - I reviewed an early patch from Karl related to this and had some comments, but it was a long time ago and possibly just on the mailing list, so I don't know where those are. I haven't reviewed this enough to vote yes or no, but before we do anything with something really low level like this a few people should thoroughly review it and vote +1 before we do it, and each reviewer should make sure they understand well this patch and all of the code it touches, as well as apply it and run it first. It would be great to get this reviewed and committed. I'm guessing to properly review and test and commit this would take a day or two, so hopefully someone with relevant expertise has the time to do so!
        Hide
        Si Chen added a comment -

        Has anybody looked at this? I think this would be a good feature.

        Show
        Si Chen added a comment - Has anybody looked at this? I think this would be a good feature.

          People

          • Assignee:
            Si Chen
            Reporter:
            Karl Eilebrecht
          • Votes:
            0 Vote for this issue
            Watchers:
            2 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development