[OFBIZ-10298] Fluent API Bug in getFieldList()

• Type: Bug
• Status: Closed
• Priority: Minor
• Resolution: Fixed
• Affects Version/s: Release Branch 18.12, Release Branch 17.12, Trunk
• Fix Version/s: 17.12.01, 18.12.01
• Component/s: framework
• Sprint: OFBiz Community Day (Feb 2020)
• Assignee: Michael Brohl
• Reporter: Benjamin Jugl
• Created: 20/Mar/18 14:34
• Updated: 25/Feb/20 20:17
• Resolved: 25/Feb/20 20:17

Description

In EntityQuery the method getFieldList() uses the class variable distinct to decide if the list of genericValues should be stored in a set to eliminate duplicate values. This variable is set by the function distinct() and normally it should only be used for the sql statement. But here the flag gets mistreated since, if the list of values was ordered because of orderBy(), the order of values gets lost by putting them into a set. To summarize, the following statement:

....orderBy("...").dinstinct().getFieldLlist("...");

does not produce an ordered list.

Replacing the HashSet by a LinkedHashSet fixes this issue.