[OFBIZ-10146] Removing of loadBestSellingCategory and all related methods in CategoryServices.xml

• Type: Improvement
• Status: Closed
• Priority: Minor
• Resolution: Implemented
• Affects Version/s: Trunk
• Fix Version/s: 18.12.01
• Component/s: product
• Assignee: Jacques Le Roux
• Reporter: Dennis Balkir
• Created: 05/Jan/18 15:13
• Updated: 02/Aug/19 16:18
• Resolved: 02/Feb/18 15:56

Description

While doing some conversions from MiniLang to Groovy, I stumbled across these methods:
loadBestSellingCategory
RemoveProductFromBestSellCategory
AddProductToBestSellCategory
FindCategoryChild
FindBestSellingProduct

These are all in CategoryServices.xml.

I started realizing, that the simple-method loadBestSellingCategory doesn't work right (there are some logical failures in it) and while fixing it,
I searched for places where this is used, but couldn't find any.
I started looking deeper into it and found that all of these methods are never used anywhere in OFBiz, neither are the services which are declared for this methods.

This is why I propose to remove them; they have no real use, since they don't work properly, and also are never used.

Issue Links

• causes: OFBIZ-10760 Errors and warnings in webtools' ArtifactInfo