Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-10146

Removing of loadBestSellingCategory and all related methods in CategoryServices.xml

    Details

    • Type: Improvement
    • Status: Closed
    • Priority: Minor
    • Resolution: Implemented
    • Affects Version/s: Trunk
    • Fix Version/s: Upcoming Branch
    • Component/s: product
    • Labels:
      None

      Description

      While doing some conversions from MiniLang to Groovy, I stumbled across these methods:
      loadBestSellingCategory
      RemoveProductFromBestSellCategory
      AddProductToBestSellCategory
      FindCategoryChild
      FindBestSellingProduct

      These are all in CategoryServices.xml.

      I started realizing, that the simple-method loadBestSellingCategory doesn't work right (there are some logical failures in it) and while fixing it,
      I searched for places where this is used, but couldn't find any.
      I started looking deeper into it and found that all of these methods are never used anywhere in OFBiz, neither are the services which are declared for this methods.

      This is why I propose to remove them; they have no real use, since they don't work properly, and also are never used.

        Attachments

        1. OFBIZ-10146.patch
          12 kB
          Dennis Balkir
        2. OFBIZ-10146.patch
          8 kB
          Dennis Balkir

          Activity

            People

            • Assignee:
              jacques.le.roux Jacques Le Roux
              Reporter:
              Dennis Balkir Dennis Balkir
            • Votes:
              0 Vote for this issue
              Watchers:
              3 Start watching this issue

              Dates

              • Created:
                Updated:
                Resolved: