Uploaded image for project: 'OFBiz'
  1. OFBiz
  2. OFBIZ-10091

Unnecessary throws clauses in renderer classes?

    XMLWordPrintableJSON

    Details

    • Type: Improvement
    • Status: Open
    • Priority: Minor
    • Resolution: Unresolved
    • Affects Version/s: Trunk
    • Fix Version/s: None
    • Component/s: framework
    • Labels:
      None

      Description

      During the refactoring work I found that there are several classes in org.apache.ofbiz.widget.renderer.macro which state in their method declarations that they throw TemplateException and/or IOException.

      In many cases, there is either no evidence of these Exceptions or they are catched inside the methods.

      One example is the MacroFormRenderer constructor which says it throws TemplateException but does not.

      The method declarations in the interfaces of org.apache.ofbiz.widget.renderer all say that IOException is thrown.

      It might be that I overlook something and I did not dig much deeper into the code so I first want to ask what the reasons are or if it would not be reasonable to make a difference in interfaces and implementations and only declare that a method throws a specific exception if it really does?

      Thanks for your help,
      regards,
      Michael

        Attachments

          Issue Links

            Activity

              People

              • Assignee:
                mbrohl Michael Brohl
                Reporter:
                mbrohl Michael Brohl
              • Votes:
                0 Vote for this issue
                Watchers:
                2 Start watching this issue

                Dates

                • Created:
                  Updated: