[ODFTOOLKIT-468] OdfPackage file insertion got unclosed FileInputStream

• Type: Bug
• Status: Open
• Priority: Major
• Resolution: Unresolved
• Component/s: odfdom
• Labels: pull-request-available
• Environment: odfdom-java-0.8.11-incubating
• External issue URL: https://github.com/apache/odftoolkit/pull/2
• Assignee: Unassigned
• Reporter: Mathieu Stempell
• Created: 12/Jan/18 10:50
• Updated: 12/Jan/18 10:55

Description

Any inserted file still got a handle after using OdfPackage.insert(URI sourceURI, String internalPath, String mediaType), as opened InputStream there is never closed (only an explicit System.gc() call could free the file). This can also lead to memory leakage of course.

I pushed a fix (closing the instancied InputStream) as pull request here: https://github.com/apache/odftoolkit/pull/2