[ODFTOOLKIT-432] Replace String.isEmpty() API for Java 5 compatible

• Type: Bug
• Status: Open
• Priority: Minor
• Resolution: Unresolved
• Affects Version/s: 0.6.1-incubating
• Component/s: odfdom, simple api
• Environment: JRE/JDK 1.5 in all operating system.
• Assignee: Unassigned
• Reporter: Beck Yang
• Created: 17/May/16 02:58
• Updated: 17/May/16 02:58

Description

The String.isEmpty() API is offered since Java 6. It sould be replaced with Java 5 compatible API.
Here are related codes that I found:

Index: simple/src/main/java/org/odftoolkit/simple/common/navigation/ParagraphSelection.java
===================================================================
— simple/src/main/java/org/odftoolkit/simple/common/navigation/ParagraphSelection.java (revision ?)
+++ simple/src/main/java/org/odftoolkit/simple/common/navigation/ParagraphSelection.java (working copy)
@@ -304,6 +304,6 @@
.getOdfAttributeValue(
OdfName.newName(OdfDocumentNamespace.STYLE,
"master-page-name"));

• if (masterStyle != null && !masterStyle.isEmpty()) {
  + if (masterStyle != null && masterStyle.length() > 0) {
  if (posInPara.equals("head") || posInPara.equals("whole")) {
  getParagraphStyleElementForWrite().setOdfAttributeValue(

Index: simple/src/main/java/org/odftoolkit/simple/common/navigation/TableSelection.java
===================================================================
— simple/src/main/java/org/odftoolkit/simple/common/navigation/TableSelection.java (revision ?)
+++ simple/src/main/java/org/odftoolkit/simple/common/navigation/TableSelection.java (working copy)
@@ -401,6 +401,6 @@
.getOdfAttributeValue(
OdfName.newName(OdfDocumentNamespace.STYLE,
"master-page-name"));

• if (masterStyle != null && !masterStyle.isEmpty()) {
  + if (masterStyle != null && masterStyle.length() > 0) {
  if (posInPara.equals("head") || posInPara.equals("whole")) {
  getParagraphStyleElementForWrite().setOdfAttributeValue(

Index: odfdom/src/main/java/org/odftoolkit/odfdom/pkg/rdfa/JenaSink.java
===================================================================
— odfdom/src/main/java/org/odftoolkit/odfdom/pkg/rdfa/JenaSink.java (revision ?)
+++ odfdom/src/main/java/org/odftoolkit/odfdom/pkg/rdfa/JenaSink.java (working copy)
@@ -77,6 +77,6 @@

//@Override
public void addLiteral(String subject, String predicate, String lex, String lang, String datatype) {

• if (lex.isEmpty()){
  + if (lex.length() == 0) { return; }

Index: odfdom/src/main/java/org/odftoolkit/odfdom/pkg/OdfPackage.java
===================================================================
— odfdom/src/main/java/org/odftoolkit/odfdom/pkg/OdfPackage.java (revision ?)
+++ odfdom/src/main/java/org/odftoolkit/odfdom/pkg/OdfPackage.java (working copy)
@@ -664,6 +664,6 @@
*/
void cacheDocument(OdfPackageDocument doc, String internalPath) {

• if (!internalPath.isEmpty()) {
  + if (internalPath.length() > 0) {
  internalPath = normalizeDirectoryPath(internalPath);
  updateFileEntry(ensureFileEntryExistence(internalPath), doc.getMediaTypeString());
  mPkgDocuments.put(internalPath, doc);