[ODFTOOLKIT-312] PATCH: Better exception handling for OdfPackage (swallows IOExceptions on save())

• Type: Bug
• Status: Resolved
• Priority: Major
• Resolution: Fixed
• Affects Version/s: simple-0.5.5
• Fix Version/s: simple-0.5.5, 0.6-incubating
• Component/s: odfdom
• Labels: patch
• Assignee: Svante Schubert
• Reporter: Jeremias Maerki
• Created: 23/Mar/12 14:17
• Updated: 10/Jan/13 03:02
• Resolved: 04/Apr/12 12:24

Description

Related thread: http://mail-archives.apache.org/mod_mbox/incubator-odf-dev/201203.mbox/[e-mail]%3E

Executive summary: OdfPackage does too much exception catching causing real problems not being detected by client programs (because the exceptions are only logged). Similar patterns were observed when reading an ODF package. The attached patch tries to introduce a better exception handling throughout the OdfPackage class. Instead of throwing Exception, methods now throw IOException and SAXException. The existing load-side fault tolerance is preserved but the client can now abort processing if a potentially bad ODF file is read because exceptions thrown in the ErrorHandlers are no longer swallowed.

I hope you find the proposed changes useful. They are backed by unit tests.