ODE
  1. ODE
  2. ODE-749

StaticCheckSuite doesn't run with the normal tests.

    Details

    • Type: Test Test
    • Status: Resolved
    • Priority: Major Major
    • Resolution: Fixed
    • Affects Version/s: 1.3.3
    • Fix Version/s: 1.3.4
    • Labels:
      None

      Description

      The StaticCheckSuite doesn't run as the class extends TestCase, not TestSuite.

      The tests it defines don't run well as they miss setting a XSL transformer.

      1. ODE-749.log
        6 kB
        Antoine Toulme

        Activity

        Antoine Toulme created issue -
        Hide
        Antoine Toulme added a comment -

        Patch that fixes the issue. Note that one of the test cases fail. I would be ok to look into that later.

        Show
        Antoine Toulme added a comment - Patch that fixes the issue. Note that one of the test cases fail. I would be ok to look into that later.
        Antoine Toulme made changes -
        Field Original Value New Value
        Attachment execute_failing_compilations [ 12430967 ]
        Hide
        Antoine Toulme added a comment -

        Here is a better patch that puts back the test suite as part of the tests, and also fixes the broken test.

        Show
        Antoine Toulme added a comment - Here is a better patch that puts back the test suite as part of the tests, and also fixes the broken test.
        Antoine Toulme made changes -
        Attachment ODE-749 [ 12431235 ]
        Antoine Toulme made changes -
        Attachment execute_failing_compilations [ 12430967 ]
        Antoine Toulme made changes -
        Attachment ODE-749 [ 12431235 ]
        Antoine Toulme made changes -
        Attachment ODE-749.log [ 12431236 ]
        Hide
        Rafal Rusin added a comment -

        Which test does this patch fix?
        Also a note for future. Could you name patches like ODE-749.patch? Because log suffix is confusing.

        Regards

        Show
        Rafal Rusin added a comment - Which test does this patch fix? Also a note for future. Could you name patches like ODE-749 .patch? Because log suffix is confusing. Regards
        Hide
        Antoine Toulme added a comment -

        Yes, sorry for the misnaming, that's the downside of making a patch late at night.

        This patch fixes the test UnknownBpelFunction.

        Show
        Antoine Toulme added a comment - Yes, sorry for the misnaming, that's the downside of making a patch late at night. This patch fixes the test UnknownBpelFunction.
        Rafal Rusin made changes -
        Assignee Rafal Rusin [ rrusin ]
        Hide
        Rafal Rusin added a comment -

        Thanks!, this patch fixed problems.

        Show
        Rafal Rusin added a comment - Thanks!, this patch fixed problems.
        Rafal Rusin made changes -
        Status Open [ 1 ] Resolved [ 5 ]
        Fix Version/s 1.3.4 [ 12314168 ]
        Resolution Fixed [ 1 ]
        Hide
        Hudson added a comment -

        Integrated in ODE-1.x #49 (See http://hudson.zones.apache.org/hudson/job/ODE-1.x/49/)
        : StaticCheckSuite doesn't run with the normal tests (Thanks to Antoine Toulme)

        Show
        Hudson added a comment - Integrated in ODE-1 .x #49 (See http://hudson.zones.apache.org/hudson/job/ODE-1.x/49/ ) : StaticCheckSuite doesn't run with the normal tests (Thanks to Antoine Toulme)

          People

          • Assignee:
            Rafal Rusin
            Reporter:
            Antoine Toulme
          • Votes:
            0 Vote for this issue
            Watchers:
            0 Start watching this issue

            Dates

            • Created:
              Updated:
              Resolved:

              Development